Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix brax #1346

Merged
merged 3 commits into from
Jul 2, 2023
Merged

[BugFix] Fix brax #1346

merged 3 commits into from
Jul 2, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 2, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2023
@vmoens vmoens merged commit fa4fe1d into main Jul 2, 2023
@vmoens vmoens deleted the fix_brax branch July 2, 2023 11:38
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1666s 0.1662s 6.0177 Ops/s 6.0818 Ops/s $\color{#d91a1a}-1.05\%$
test_sync 91.8968ms 87.9331ms 11.3723 Ops/s 11.3062 Ops/s $\color{#35bf28}+0.58\%$
test_async 0.1462s 85.3716ms 11.7135 Ops/s 11.5405 Ops/s $\color{#35bf28}+1.50\%$
test_simple 0.6813s 0.6029s 1.6587 Ops/s 1.6478 Ops/s $\color{#35bf28}+0.66\%$
test_transformed 1.6740s 1.6134s 0.6198 Ops/s 0.6332 Ops/s $\color{#d91a1a}-2.11\%$
test_serial 2.0271s 1.9573s 0.5109 Ops/s 0.5101 Ops/s $\color{#35bf28}+0.16\%$
test_parallel 1.6987s 1.5798s 0.6330 Ops/s 0.6276 Ops/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[True-True-True-True-True] 0.3188ms 39.1552μs 25.5394 KOps/s 25.7111 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[True-True-True-True-False] 53.9020μs 22.1059μs 45.2367 KOps/s 46.4674 KOps/s $\color{#d91a1a}-2.65\%$
test_step_mdp_speed[True-True-True-False-True] 56.5030μs 30.0404μs 33.2885 KOps/s 33.8048 KOps/s $\color{#d91a1a}-1.53\%$
test_step_mdp_speed[True-True-True-False-False] 40.5010μs 16.4235μs 60.8884 KOps/s 61.3484 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-True-False-True-True] 68.9020μs 40.4015μs 24.7515 KOps/s 24.8421 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[True-True-False-True-False] 47.5020μs 22.8748μs 43.7162 KOps/s 43.9276 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-False-False-True] 55.3020μs 31.3792μs 31.8683 KOps/s 32.4067 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-True-False-False-False] 0.5538ms 18.0106μs 55.5229 KOps/s 56.5133 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[True-False-True-True-True] 0.2489ms 42.1369μs 23.7322 KOps/s 24.1686 KOps/s $\color{#d91a1a}-1.81\%$
test_step_mdp_speed[True-False-True-True-False] 96.2030μs 23.9992μs 41.6680 KOps/s 41.4134 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[True-False-True-False-True] 0.1085ms 31.3384μs 31.9097 KOps/s 32.6434 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[True-False-True-False-False] 49.0020μs 17.6182μs 56.7594 KOps/s 57.0057 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-False-False-True-True] 0.1260ms 43.1711μs 23.1637 KOps/s 23.6120 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[True-False-False-True-False] 0.1148ms 25.5477μs 39.1424 KOps/s 39.5013 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[True-False-False-False-True] 0.1619ms 33.0105μs 30.2934 KOps/s 31.2861 KOps/s $\color{#d91a1a}-3.17\%$
test_step_mdp_speed[True-False-False-False-False] 0.1040ms 18.7486μs 53.3372 KOps/s 53.3434 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[False-True-True-True-True] 81.7030μs 41.3182μs 24.2024 KOps/s 24.1026 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[False-True-True-True-False] 83.8040μs 24.0073μs 41.6540 KOps/s 41.4823 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[False-True-True-False-True] 91.0040μs 35.9080μs 27.8490 KOps/s 28.3895 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[False-True-True-False-False] 85.5030μs 19.3370μs 51.7144 KOps/s 51.6310 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[False-True-False-True-True] 79.7030μs 42.7275μs 23.4041 KOps/s 23.3495 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[False-True-False-True-False] 0.1126ms 25.3321μs 39.4756 KOps/s 39.7528 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[False-True-False-False-True] 0.1212ms 37.0747μs 26.9726 KOps/s 27.4704 KOps/s $\color{#d91a1a}-1.81\%$
test_step_mdp_speed[False-True-False-False-False] 0.5959ms 20.6397μs 48.4503 KOps/s 48.6504 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-False-True-True-True] 0.1265ms 43.6507μs 22.9091 KOps/s 22.8112 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[False-False-True-True-False] 0.1472ms 26.4280μs 37.8386 KOps/s 37.9575 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[False-False-True-False-True] 61.6020μs 37.0421μs 26.9963 KOps/s 27.2719 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-False-True-False-False] 0.1107ms 20.4281μs 48.9521 KOps/s 49.9737 KOps/s $\color{#d91a1a}-2.04\%$
test_step_mdp_speed[False-False-False-True-True] 76.6030μs 44.7020μs 22.3704 KOps/s 22.3682 KOps/s $+0.01\%$
test_step_mdp_speed[False-False-False-True-False] 0.1205ms 27.3793μs 36.5239 KOps/s 36.4525 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[False-False-False-False-True] 0.1396ms 37.4354μs 26.7127 KOps/s 27.0947 KOps/s $\color{#d91a1a}-1.41\%$
test_step_mdp_speed[False-False-False-False-False] 65.7030μs 21.5608μs 46.3804 KOps/s 47.0544 KOps/s $\color{#d91a1a}-1.43\%$
test_values[generalized_advantage_estimate-True-True] 14.9015ms 13.1267ms 76.1808 Ops/s 74.1107 Ops/s $\color{#35bf28}+2.79\%$
test_values[vec_generalized_advantage_estimate-True-True] 48.2206ms 44.6413ms 22.4008 Ops/s 22.0870 Ops/s $\color{#35bf28}+1.42\%$
test_values[td0_return_estimate-False-False] 0.4156ms 0.2116ms 4.7266 KOps/s 3.9861 KOps/s $\textbf{\color{#35bf28}+18.58\%}$
test_values[td1_return_estimate-False-False] 13.2382ms 12.8813ms 77.6321 Ops/s 75.8159 Ops/s $\color{#35bf28}+2.40\%$
test_values[vec_td1_return_estimate-False-False] 53.1352ms 45.4083ms 22.0224 Ops/s 22.4743 Ops/s $\color{#d91a1a}-2.01\%$
test_values[td_lambda_return_estimate-True-False] 31.8530ms 31.2455ms 32.0046 Ops/s 32.0812 Ops/s $\color{#d91a1a}-0.24\%$
test_values[vec_td_lambda_return_estimate-True-False] 55.5029ms 44.9620ms 22.2410 Ops/s 22.6208 Ops/s $\color{#d91a1a}-1.68\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.6735ms 11.2711ms 88.7227 Ops/s 88.3162 Ops/s $\color{#35bf28}+0.46\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 3.8502ms 3.4970ms 285.9568 Ops/s 292.1809 Ops/s $\color{#d91a1a}-2.13\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 1.0395ms 0.4602ms 2.1728 KOps/s 2.1740 KOps/s $\color{#d91a1a}-0.05\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 61.5246ms 58.9246ms 16.9708 Ops/s 16.3197 Ops/s $\color{#35bf28}+3.99\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.4150ms 2.9163ms 342.8996 Ops/s 327.9548 Ops/s $\color{#35bf28}+4.56\%$
test_dqn_speed 2.0875ms 1.6357ms 611.3498 Ops/s 581.1662 Ops/s $\textbf{\color{#35bf28}+5.19\%}$
test_ddpg_speed 10.7767ms 2.8073ms 356.2165 Ops/s 339.7424 Ops/s $\color{#35bf28}+4.85\%$
test_sac_speed 10.0371ms 8.3548ms 119.6917 Ops/s 120.7940 Ops/s $\color{#d91a1a}-0.91\%$
test_redq_speed 17.8952ms 15.8645ms 63.0338 Ops/s 63.5313 Ops/s $\color{#d91a1a}-0.78\%$
test_redq_deprec_speed 14.9183ms 12.5046ms 79.9703 Ops/s 76.6233 Ops/s $\color{#35bf28}+4.37\%$
test_td3_speed 13.7979ms 11.3111ms 88.4089 Ops/s 88.8550 Ops/s $\color{#d91a1a}-0.50\%$
test_cql_speed 39.6970ms 36.5917ms 27.3286 Ops/s 35.0556 Ops/s $\textbf{\color{#d91a1a}-22.04\%}$
test_a2c_speed 6.3207ms 5.4557ms 183.2939 Ops/s 186.3212 Ops/s $\color{#d91a1a}-1.62\%$
test_ppo_speed 10.2141ms 5.8140ms 171.9973 Ops/s 155.9891 Ops/s $\textbf{\color{#35bf28}+10.26\%}$
test_reinforce_speed 6.0550ms 4.3221ms 231.3712 Ops/s 229.3373 Ops/s $\color{#35bf28}+0.89\%$
test_iql_speed 34.2729ms 24.0579ms 41.5664 Ops/s 44.4559 Ops/s $\textbf{\color{#d91a1a}-6.50\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 0.1490s 5.0132ms 199.4737 Ops/s 228.1725 Ops/s $\textbf{\color{#d91a1a}-12.58\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 8.6141ms 4.5874ms 217.9896 Ops/s 219.1832 Ops/s $\color{#d91a1a}-0.54\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 7.1317ms 4.5647ms 219.0732 Ops/s 214.8873 Ops/s $\color{#35bf28}+1.95\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 0.3598s 5.9999ms 166.6706 Ops/s 219.5521 Ops/s $\textbf{\color{#d91a1a}-24.09\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 7.5637ms 4.5432ms 220.1091 Ops/s 220.0599 Ops/s $\color{#35bf28}+0.02\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.2003s 5.4171ms 184.5999 Ops/s 218.9985 Ops/s $\textbf{\color{#d91a1a}-15.71\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3328ms 4.3685ms 228.9095 Ops/s 227.2314 Ops/s $\color{#35bf28}+0.74\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 6.9124ms 4.6023ms 217.2823 Ops/s 218.7067 Ops/s $\color{#d91a1a}-0.65\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 9.1643ms 4.6672ms 214.2634 Ops/s 219.0757 Ops/s $\color{#d91a1a}-2.20\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 0.1476s 5.0447ms 198.2262 Ops/s 227.5873 Ops/s $\textbf{\color{#d91a1a}-12.90\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 7.5378ms 4.5866ms 218.0257 Ops/s 219.7075 Ops/s $\color{#d91a1a}-0.77\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1995s 5.4619ms 183.0875 Ops/s 198.3844 Ops/s $\textbf{\color{#d91a1a}-7.71\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.4146ms 4.3632ms 229.1879 Ops/s 227.9122 Ops/s $\color{#35bf28}+0.56\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 8.9625ms 4.5751ms 218.5733 Ops/s 197.0722 Ops/s $\textbf{\color{#35bf28}+10.91\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 8.8595ms 4.6115ms 216.8495 Ops/s 208.4690 Ops/s $\color{#35bf28}+4.02\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 0.1436s 4.9720ms 201.1251 Ops/s 226.4787 Ops/s $\textbf{\color{#d91a1a}-11.19\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 8.6356ms 4.6327ms 215.8545 Ops/s 207.1532 Ops/s $\color{#35bf28}+4.20\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.2362ms 4.5309ms 220.7071 Ops/s 211.4477 Ops/s $\color{#35bf28}+4.38\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3982s 40.7981ms 24.5109 Ops/s 25.5009 Ops/s $\color{#d91a1a}-3.88\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1947s 36.8567ms 27.1321 Ops/s 25.7771 Ops/s $\textbf{\color{#35bf28}+5.26\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1935s 36.4851ms 27.4085 Ops/s 28.0796 Ops/s $\color{#d91a1a}-2.39\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1902s 36.5367ms 27.3698 Ops/s 28.2314 Ops/s $\color{#d91a1a}-3.05\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1932s 36.3543ms 27.5071 Ops/s 27.9379 Ops/s $\color{#d91a1a}-1.54\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1941s 40.2420ms 24.8496 Ops/s 28.0473 Ops/s $\textbf{\color{#d91a1a}-11.40\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1921s 36.7063ms 27.2433 Ops/s 25.9592 Ops/s $\color{#35bf28}+4.95\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1897s 36.5166ms 27.3848 Ops/s 28.3399 Ops/s $\color{#d91a1a}-3.37\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1951s 36.5745ms 27.3414 Ops/s 28.5116 Ops/s $\color{#d91a1a}-4.10\%$

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}11$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1602s 0.1601s 6.2468 Ops/s 6.2194 Ops/s $\color{#35bf28}+0.44\%$
test_sync 90.4266ms 84.9895ms 11.7662 Ops/s 11.9245 Ops/s $\color{#d91a1a}-1.33\%$
test_async 0.1477s 82.7641ms 12.0825 Ops/s 12.1088 Ops/s $\color{#d91a1a}-0.22\%$
test_simple 0.6955s 0.6086s 1.6430 Ops/s 1.6474 Ops/s $\color{#d91a1a}-0.27\%$
test_transformed 1.6244s 1.5614s 0.6404 Ops/s 0.6508 Ops/s $\color{#d91a1a}-1.59\%$
test_serial 2.0377s 1.9593s 0.5104 Ops/s 0.5129 Ops/s $\color{#d91a1a}-0.49\%$
test_parallel 1.5995s 1.5131s 0.6609 Ops/s 0.6457 Ops/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[True-True-True-True-True] 0.6563ms 31.3592μs 31.8885 KOps/s 32.1043 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[True-True-True-True-False] 0.1726ms 17.5631μs 56.9377 KOps/s 57.4718 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[True-True-True-False-True] 0.1322ms 23.4631μs 42.6201 KOps/s 43.0179 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[True-True-True-False-False] 0.3485ms 13.0285μs 76.7547 KOps/s 77.0842 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-True-False-True-True] 80.2010μs 32.3294μs 30.9316 KOps/s 31.2205 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[True-True-False-True-False] 43.8010μs 18.7056μs 53.4598 KOps/s 53.9479 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[True-True-False-False-True] 0.1209ms 24.8757μs 40.1999 KOps/s 41.0373 KOps/s $\color{#d91a1a}-2.04\%$
test_step_mdp_speed[True-True-False-False-False] 46.0010μs 14.2096μs 70.3752 KOps/s 71.0552 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[True-False-True-True-True] 0.1183ms 33.7397μs 29.6387 KOps/s 30.1844 KOps/s $\color{#d91a1a}-1.81\%$
test_step_mdp_speed[True-False-True-True-False] 48.4010μs 19.8318μs 50.4241 KOps/s 51.5301 KOps/s $\color{#d91a1a}-2.15\%$
test_step_mdp_speed[True-False-True-False-True] 3.7651ms 25.1509μs 39.7600 KOps/s 41.3128 KOps/s $\color{#d91a1a}-3.76\%$
test_step_mdp_speed[True-False-True-False-False] 58.3000μs 14.1205μs 70.8189 KOps/s 71.2617 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-False-False-True-True] 0.1323ms 34.6676μs 28.8454 KOps/s 29.3688 KOps/s $\color{#d91a1a}-1.78\%$
test_step_mdp_speed[True-False-False-True-False] 50.6010μs 20.7258μs 48.2490 KOps/s 48.8508 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-False-False-False-True] 0.1004ms 25.6165μs 39.0373 KOps/s 39.7231 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-False-False-False-False] 51.6010μs 15.1864μs 65.8485 KOps/s 67.3742 KOps/s $\color{#d91a1a}-2.26\%$
test_step_mdp_speed[False-True-True-True-True] 0.1373ms 33.5277μs 29.8261 KOps/s 30.2392 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-True-True-True-False] 98.2010μs 19.6819μs 50.8081 KOps/s 51.3277 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-True-True-False-True] 68.4010μs 28.3354μs 35.2915 KOps/s 35.3789 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-True-False-False] 0.1052ms 15.7020μs 63.6863 KOps/s 64.3033 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[False-True-False-True-True] 0.1129ms 34.9961μs 28.5746 KOps/s 29.5021 KOps/s $\color{#d91a1a}-3.14\%$
test_step_mdp_speed[False-True-False-True-False] 0.1069ms 20.7434μs 48.2080 KOps/s 49.2548 KOps/s $\color{#d91a1a}-2.13\%$
test_step_mdp_speed[False-True-False-False-True] 55.6010μs 29.4031μs 34.0100 KOps/s 34.2105 KOps/s $\color{#d91a1a}-0.59\%$
test_step_mdp_speed[False-True-False-False-False] 0.1073ms 16.5778μs 60.3218 KOps/s 61.4961 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[False-False-True-True-True] 0.1397ms 35.9038μs 27.8522 KOps/s 28.6804 KOps/s $\color{#d91a1a}-2.89\%$
test_step_mdp_speed[False-False-True-True-False] 0.1637ms 22.0133μs 45.4272 KOps/s 46.6948 KOps/s $\color{#d91a1a}-2.71\%$
test_step_mdp_speed[False-False-True-False-True] 46.1010μs 29.9303μs 33.4110 KOps/s 34.1647 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[False-False-True-False-False] 69.5010μs 16.3865μs 61.0259 KOps/s 61.7265 KOps/s $\color{#d91a1a}-1.13\%$
test_step_mdp_speed[False-False-False-True-True] 74.3010μs 36.5742μs 27.3417 KOps/s 27.9709 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[False-False-False-True-False] 0.1250ms 22.9725μs 43.5302 KOps/s 44.4897 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-False-False-False-True] 0.6799ms 30.3070μs 32.9957 KOps/s 33.4282 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-False-False-False-False] 0.1309ms 17.3135μs 57.7585 KOps/s 56.9973 KOps/s $\color{#35bf28}+1.34\%$
test_values[generalized_advantage_estimate-True-True] 14.3910ms 13.6431ms 73.2971 Ops/s 71.7093 Ops/s $\color{#35bf28}+2.21\%$
test_values[vec_generalized_advantage_estimate-True-True] 48.0270ms 43.6499ms 22.9096 Ops/s 22.4175 Ops/s $\color{#35bf28}+2.19\%$
test_values[td0_return_estimate-False-False] 0.4237ms 0.2148ms 4.6564 KOps/s 4.8095 KOps/s $\color{#d91a1a}-3.18\%$
test_values[td1_return_estimate-False-False] 13.7837ms 13.2710ms 75.3523 Ops/s 75.4255 Ops/s $\color{#d91a1a}-0.10\%$
test_values[vec_td1_return_estimate-False-False] 46.4063ms 43.5204ms 22.9777 Ops/s 23.2610 Ops/s $\color{#d91a1a}-1.22\%$
test_values[td_lambda_return_estimate-True-False] 32.9646ms 32.2844ms 30.9747 Ops/s 31.0686 Ops/s $\color{#d91a1a}-0.30\%$
test_values[vec_td_lambda_return_estimate-True-False] 48.1451ms 43.4096ms 23.0364 Ops/s 23.1795 Ops/s $\color{#d91a1a}-0.62\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.9629ms 11.8445ms 84.4271 Ops/s 84.7057 Ops/s $\color{#d91a1a}-0.33\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 4.0428ms 3.4878ms 286.7158 Ops/s 291.6209 Ops/s $\color{#d91a1a}-1.68\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6861ms 0.4710ms 2.1232 KOps/s 2.1273 KOps/s $\color{#d91a1a}-0.19\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 62.2124ms 61.0785ms 16.3724 Ops/s 16.7349 Ops/s $\color{#d91a1a}-2.17\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.6794ms 2.9343ms 340.7914 Ops/s 354.0866 Ops/s $\color{#d91a1a}-3.75\%$
test_dqn_speed 7.7666ms 1.7063ms 586.0544 Ops/s 617.0239 Ops/s $\textbf{\color{#d91a1a}-5.02\%}$
test_ddpg_speed 4.4712ms 2.7124ms 368.6791 Ops/s 374.5548 Ops/s $\color{#d91a1a}-1.57\%$
test_sac_speed 9.5427ms 8.3590ms 119.6321 Ops/s 122.8561 Ops/s $\color{#d91a1a}-2.62\%$
test_redq_speed 16.6612ms 15.1614ms 65.9572 Ops/s 69.1522 Ops/s $\color{#d91a1a}-4.62\%$
test_redq_deprec_speed 13.7205ms 12.5529ms 79.6626 Ops/s 82.7029 Ops/s $\color{#d91a1a}-3.68\%$
test_td3_speed 11.6258ms 10.7155ms 93.3226 Ops/s 97.1732 Ops/s $\color{#d91a1a}-3.96\%$
test_cql_speed 42.9553ms 35.8723ms 27.8767 Ops/s 28.5499 Ops/s $\color{#d91a1a}-2.36\%$
test_a2c_speed 5.8814ms 5.3618ms 186.5046 Ops/s 196.7638 Ops/s $\textbf{\color{#d91a1a}-5.21\%}$
test_ppo_speed 6.1440ms 5.6417ms 177.2509 Ops/s 185.7810 Ops/s $\color{#d91a1a}-4.59\%$
test_reinforce_speed 11.9777ms 4.1244ms 242.4593 Ops/s 247.8662 Ops/s $\color{#d91a1a}-2.18\%$
test_iql_speed 37.8406ms 24.8033ms 40.3172 Ops/s 46.0009 Ops/s $\textbf{\color{#d91a1a}-12.36\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 0.1627s 4.3837ms 228.1191 Ops/s 280.4314 Ops/s $\textbf{\color{#d91a1a}-18.65\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 7.0291ms 4.0177ms 248.9006 Ops/s 258.7577 Ops/s $\color{#d91a1a}-3.81\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1973s 4.7606ms 210.0584 Ops/s 256.7370 Ops/s $\textbf{\color{#d91a1a}-18.18\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.2694ms 3.7993ms 263.2080 Ops/s 275.0177 Ops/s $\color{#d91a1a}-4.29\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 6.4821ms 3.9998ms 250.0126 Ops/s 261.1884 Ops/s $\color{#d91a1a}-4.28\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 7.5656ms 3.9827ms 251.0887 Ops/s 258.0361 Ops/s $\color{#d91a1a}-2.69\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 0.1462s 4.3191ms 231.5271 Ops/s 271.6586 Ops/s $\textbf{\color{#d91a1a}-14.77\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 6.4432ms 3.9717ms 251.7829 Ops/s 219.0030 Ops/s $\textbf{\color{#35bf28}+14.97\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.0462ms 3.9731ms 251.6941 Ops/s 264.7278 Ops/s $\color{#d91a1a}-4.92\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7934ms 3.7843ms 264.2501 Ops/s 273.8721 Ops/s $\color{#d91a1a}-3.51\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 8.2671ms 4.0472ms 247.0832 Ops/s 255.5696 Ops/s $\color{#d91a1a}-3.32\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.8441ms 4.0908ms 244.4526 Ops/s 209.6679 Ops/s $\textbf{\color{#35bf28}+16.59\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 0.1572s 4.4208ms 226.2041 Ops/s 270.5182 Ops/s $\textbf{\color{#d91a1a}-16.38\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 6.6759ms 4.0275ms 248.2920 Ops/s 251.2769 Ops/s $\color{#d91a1a}-1.19\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 7.3686ms 4.0083ms 249.4836 Ops/s 256.5742 Ops/s $\color{#d91a1a}-2.76\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3758ms 3.8085ms 262.5723 Ops/s 240.0519 Ops/s $\textbf{\color{#35bf28}+9.38\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 7.4868ms 4.0735ms 245.4888 Ops/s 262.6005 Ops/s $\textbf{\color{#d91a1a}-6.52\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.4834ms 4.0246ms 248.4734 Ops/s 219.3201 Ops/s $\textbf{\color{#35bf28}+13.29\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3163s 39.4073ms 25.3760 Ops/s 30.2253 Ops/s $\textbf{\color{#d91a1a}-16.04\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1868s 33.0695ms 30.2393 Ops/s 28.3958 Ops/s $\textbf{\color{#35bf28}+6.49\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1840s 32.9793ms 30.3221 Ops/s 31.7215 Ops/s $\color{#d91a1a}-4.41\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1825s 33.1056ms 30.2064 Ops/s 31.3810 Ops/s $\color{#d91a1a}-3.74\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1834s 36.1370ms 27.6725 Ops/s 31.0017 Ops/s $\textbf{\color{#d91a1a}-10.74\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1841s 33.2796ms 30.0484 Ops/s 28.7956 Ops/s $\color{#35bf28}+4.35\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1821s 33.2851ms 30.0435 Ops/s 31.6456 Ops/s $\textbf{\color{#d91a1a}-5.06\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1997s 33.6829ms 29.6887 Ops/s 30.9896 Ops/s $\color{#d91a1a}-4.20\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1904s 33.4728ms 29.8750 Ops/s 31.3496 Ops/s $\color{#d91a1a}-4.70\%$

@vmoens vmoens added the bug Something isn't working label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants