Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Batched envs compatibility with custom keys #1348

Merged
merged 11 commits into from
Jul 3, 2023
Merged

[BugFix] Batched envs compatibility with custom keys #1348

merged 11 commits into from
Jul 3, 2023

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jul 3, 2023 •
edited
Loading

Depends on #1347
Fixes #1269
Draws from #1270 which should be closed after

@matteobettini
refactor fake_tensordict
dafe892 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
refactor rollout
2cf6616 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
refactor rand_action
0ecf9f3 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
added test
9cc8c3e 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
make rollout keep_other=True
9314375 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2023
@matteobettini matteobettini changed the title [BugFix] Nested vec envs [BugFix] Batched envs compatibility with custom keys Jul 3, 2023
@matteobettini
parametric keys
baae9c2 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as draft July 3, 2023 10:10
@matteobettini
amend
482b29c 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
added tests and logic
4ff6eaf 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
typo
ab81961 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
amend
3412c1b 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as ready for review July 3, 2023 13:09
@matteobettini
Merge branch 'main' into nested_vec_envs
f37d5e7 
# Conflicts:
#	test/test_env.py
@vmoens vmoens added the bug Something isn't working label Jul 3, 2023
vmoens
vmoens approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this
Let's wait for the tests to pass

@vmoens vmoens merged commit 7889223 into pytorch:main Jul 3, 2023
@matteobettini matteobettini deleted the nested_vec_envs branch July 3, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] VecEnv not compatible with parametric keys
3 participants
@matteobettini @vmoens @facebook-github-bot