Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix tutorials #1382

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[BugFix] Fix tutorials #1382

merged 3 commits into from
Jul 11, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 11, 2023

cc @smorad

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2023
@vmoens vmoens added the bug Something isn't working label Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}33$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.2290s 0.2171s 4.6061 Ops/s 4.6392 Ops/s $\color{#d91a1a}-0.71\%$
test_sync 0.1202s 0.1141s 8.7645 Ops/s 8.8854 Ops/s $\color{#d91a1a}-1.36\%$
test_async 0.1869s 0.1124s 8.8978 Ops/s 8.6969 Ops/s $\color{#35bf28}+2.31\%$
test_simple 1.0509s 0.9673s 1.0338 Ops/s 0.9999 Ops/s $\color{#35bf28}+3.39\%$
test_transformed 2.4642s 2.4406s 0.4097 Ops/s 0.4026 Ops/s $\color{#35bf28}+1.77\%$
test_serial 3.2411s 3.1653s 0.3159 Ops/s 0.3185 Ops/s $\color{#d91a1a}-0.82\%$
test_parallel 2.6101s 2.4918s 0.4013 Ops/s 0.4007 Ops/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-True-True-True] 1.6801ms 59.9805μs 16.6721 KOps/s 17.0205 KOps/s $\color{#d91a1a}-2.05\%$
test_step_mdp_speed[True-True-True-True-False] 1.4585ms 33.6739μs 29.6966 KOps/s 30.3688 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[True-True-True-False-True] 1.5669ms 42.0449μs 23.7841 KOps/s 22.4819 KOps/s $\textbf{\color{#35bf28}+5.79\%}$
test_step_mdp_speed[True-True-True-False-False] 0.6501ms 22.6965μs 44.0597 KOps/s 40.3289 KOps/s $\textbf{\color{#35bf28}+9.25\%}$
test_step_mdp_speed[True-True-False-True-True] 1.7417ms 59.7510μs 16.7361 KOps/s 16.7716 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[True-True-False-True-False] 2.1036ms 35.6846μs 28.0233 KOps/s 28.9675 KOps/s $\color{#d91a1a}-3.26\%$
test_step_mdp_speed[True-True-False-False-True] 1.1822ms 42.8484μs 23.3381 KOps/s 23.1273 KOps/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[True-True-False-False-False] 0.8622ms 25.5308μs 39.1684 KOps/s 40.7418 KOps/s $\color{#d91a1a}-3.86\%$
test_step_mdp_speed[True-False-True-True-True] 0.7016ms 60.7458μs 16.4621 KOps/s 16.1596 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[True-False-True-True-False] 7.6616ms 38.4306μs 26.0209 KOps/s 27.7765 KOps/s $\textbf{\color{#d91a1a}-6.32\%}$
test_step_mdp_speed[True-False-True-False-True] 1.2075ms 44.4988μs 22.4725 KOps/s 23.6722 KOps/s $\textbf{\color{#d91a1a}-5.07\%}$
test_step_mdp_speed[True-False-True-False-False] 2.4350ms 25.8358μs 38.7060 KOps/s 39.6758 KOps/s $\color{#d91a1a}-2.44\%$
test_step_mdp_speed[True-False-False-True-True] 2.6986ms 67.7956μs 14.7502 KOps/s 15.9718 KOps/s $\textbf{\color{#d91a1a}-7.65\%}$
test_step_mdp_speed[True-False-False-True-False] 2.5492ms 39.8689μs 25.0822 KOps/s 25.9461 KOps/s $\color{#d91a1a}-3.33\%$
test_step_mdp_speed[True-False-False-False-True] 2.1847ms 45.3418μs 22.0547 KOps/s 19.8220 KOps/s $\textbf{\color{#35bf28}+11.26\%}$
test_step_mdp_speed[True-False-False-False-False] 3.6147ms 28.3382μs 35.2880 KOps/s 36.4276 KOps/s $\color{#d91a1a}-3.13\%$
test_step_mdp_speed[False-True-True-True-True] 5.5608ms 65.7939μs 15.1990 KOps/s 15.4413 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-True-True-True-False] 2.0385ms 37.1175μs 26.9415 KOps/s 26.3635 KOps/s $\color{#35bf28}+2.19\%$
test_step_mdp_speed[False-True-True-False-True] 3.0614ms 50.3253μs 19.8707 KOps/s 18.9878 KOps/s $\color{#35bf28}+4.65\%$
test_step_mdp_speed[False-True-True-False-False] 7.4690ms 28.6872μs 34.8588 KOps/s 34.7398 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[False-True-False-True-True] 2.6563ms 61.0439μs 16.3816 KOps/s 16.1150 KOps/s $\color{#35bf28}+1.65\%$
test_step_mdp_speed[False-True-False-True-False] 1.6897ms 38.4473μs 26.0096 KOps/s 26.6050 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[False-True-False-False-True] 1.0707ms 49.4974μs 20.2031 KOps/s 18.3287 KOps/s $\textbf{\color{#35bf28}+10.23\%}$
test_step_mdp_speed[False-True-False-False-False] 1.7516ms 29.2314μs 34.2098 KOps/s 30.8864 KOps/s $\textbf{\color{#35bf28}+10.76\%}$
test_step_mdp_speed[False-False-True-True-True] 2.0653ms 66.4405μs 15.0511 KOps/s 15.0992 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[False-False-True-True-False] 2.3886ms 39.3351μs 25.4226 KOps/s 24.8595 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[False-False-True-False-True] 3.0081ms 51.6373μs 19.3658 KOps/s 18.6181 KOps/s $\color{#35bf28}+4.02\%$
test_step_mdp_speed[False-False-True-False-False] 2.7286ms 30.5299μs 32.7548 KOps/s 32.1778 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[False-False-False-True-True] 8.1688ms 67.1347μs 14.8954 KOps/s 14.6776 KOps/s $\color{#35bf28}+1.48\%$
test_step_mdp_speed[False-False-False-True-False] 11.7337ms 44.5029μs 22.4704 KOps/s 23.3225 KOps/s $\color{#d91a1a}-3.65\%$
test_step_mdp_speed[False-False-False-False-True] 1.7686ms 52.8148μs 18.9341 KOps/s 18.1952 KOps/s $\color{#35bf28}+4.06\%$
test_step_mdp_speed[False-False-False-False-False] 4.8272ms 32.1441μs 31.1099 KOps/s 29.2745 KOps/s $\textbf{\color{#35bf28}+6.27\%}$
test_values[generalized_advantage_estimate-True-True] 23.0558ms 18.0202ms 55.4932 Ops/s 46.1302 Ops/s $\textbf{\color{#35bf28}+20.30\%}$
test_values[vec_generalized_advantage_estimate-True-True] 88.8649ms 77.2703ms 12.9416 Ops/s 12.4495 Ops/s $\color{#35bf28}+3.95\%$
test_values[td0_return_estimate-False-False] 0.6507ms 0.3417ms 2.9268 KOps/s 2.7132 KOps/s $\textbf{\color{#35bf28}+7.87\%}$
test_values[td1_return_estimate-False-False] 22.8192ms 18.1932ms 54.9655 Ops/s 47.8355 Ops/s $\textbf{\color{#35bf28}+14.91\%}$
test_values[vec_td1_return_estimate-False-False] 96.7210ms 77.8761ms 12.8409 Ops/s 12.5038 Ops/s $\color{#35bf28}+2.70\%$
test_values[td_lambda_return_estimate-True-False] 57.5742ms 50.3509ms 19.8606 Ops/s 18.1002 Ops/s $\textbf{\color{#35bf28}+9.73\%}$
test_values[vec_td_lambda_return_estimate-True-False] 84.1076ms 76.8537ms 13.0117 Ops/s 12.7864 Ops/s $\color{#35bf28}+1.76\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 18.0369ms 14.3213ms 69.8258 Ops/s 58.0286 Ops/s $\textbf{\color{#35bf28}+20.33\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 14.1717ms 4.8443ms 206.4288 Ops/s 187.3125 Ops/s $\textbf{\color{#35bf28}+10.21\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 1.8865ms 0.7083ms 1.4118 KOps/s 1.3063 KOps/s $\textbf{\color{#35bf28}+8.08\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 90.3632ms 82.3827ms 12.1385 Ops/s 12.9738 Ops/s $\textbf{\color{#d91a1a}-6.44\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 12.8501ms 6.5748ms 152.0951 Ops/s 157.5116 Ops/s $\color{#d91a1a}-3.44\%$
test_dqn_speed 8.2545ms 2.7820ms 359.4479 Ops/s 373.2766 Ops/s $\color{#d91a1a}-3.70\%$
test_ddpg_speed 12.2741ms 5.2084ms 191.9992 Ops/s 190.7103 Ops/s $\color{#35bf28}+0.68\%$
test_sac_speed 19.4649ms 14.2254ms 70.2967 Ops/s 69.0259 Ops/s $\color{#35bf28}+1.84\%$
test_redq_speed 34.5243ms 24.9359ms 40.1028 Ops/s 38.1402 Ops/s $\textbf{\color{#35bf28}+5.15\%}$
test_redq_deprec_speed 31.4514ms 22.8258ms 43.8100 Ops/s 43.5678 Ops/s $\color{#35bf28}+0.56\%$
test_td3_speed 19.8619ms 16.7810ms 59.5914 Ops/s 56.9357 Ops/s $\color{#35bf28}+4.66\%$
test_cql_speed 64.1297ms 55.4920ms 18.0206 Ops/s 17.4400 Ops/s $\color{#35bf28}+3.33\%$
test_a2c_speed 22.0509ms 12.5400ms 79.7448 Ops/s 82.3971 Ops/s $\color{#d91a1a}-3.22\%$
test_ppo_speed 25.7960ms 13.9521ms 71.6740 Ops/s 73.8101 Ops/s $\color{#d91a1a}-2.89\%$
test_reinforce_speed 17.9629ms 10.5372ms 94.9015 Ops/s 97.3511 Ops/s $\color{#d91a1a}-2.52\%$
test_iql_speed 63.8512ms 51.6292ms 19.3689 Ops/s 18.7804 Ops/s $\color{#35bf28}+3.13\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 9.1071ms 3.6526ms 273.7751 Ops/s 280.1015 Ops/s $\color{#d91a1a}-2.26\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 7.8884ms 3.6433ms 274.4783 Ops/s 245.1169 Ops/s $\textbf{\color{#35bf28}+11.98\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 9.0797ms 3.5137ms 284.6017 Ops/s 243.5430 Ops/s $\textbf{\color{#35bf28}+16.86\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1683ms 3.2402ms 308.6246 Ops/s 269.7571 Ops/s $\textbf{\color{#35bf28}+14.41\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 6.5866ms 3.5264ms 283.5742 Ops/s 253.9327 Ops/s $\textbf{\color{#35bf28}+11.67\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 8.1066ms 3.5815ms 279.2144 Ops/s 253.6085 Ops/s $\textbf{\color{#35bf28}+10.10\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 12.3860ms 3.3208ms 301.1320 Ops/s 254.3502 Ops/s $\textbf{\color{#35bf28}+18.39\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 7.1937ms 3.5817ms 279.1952 Ops/s 250.1204 Ops/s $\textbf{\color{#35bf28}+11.62\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 9.5977ms 3.8996ms 256.4333 Ops/s 257.5036 Ops/s $\color{#d91a1a}-0.42\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.9759ms 3.4698ms 288.1979 Ops/s 266.8848 Ops/s $\textbf{\color{#35bf28}+7.99\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.3873ms 3.5181ms 284.2453 Ops/s 201.4750 Ops/s $\textbf{\color{#35bf28}+41.08\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.5643ms 3.6847ms 271.3929 Ops/s 251.8013 Ops/s $\textbf{\color{#35bf28}+7.78\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.5799ms 3.2338ms 309.2320 Ops/s 272.0876 Ops/s $\textbf{\color{#35bf28}+13.65\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 10.8423ms 3.5828ms 279.1079 Ops/s 259.1478 Ops/s $\textbf{\color{#35bf28}+7.70\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.2999ms 3.6069ms 277.2441 Ops/s 252.6850 Ops/s $\textbf{\color{#35bf28}+9.72\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 12.9538ms 3.4439ms 290.3696 Ops/s 269.3249 Ops/s $\textbf{\color{#35bf28}+7.81\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 9.2473ms 3.6536ms 273.7017 Ops/s 250.3866 Ops/s $\textbf{\color{#35bf28}+9.31\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.2251ms 3.7968ms 263.3828 Ops/s 250.8200 Ops/s $\textbf{\color{#35bf28}+5.01\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3230s 47.3558ms 21.1167 Ops/s 18.8272 Ops/s $\textbf{\color{#35bf28}+12.16\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.2108s 42.3574ms 23.6086 Ops/s 22.5519 Ops/s $\color{#35bf28}+4.69\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.2159s 45.0883ms 22.1787 Ops/s 21.0385 Ops/s $\textbf{\color{#35bf28}+5.42\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2204s 41.6529ms 24.0079 Ops/s 23.5886 Ops/s $\color{#35bf28}+1.78\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.2201s 44.8319ms 22.3055 Ops/s 21.9609 Ops/s $\color{#35bf28}+1.57\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.2331s 45.7672ms 21.8497 Ops/s 22.9568 Ops/s $\color{#d91a1a}-4.82\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2101s 41.7999ms 23.9235 Ops/s 23.8759 Ops/s $\color{#35bf28}+0.20\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.2086s 43.0607ms 23.2230 Ops/s 22.5387 Ops/s $\color{#35bf28}+3.04\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1966s 40.2379ms 24.8522 Ops/s 23.1737 Ops/s $\textbf{\color{#35bf28}+7.24\%}$

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}10$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1147s 0.1142s 8.7570 Ops/s 8.6714 Ops/s $\color{#35bf28}+0.99\%$
test_sync 62.2327ms 60.6179ms 16.4968 Ops/s 16.4065 Ops/s $\color{#35bf28}+0.55\%$
test_async 93.2144ms 58.9142ms 16.9738 Ops/s 16.8122 Ops/s $\color{#35bf28}+0.96\%$
test_simple 0.5849s 0.5229s 1.9126 Ops/s 1.8679 Ops/s $\color{#35bf28}+2.39\%$
test_transformed 1.3307s 1.2777s 0.7827 Ops/s 0.7750 Ops/s $\color{#35bf28}+0.99\%$
test_serial 1.7288s 1.6797s 0.5954 Ops/s 0.5904 Ops/s $\color{#35bf28}+0.84\%$
test_parallel 1.4316s 1.3772s 0.7261 Ops/s 0.6880 Ops/s $\textbf{\color{#35bf28}+5.54\%}$
test_step_mdp_speed[True-True-True-True-True] 0.1811ms 35.0247μs 28.5513 KOps/s 28.5603 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-True-True-True-False] 0.1405ms 20.4163μs 48.9805 KOps/s 49.5220 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-True-True-False-True] 51.2000μs 24.7733μs 40.3661 KOps/s 40.7728 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[True-True-True-False-False] 0.1613ms 13.9324μs 71.7752 KOps/s 72.1537 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[True-True-False-True-True] 0.1529ms 36.5215μs 27.3812 KOps/s 27.3463 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-True-False-True-False] 0.1483ms 21.9624μs 45.5324 KOps/s 45.8176 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-True-False-False-True] 0.1462ms 26.5862μs 37.6136 KOps/s 38.2267 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[True-True-False-False-False] 69.3010μs 15.5830μs 64.1726 KOps/s 64.3742 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[True-False-True-True-True] 63.0000μs 37.8644μs 26.4100 KOps/s 26.4631 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[True-False-True-True-False] 0.2137ms 23.2873μs 42.9418 KOps/s 43.2312 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[True-False-True-False-True] 44.8010μs 25.9314μs 38.5632 KOps/s 38.4857 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[True-False-True-False-False] 42.1000μs 15.3344μs 65.2129 KOps/s 64.6860 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[True-False-False-True-True] 68.8000μs 39.2028μs 25.5084 KOps/s 25.3685 KOps/s $\color{#35bf28}+0.55\%$
test_step_mdp_speed[True-False-False-True-False] 41.0010μs 24.9262μs 40.1184 KOps/s 40.5557 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-False-False-False-True] 80.4000μs 27.5679μs 36.2741 KOps/s 36.3738 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[True-False-False-False-False] 76.0000μs 17.1971μs 58.1495 KOps/s 59.6583 KOps/s $\color{#d91a1a}-2.53\%$
test_step_mdp_speed[False-True-True-True-True] 88.8010μs 37.9854μs 26.3259 KOps/s 26.4150 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[False-True-True-True-False] 47.3000μs 23.3092μs 42.9015 KOps/s 42.9072 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[False-True-True-False-True] 63.9010μs 30.1656μs 33.1504 KOps/s 32.4241 KOps/s $\color{#35bf28}+2.24\%$
test_step_mdp_speed[False-True-True-False-False] 40.9000μs 17.1663μs 58.2538 KOps/s 57.7316 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[False-True-False-True-True] 80.1010μs 39.4470μs 25.3505 KOps/s 25.4269 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-True-False-True-False] 48.8010μs 24.7936μs 40.3330 KOps/s 40.9536 KOps/s $\color{#d91a1a}-1.52\%$
test_step_mdp_speed[False-True-False-False-True] 54.7010μs 31.5344μs 31.7114 KOps/s 30.9907 KOps/s $\color{#35bf28}+2.33\%$
test_step_mdp_speed[False-True-False-False-False] 41.1010μs 18.5736μs 53.8398 KOps/s 53.4919 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[False-False-True-True-True] 0.1676ms 40.9154μs 24.4407 KOps/s 24.6418 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[False-False-True-True-False] 77.6010μs 26.0450μs 38.3951 KOps/s 38.9813 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[False-False-True-False-True] 0.2724ms 34.6067μs 28.8961 KOps/s 31.5259 KOps/s $\textbf{\color{#d91a1a}-8.34\%}$
test_step_mdp_speed[False-False-True-False-False] 82.6010μs 18.9530μs 52.7620 KOps/s 54.3959 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[False-False-False-True-True] 0.1669ms 42.1794μs 23.7082 KOps/s 23.9251 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[False-False-False-True-False] 0.5764ms 27.7680μs 36.0127 KOps/s 36.6120 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[False-False-False-False-True] 73.3000μs 32.8799μs 30.4137 KOps/s 30.1980 KOps/s $\color{#35bf28}+0.71\%$
test_step_mdp_speed[False-False-False-False-False] 47.8000μs 20.0420μs 49.8953 KOps/s 50.0700 KOps/s $\color{#d91a1a}-0.35\%$
test_values[generalized_advantage_estimate-True-True] 19.1919ms 14.7722ms 67.6948 Ops/s 70.5709 Ops/s $\color{#d91a1a}-4.08\%$
test_values[vec_generalized_advantage_estimate-True-True] 57.6383ms 50.9712ms 19.6189 Ops/s 18.9822 Ops/s $\color{#35bf28}+3.35\%$
test_values[td0_return_estimate-False-False] 0.3091ms 0.2107ms 4.7455 KOps/s 3.3251 KOps/s $\textbf{\color{#35bf28}+42.72\%}$
test_values[td1_return_estimate-False-False] 14.0679ms 13.8617ms 72.1412 Ops/s 72.1157 Ops/s $\color{#35bf28}+0.04\%$
test_values[vec_td1_return_estimate-False-False] 52.1547ms 50.8586ms 19.6623 Ops/s 18.7523 Ops/s $\color{#35bf28}+4.85\%$
test_values[td_lambda_return_estimate-True-False] 32.8850ms 32.5985ms 30.6763 Ops/s 30.4975 Ops/s $\color{#35bf28}+0.59\%$
test_values[vec_td_lambda_return_estimate-True-False] 0.1142s 52.8098ms 18.9359 Ops/s 19.2230 Ops/s $\color{#d91a1a}-1.49\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 13.9987ms 12.3793ms 80.7801 Ops/s 80.7112 Ops/s $\color{#35bf28}+0.09\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.9052ms 2.3926ms 417.9526 Ops/s 405.1144 Ops/s $\color{#35bf28}+3.17\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 2.4290ms 0.4157ms 2.4055 KOps/s 2.4413 KOps/s $\color{#d91a1a}-1.47\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 55.3275ms 53.0408ms 18.8534 Ops/s 18.5949 Ops/s $\color{#35bf28}+1.39\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 14.4771ms 3.8523ms 259.5868 Ops/s 251.6544 Ops/s $\color{#35bf28}+3.15\%$
test_dqn_speed 2.2685ms 1.5123ms 661.2591 Ops/s 663.0738 Ops/s $\color{#d91a1a}-0.27\%$
test_ddpg_speed 8.9869ms 2.3779ms 420.5382 Ops/s 421.8568 Ops/s $\color{#d91a1a}-0.31\%$
test_sac_speed 8.9550ms 8.0015ms 124.9764 Ops/s 124.2404 Ops/s $\color{#35bf28}+0.59\%$
test_redq_speed 15.1436ms 13.0773ms 76.4684 Ops/s 75.1642 Ops/s $\color{#35bf28}+1.74\%$
test_redq_deprec_speed 13.4150ms 12.0028ms 83.3136 Ops/s 79.5961 Ops/s $\color{#35bf28}+4.67\%$
test_td3_speed 16.7317ms 9.4868ms 105.4096 Ops/s 103.7536 Ops/s $\color{#35bf28}+1.60\%$
test_cql_speed 38.1490ms 34.2021ms 29.2380 Ops/s 34.6094 Ops/s $\textbf{\color{#d91a1a}-15.52\%}$
test_a2c_speed 8.6281ms 5.7833ms 172.9108 Ops/s 174.5529 Ops/s $\color{#d91a1a}-0.94\%$
test_ppo_speed 8.3437ms 6.0301ms 165.8342 Ops/s 157.4765 Ops/s $\textbf{\color{#35bf28}+5.31\%}$
test_reinforce_speed 5.5924ms 4.2783ms 233.7351 Ops/s 223.8447 Ops/s $\color{#35bf28}+4.42\%$
test_iql_speed 24.3064ms 21.4599ms 46.5985 Ops/s 43.6605 Ops/s $\textbf{\color{#35bf28}+6.73\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1337ms 2.3483ms 425.8406 Ops/s 405.4353 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 5.0571ms 2.5040ms 399.3685 Ops/s 390.1610 Ops/s $\color{#35bf28}+2.36\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1486s 2.8214ms 354.4383 Ops/s 386.9973 Ops/s $\textbf{\color{#d91a1a}-8.41\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3133ms 2.3373ms 427.8353 Ops/s 404.9827 Ops/s $\textbf{\color{#35bf28}+5.64\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.2018ms 2.4812ms 403.0282 Ops/s 389.5575 Ops/s $\color{#35bf28}+3.46\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.8438ms 2.4742ms 404.1660 Ops/s 387.0075 Ops/s $\color{#35bf28}+4.43\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2432ms 2.3116ms 432.5997 Ops/s 403.9016 Ops/s $\textbf{\color{#35bf28}+7.11\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.8129ms 2.5174ms 397.2284 Ops/s 385.5729 Ops/s $\color{#35bf28}+3.02\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 5.3037ms 2.4872ms 402.0612 Ops/s 383.4228 Ops/s $\color{#35bf28}+4.86\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9506ms 2.4030ms 416.1416 Ops/s 404.7019 Ops/s $\color{#35bf28}+2.83\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.6094ms 2.5236ms 396.2567 Ops/s 391.7496 Ops/s $\color{#35bf28}+1.15\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.0229ms 2.5280ms 395.5698 Ops/s 383.5047 Ops/s $\color{#35bf28}+3.15\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0479ms 2.4149ms 414.0939 Ops/s 401.0443 Ops/s $\color{#35bf28}+3.25\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.0061ms 2.4917ms 401.3295 Ops/s 386.2954 Ops/s $\color{#35bf28}+3.89\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.0158ms 2.4788ms 403.4179 Ops/s 387.0470 Ops/s $\color{#35bf28}+4.23\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0371ms 2.3508ms 425.3808 Ops/s 400.7015 Ops/s $\textbf{\color{#35bf28}+6.16\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 5.7246ms 2.4848ms 402.4400 Ops/s 346.5546 Ops/s $\textbf{\color{#35bf28}+16.13\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.4253ms 2.5052ms 399.1767 Ops/s 346.4153 Ops/s $\textbf{\color{#35bf28}+15.23\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2075s 27.9658ms 35.7579 Ops/s 36.1267 Ops/s $\color{#d91a1a}-1.02\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1241s 25.9398ms 38.5508 Ops/s 37.1590 Ops/s $\color{#35bf28}+3.75\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1221s 23.8443ms 41.9388 Ops/s 41.1737 Ops/s $\color{#35bf28}+1.86\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1235s 25.9985ms 38.4638 Ops/s 37.6265 Ops/s $\color{#35bf28}+2.23\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1174s 23.5730ms 42.4215 Ops/s 40.4027 Ops/s $\color{#35bf28}+5.00\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1212s 25.7875ms 38.7785 Ops/s 37.4491 Ops/s $\color{#35bf28}+3.55\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1228s 24.0170ms 41.6372 Ops/s 41.0678 Ops/s $\color{#35bf28}+1.39\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1243s 26.1514ms 38.2388 Ops/s 37.8648 Ops/s $\color{#35bf28}+0.99\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1217s 23.7943ms 42.0270 Ops/s 40.5143 Ops/s $\color{#35bf28}+3.73\%$

@vmoens vmoens linked an issue Jul 11, 2023 that may be closed by this pull request
3 tasks
@vmoens vmoens merged commit 5a3f9e0 into main Jul 11, 2023
@vmoens vmoens deleted the fix_tuto branch July 11, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Recurrent DQN example is broken
2 participants