Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Remove loss device #1395

Merged
merged 2 commits into from
Jul 26, 2023
Merged

[Fix] Remove loss device #1395

merged 2 commits into from
Jul 26, 2023

Conversation

matteobettini
Copy link
Contributor

closes #1389

@matteobettini
amend
208c600 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2023
@matteobettini matteobettini marked this pull request as ready for review July 19, 2023 07:27
vmoens
vmoens approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Should we remove loss.device in a separate PR?

@matteobettini
amend
b69bdef 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini changed the title [Fix] DQN device [Fix] Remove loss device Jul 20, 2023
@matteobettini
Copy link
Contributor Author

i gave it a shot

vmoens
vmoens approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@vmoens vmoens merged commit c06ed70 into pytorch:main Jul 26, 2023
41 of 46 checks passed
@vmoens vmoens added the bc breaking backward compatibility breaking change label Jul 26, 2023
@matteobettini matteobettini deleted the device_dqn branch July 27, 2023 07:56
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@matteobettini @vmoens
[Refactor] Remove loss device (pytorch#1395)
a16492b 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Device check in DQN always takes first branch
3 participants
@matteobettini @vmoens @facebook-github-bot