Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Pickable buffer #1410

Merged
merged 6 commits into from
Jul 26, 2023
Merged

[BugFix] Pickable buffer #1410

merged 6 commits into from
Jul 26, 2023

Conversation

albertbou92
Copy link
Contributor

@albertbou92 albertbou92 commented Jul 24, 2023

Description

This PR makes the ReplayBuffer pickable. Also a pickable test for the replay buffers.

Tries to solve the following issue: #1408

Motivation and Context

It is convenient to have ReplayBuffer and other classes pickable for features like distributed training, were sometimes need to be serialised.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2023
@albertbou92 albertbou92 marked this pull request as draft July 24, 2023 14:44
@albertbou92
Copy link
Contributor Author

albertbou92 commented Jul 24, 2023

Should the test be more strict? we can not check that each original dict object is equal (==) to its deserialised version because most classes don't have the eq() method overwritten.

@vmoens vmoens changed the title Pickable buffer [BugFix] Pickable buffer Jul 24, 2023
@vmoens
Copy link
Contributor

vmoens commented Jul 24, 2023

Nope that unit test covers what we want to fix

@albertbou92 albertbou92 marked this pull request as ready for review July 24, 2023 20:08
@vmoens vmoens added the bug Something isn't working label Jul 26, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 3f4e9aa into pytorch:main Jul 26, 2023
37 of 46 checks passed
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@albertbou92 albertbou92 deleted the pickable_buffer branch January 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants