Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versioning] Python 3.11 #1433

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[Versioning] Python 3.11 #1433

merged 1 commit into from
Aug 1, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 31, 2023

Fixes #1432 #1423

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2023
@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}22$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.2066s 0.2050s 4.8774 Ops/s 4.7962 Ops/s $\color{#35bf28}+1.69\%$
test_sync 0.1112s 0.1078s 9.2731 Ops/s 8.8946 Ops/s $\color{#35bf28}+4.26\%$
test_async 0.2832s 0.1084s 9.2253 Ops/s 9.2898 Ops/s $\color{#d91a1a}-0.69\%$
test_simple 1.0646s 0.9646s 1.0367 Ops/s 1.0678 Ops/s $\color{#d91a1a}-2.91\%$
test_transformed 2.4742s 2.3960s 0.4174 Ops/s 0.4147 Ops/s $\color{#35bf28}+0.65\%$
test_serial 3.0514s 2.9622s 0.3376 Ops/s 0.3392 Ops/s $\color{#d91a1a}-0.48\%$
test_parallel 2.5510s 2.4446s 0.4091 Ops/s 0.4139 Ops/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[True-True-True-True-True] 2.0183ms 57.4487μs 17.4068 KOps/s 17.1103 KOps/s $\color{#35bf28}+1.73\%$
test_step_mdp_speed[True-True-True-True-False] 12.2363ms 33.7222μs 29.6541 KOps/s 29.8992 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[True-True-True-False-True] 0.5301ms 41.2313μs 24.2534 KOps/s 23.6987 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-True-True-False-False] 0.4090ms 23.2591μs 42.9939 KOps/s 41.7030 KOps/s $\color{#35bf28}+3.10\%$
test_step_mdp_speed[True-True-False-True-True] 6.2299ms 59.8351μs 16.7126 KOps/s 16.4596 KOps/s $\color{#35bf28}+1.54\%$
test_step_mdp_speed[True-True-False-True-False] 1.5906ms 35.0917μs 28.4967 KOps/s 27.0003 KOps/s $\textbf{\color{#35bf28}+5.54\%}$
test_step_mdp_speed[True-True-False-False-True] 0.5390ms 43.9089μs 22.7744 KOps/s 22.0772 KOps/s $\color{#35bf28}+3.16\%$
test_step_mdp_speed[True-True-False-False-False] 6.5158ms 25.9415μs 38.5483 KOps/s 36.6360 KOps/s $\textbf{\color{#35bf28}+5.22\%}$
test_step_mdp_speed[True-False-True-True-True] 1.2304ms 62.9429μs 15.8874 KOps/s 15.0835 KOps/s $\textbf{\color{#35bf28}+5.33\%}$
test_step_mdp_speed[True-False-True-True-False] 10.2512ms 38.3079μs 26.1042 KOps/s 24.9897 KOps/s $\color{#35bf28}+4.46\%$
test_step_mdp_speed[True-False-True-False-True] 7.3121ms 44.9763μs 22.2339 KOps/s 22.1570 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-False-True-False-False] 1.8908ms 26.2535μs 38.0901 KOps/s 36.0023 KOps/s $\textbf{\color{#35bf28}+5.80\%}$
test_step_mdp_speed[True-False-False-True-True] 0.5611ms 65.1825μs 15.3415 KOps/s 15.1146 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[True-False-False-True-False] 1.1848ms 40.1428μs 24.9111 KOps/s 24.1067 KOps/s $\color{#35bf28}+3.34\%$
test_step_mdp_speed[True-False-False-False-True] 0.9657ms 47.1805μs 21.1952 KOps/s 21.0734 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[True-False-False-False-False] 1.9578ms 28.9228μs 34.5748 KOps/s 35.2121 KOps/s $\color{#d91a1a}-1.81\%$
test_step_mdp_speed[False-True-True-True-True] 5.3460ms 63.8379μs 15.6647 KOps/s 15.6362 KOps/s $\color{#35bf28}+0.18\%$
test_step_mdp_speed[False-True-True-True-False] 7.6503ms 39.2472μs 25.4795 KOps/s 25.5555 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-True-True-False-True] 7.0678ms 52.7710μs 18.9498 KOps/s 18.7485 KOps/s $\color{#35bf28}+1.07\%$
test_step_mdp_speed[False-True-True-False-False] 4.5528ms 29.6575μs 33.7183 KOps/s 32.6321 KOps/s $\color{#35bf28}+3.33\%$
test_step_mdp_speed[False-True-False-True-True] 4.5182ms 66.0057μs 15.1502 KOps/s 14.7261 KOps/s $\color{#35bf28}+2.88\%$
test_step_mdp_speed[False-True-False-True-False] 2.3611ms 39.8993μs 25.0631 KOps/s 24.0782 KOps/s $\color{#35bf28}+4.09\%$
test_step_mdp_speed[False-True-False-False-True] 4.1727ms 53.6348μs 18.6446 KOps/s 18.3505 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[False-True-False-False-False] 6.7859ms 31.9174μs 31.3309 KOps/s 29.3341 KOps/s $\textbf{\color{#35bf28}+6.81\%}$
test_step_mdp_speed[False-False-True-True-True] 1.3741ms 66.6880μs 14.9952 KOps/s 14.6469 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-False-True-True-False] 0.2684ms 41.1595μs 24.2957 KOps/s 22.4307 KOps/s $\textbf{\color{#35bf28}+8.31\%}$
test_step_mdp_speed[False-False-True-False-True] 6.2262ms 53.8025μs 18.5865 KOps/s 18.7702 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[False-False-True-False-False] 10.9576ms 31.4203μs 31.8265 KOps/s 31.2066 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[False-False-False-True-True] 2.0078ms 68.4254μs 14.6145 KOps/s 14.3058 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[False-False-False-True-False] 0.7164ms 43.4906μs 22.9935 KOps/s 22.5168 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[False-False-False-False-True] 1.5114ms 54.2670μs 18.4274 KOps/s 17.8906 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[False-False-False-False-False] 3.9430ms 33.9137μs 29.4866 KOps/s 29.0570 KOps/s $\color{#35bf28}+1.48\%$
test_values[generalized_advantage_estimate-True-True] 22.3178ms 19.4814ms 51.3310 Ops/s 47.5874 Ops/s $\textbf{\color{#35bf28}+7.87\%}$
test_values[vec_generalized_advantage_estimate-True-True] 75.7647ms 68.2365ms 14.6549 Ops/s 13.1744 Ops/s $\textbf{\color{#35bf28}+11.24\%}$
test_values[td0_return_estimate-False-False] 2.4804ms 0.4514ms 2.2153 KOps/s 2.8295 KOps/s $\textbf{\color{#d91a1a}-21.71\%}$
test_values[td1_return_estimate-False-False] 28.3031ms 18.8019ms 53.1862 Ops/s 50.1509 Ops/s $\textbf{\color{#35bf28}+6.05\%}$
test_values[vec_td1_return_estimate-False-False] 93.8562ms 69.3281ms 14.4242 Ops/s 13.1558 Ops/s $\textbf{\color{#35bf28}+9.64\%}$
test_values[td_lambda_return_estimate-True-False] 56.4724ms 48.6594ms 20.5510 Ops/s 18.2433 Ops/s $\textbf{\color{#35bf28}+12.65\%}$
test_values[vec_td_lambda_return_estimate-True-False] 85.9768ms 71.2390ms 14.0373 Ops/s 13.4019 Ops/s $\color{#35bf28}+4.74\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 27.8167ms 15.2037ms 65.7734 Ops/s 60.3919 Ops/s $\textbf{\color{#35bf28}+8.91\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 13.9930ms 4.7990ms 208.3758 Ops/s 217.1456 Ops/s $\color{#d91a1a}-4.04\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 7.3251ms 0.7264ms 1.3767 KOps/s 1.3180 KOps/s $\color{#35bf28}+4.45\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 71.2113ms 66.3730ms 15.0664 Ops/s 12.2952 Ops/s $\textbf{\color{#35bf28}+22.54\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 11.0344ms 6.2675ms 159.5529 Ops/s 159.5387 Ops/s $+0.01\%$
test_dqn_speed 6.5589ms 2.3444ms 426.5521 Ops/s 403.3304 Ops/s $\textbf{\color{#35bf28}+5.76\%}$
test_ddpg_speed 19.9403ms 4.7728ms 209.5203 Ops/s 203.3232 Ops/s $\color{#35bf28}+3.05\%$
test_sac_speed 20.2395ms 13.6492ms 73.2644 Ops/s 70.9916 Ops/s $\color{#35bf28}+3.20\%$
test_redq_speed 37.8612ms 24.3656ms 41.0414 Ops/s 36.5362 Ops/s $\textbf{\color{#35bf28}+12.33\%}$
test_redq_deprec_speed 28.6962ms 22.5736ms 44.2995 Ops/s 42.1791 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_td3_speed 19.3035ms 16.9865ms 58.8703 Ops/s 58.8766 Ops/s $\color{#d91a1a}-0.01\%$
test_cql_speed 59.3828ms 52.4360ms 19.0709 Ops/s 18.3920 Ops/s $\color{#35bf28}+3.69\%$
test_a2c_speed 25.0256ms 12.0496ms 82.9900 Ops/s 88.7771 Ops/s $\textbf{\color{#d91a1a}-6.52\%}$
test_ppo_speed 0.1062s 13.3300ms 75.0186 Ops/s 79.7679 Ops/s $\textbf{\color{#d91a1a}-5.95\%}$
test_reinforce_speed 17.2361ms 9.8262ms 101.7686 Ops/s 103.3018 Ops/s $\color{#d91a1a}-1.48\%$
test_iql_speed 54.7830ms 46.5748ms 21.4708 Ops/s 20.8718 Ops/s $\color{#35bf28}+2.87\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.5812ms 3.6422ms 274.5619 Ops/s 251.9881 Ops/s $\textbf{\color{#35bf28}+8.96\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 15.2167ms 4.0142ms 249.1135 Ops/s 207.3747 Ops/s $\textbf{\color{#35bf28}+20.13\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 7.6445ms 3.8601ms 259.0600 Ops/s 252.0698 Ops/s $\color{#35bf28}+2.77\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.2414ms 3.7868ms 264.0777 Ops/s 264.1665 Ops/s $\color{#d91a1a}-0.03\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 7.5175ms 4.0222ms 248.6183 Ops/s 250.6624 Ops/s $\color{#d91a1a}-0.82\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.2570ms 3.9608ms 252.4743 Ops/s 254.0462 Ops/s $\color{#d91a1a}-0.62\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 12.9696ms 3.7733ms 265.0185 Ops/s 264.4084 Ops/s $\color{#35bf28}+0.23\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 8.9721ms 3.9845ms 250.9744 Ops/s 247.0082 Ops/s $\color{#35bf28}+1.61\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 13.9236ms 3.9812ms 251.1822 Ops/s 247.6272 Ops/s $\color{#35bf28}+1.44\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.2202ms 3.7602ms 265.9417 Ops/s 254.7599 Ops/s $\color{#35bf28}+4.39\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 12.8011ms 4.0156ms 249.0266 Ops/s 244.9682 Ops/s $\color{#35bf28}+1.66\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 14.6256ms 4.0517ms 246.8099 Ops/s 248.8367 Ops/s $\color{#d91a1a}-0.81\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 15.2221ms 3.8186ms 261.8765 Ops/s 257.4647 Ops/s $\color{#35bf28}+1.71\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 11.7412ms 3.9798ms 251.2710 Ops/s 241.2363 Ops/s $\color{#35bf28}+4.16\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 7.4193ms 4.0629ms 246.1310 Ops/s 241.2669 Ops/s $\color{#35bf28}+2.02\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3955ms 3.7779ms 264.7006 Ops/s 261.7312 Ops/s $\color{#35bf28}+1.13\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 11.1341ms 3.8707ms 258.3537 Ops/s 250.3568 Ops/s $\color{#35bf28}+3.19\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.0295ms 3.8518ms 259.6214 Ops/s 251.5183 Ops/s $\color{#35bf28}+3.22\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3606s 45.3257ms 22.0626 Ops/s 23.1997 Ops/s $\color{#d91a1a}-4.90\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.2118s 39.1959ms 25.5129 Ops/s 23.1766 Ops/s $\textbf{\color{#35bf28}+10.08\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.2062s 42.9507ms 23.2825 Ops/s 24.3255 Ops/s $\color{#d91a1a}-4.29\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2177s 39.9657ms 25.0215 Ops/s 23.2165 Ops/s $\textbf{\color{#35bf28}+7.77\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.2049s 42.7583ms 23.3873 Ops/s 24.5696 Ops/s $\color{#d91a1a}-4.81\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.2157s 43.5358ms 22.9696 Ops/s 23.5784 Ops/s $\color{#d91a1a}-2.58\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2074s 35.7429ms 27.9776 Ops/s 23.8696 Ops/s $\textbf{\color{#35bf28}+17.21\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.2012s 42.0917ms 23.7577 Ops/s 25.3157 Ops/s $\textbf{\color{#d91a1a}-6.15\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.2065s 39.0390ms 25.6154 Ops/s 23.3054 Ops/s $\textbf{\color{#35bf28}+9.91\%}$

Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens marked this pull request as ready for review August 1, 2023 09:20
@vmoens vmoens added the versioning Versioning change (version number etc) label Aug 1, 2023
@vmoens vmoens merged commit 0bd26f4 into main Aug 1, 2023
44 of 54 checks passed
@vmoens vmoens deleted the python311 branch August 1, 2023 12:29
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. versioning Versioning change (version number etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python version 3.11
3 participants