Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] CompositeSpec.unsqueeze #1464

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[BugFix] CompositeSpec.unsqueeze #1464

merged 1 commit into from
Aug 18, 2023

Conversation

btx0424
Copy link
Contributor

@btx0424 btx0424 commented Aug 17, 2023

Description

Make CompositeSpec.unsqueeze match the expected behavior.

from torchrl.data import CompositeSpec, UnboundedContinuousTensorSpec

spec = CompositeSpec({
    "a": UnboundedContinuousTensorSpec((10, 16))
}, shape=[10])
print(spec.unsqueeze(-1))

should give

CompositeSpec(
    a: UnboundedContinuousTensorSpec(
        shape=torch.Size([10, 1, 16]),
        space=None,
        device=cpu,
        dtype=torch.float32,
        domain=continuous), device=cpu, shape=torch.Size([10, 1]))
  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens changed the title CompositeSpec.unsqueeze [BugFix] CompositeSpec.unsqueeze Aug 18, 2023
@vmoens vmoens added the bug Something isn't working label Aug 18, 2023
@vmoens vmoens merged commit bd316e9 into pytorch:main Aug 18, 2023
47 of 54 checks passed
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants