Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix action mask test #1492

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[BugFix] Fix action mask test #1492

merged 1 commit into from
Sep 5, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 5, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2023
@vmoens vmoens added the bug Something isn't working label Sep 5, 2023
@vmoens vmoens marked this pull request as ready for review September 5, 2023 16:53
@vmoens vmoens merged commit 061a261 into main Sep 5, 2023
20 of 43 checks passed
@vmoens vmoens deleted the fix_actionmask branch September 5, 2023 16:53
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1589s 0.1570s 6.3696 Ops/s 6.4905 Ops/s $\color{#d91a1a}-1.86\%$
test_sync 0.1749s 92.5966ms 10.7995 Ops/s 10.8308 Ops/s $\color{#d91a1a}-0.29\%$
test_async 0.2133s 84.0885ms 11.8922 Ops/s 11.7661 Ops/s $\color{#35bf28}+1.07\%$
test_simple 0.7849s 0.7073s 1.4139 Ops/s 1.4210 Ops/s $\color{#d91a1a}-0.50\%$
test_transformed 1.9544s 1.8923s 0.5284 Ops/s 0.5404 Ops/s $\color{#d91a1a}-2.21\%$
test_serial 2.0419s 1.9702s 0.5076 Ops/s 0.5005 Ops/s $\color{#35bf28}+1.41\%$
test_parallel 1.7644s 1.6676s 0.5997 Ops/s 0.5933 Ops/s $\color{#35bf28}+1.07\%$
test_step_mdp_speed[True-True-True-True-True] 0.2626ms 50.9329μs 19.6337 KOps/s 19.6336 KOps/s $+0.00\%$
test_step_mdp_speed[True-True-True-True-False] 61.9040μs 28.9732μs 34.5147 KOps/s 35.1823 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[True-True-True-False-True] 75.1050μs 34.9533μs 28.6096 KOps/s 28.6677 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[True-True-True-False-False] 62.5040μs 19.1879μs 52.1161 KOps/s 51.3898 KOps/s $\color{#35bf28}+1.41\%$
test_step_mdp_speed[True-True-False-True-True] 96.9070μs 51.7460μs 19.3252 KOps/s 19.1715 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-True-False-True-False] 65.2050μs 29.7377μs 33.6274 KOps/s 33.0220 KOps/s $\color{#35bf28}+1.83\%$
test_step_mdp_speed[True-True-False-False-True] 74.5050μs 36.6752μs 27.2664 KOps/s 27.3168 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-True-False-False-False] 55.5040μs 21.4990μs 46.5137 KOps/s 45.5055 KOps/s $\color{#35bf28}+2.22\%$
test_step_mdp_speed[True-False-True-True-True] 95.5070μs 55.3114μs 18.0795 KOps/s 18.1852 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[True-False-True-True-False] 1.0722ms 34.1425μs 29.2890 KOps/s 30.3419 KOps/s $\color{#d91a1a}-3.47\%$
test_step_mdp_speed[True-False-True-False-True] 73.7050μs 37.5620μs 26.6227 KOps/s 26.9728 KOps/s $\color{#d91a1a}-1.30\%$
test_step_mdp_speed[True-False-True-False-False] 91.3060μs 22.0005μs 45.4536 KOps/s 46.2274 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-False-True-True] 98.7070μs 56.2284μs 17.7846 KOps/s 17.9955 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-False-False-True-False] 76.7050μs 34.4979μs 28.9872 KOps/s 28.4710 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[True-False-False-False-True] 79.8050μs 38.9921μs 25.6462 KOps/s 25.3906 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[True-False-False-False-False] 55.4040μs 23.8825μs 41.8717 KOps/s 42.0975 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-True-True-True-True] 98.4070μs 54.3060μs 18.4142 KOps/s 18.4625 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[False-True-True-True-False] 67.2040μs 32.4936μs 30.7753 KOps/s 30.5562 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-True-True-False-True] 90.7070μs 42.0754μs 23.7669 KOps/s 23.7686 KOps/s $-0.01\%$
test_step_mdp_speed[False-True-True-False-False] 3.2470ms 23.6707μs 42.2464 KOps/s 40.4516 KOps/s $\color{#35bf28}+4.44\%$
test_step_mdp_speed[False-True-False-True-True] 0.1190ms 56.1014μs 17.8249 KOps/s 17.7970 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[False-True-False-True-False] 76.4050μs 34.7399μs 28.7853 KOps/s 28.8482 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-True-False-False-True] 0.1098ms 43.8575μs 22.8011 KOps/s 22.8960 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-True-False-False-False] 95.7070μs 26.2468μs 38.0999 KOps/s 38.9696 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[False-False-True-True-True] 0.1132ms 59.4713μs 16.8148 KOps/s 17.0435 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[False-False-True-True-False] 82.8060μs 38.3562μs 26.0714 KOps/s 26.7911 KOps/s $\color{#d91a1a}-2.69\%$
test_step_mdp_speed[False-False-True-False-True] 81.3060μs 45.1961μs 22.1258 KOps/s 22.8468 KOps/s $\color{#d91a1a}-3.16\%$
test_step_mdp_speed[False-False-True-False-False] 83.5060μs 27.0496μs 36.9692 KOps/s 38.5839 KOps/s $\color{#d91a1a}-4.19\%$
test_step_mdp_speed[False-False-False-True-True] 0.1102ms 60.8825μs 16.4251 KOps/s 16.8824 KOps/s $\color{#d91a1a}-2.71\%$
test_step_mdp_speed[False-False-False-True-False] 0.1031ms 40.2938μs 24.8177 KOps/s 26.1677 KOps/s $\textbf{\color{#d91a1a}-5.16\%}$
test_step_mdp_speed[False-False-False-False-True] 0.1048ms 45.7330μs 21.8661 KOps/s 21.9367 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[False-False-False-False-False] 70.8050μs 28.7614μs 34.7688 KOps/s 36.0750 KOps/s $\color{#d91a1a}-3.62\%$
test_values[generalized_advantage_estimate-True-True] 16.5225ms 15.5747ms 64.2066 Ops/s 62.9122 Ops/s $\color{#35bf28}+2.06\%$
test_values[vec_generalized_advantage_estimate-True-True] 54.4862ms 48.8822ms 20.4574 Ops/s 20.5575 Ops/s $\color{#d91a1a}-0.49\%$
test_values[td0_return_estimate-False-False] 0.4948ms 0.2231ms 4.4827 KOps/s 4.2737 KOps/s $\color{#35bf28}+4.89\%$
test_values[td1_return_estimate-False-False] 16.0207ms 15.0952ms 66.2462 Ops/s 68.4704 Ops/s $\color{#d91a1a}-3.25\%$
test_values[vec_td1_return_estimate-False-False] 55.3827ms 48.2165ms 20.7398 Ops/s 21.1763 Ops/s $\color{#d91a1a}-2.06\%$
test_values[td_lambda_return_estimate-True-False] 37.7217ms 36.7151ms 27.2368 Ops/s 27.7779 Ops/s $\color{#d91a1a}-1.95\%$
test_values[vec_td_lambda_return_estimate-True-False] 57.1244ms 48.8201ms 20.4834 Ops/s 20.8200 Ops/s $\color{#d91a1a}-1.62\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 14.2250ms 13.7114ms 72.9319 Ops/s 73.6542 Ops/s $\color{#d91a1a}-0.98\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 4.2566ms 3.9376ms 253.9589 Ops/s 255.3315 Ops/s $\color{#d91a1a}-0.54\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 6.3943ms 0.5791ms 1.7268 KOps/s 1.7337 KOps/s $\color{#d91a1a}-0.40\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 68.2000ms 62.9393ms 15.8883 Ops/s 15.2821 Ops/s $\color{#35bf28}+3.97\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 9.8791ms 3.3968ms 294.3916 Ops/s 296.2590 Ops/s $\color{#d91a1a}-0.63\%$
test_dqn_speed 9.4570ms 2.1535ms 464.3614 Ops/s 462.6123 Ops/s $\color{#35bf28}+0.38\%$
test_ddpg_speed 9.1108ms 3.1572ms 316.7382 Ops/s 311.5881 Ops/s $\color{#35bf28}+1.65\%$
test_sac_speed 15.7005ms 9.3652ms 106.7784 Ops/s 106.6572 Ops/s $\color{#35bf28}+0.11\%$
test_redq_speed 24.6090ms 18.7766ms 53.2578 Ops/s 54.3230 Ops/s $\color{#d91a1a}-1.96\%$
test_redq_deprec_speed 20.3651ms 15.1935ms 65.8176 Ops/s 66.9250 Ops/s $\color{#d91a1a}-1.65\%$
test_td3_speed 13.0554ms 11.7104ms 85.3942 Ops/s 84.8686 Ops/s $\color{#35bf28}+0.62\%$
test_cql_speed 47.3006ms 43.2652ms 23.1133 Ops/s 32.5091 Ops/s $\textbf{\color{#d91a1a}-28.90\%}$
test_a2c_speed 12.0054ms 6.2112ms 160.9990 Ops/s 163.2534 Ops/s $\color{#d91a1a}-1.38\%$
test_ppo_speed 16.6400ms 6.6283ms 150.8680 Ops/s 147.7065 Ops/s $\color{#35bf28}+2.14\%$
test_reinforce_speed 13.0442ms 4.8008ms 208.2982 Ops/s 200.4267 Ops/s $\color{#35bf28}+3.93\%$
test_iql_speed 35.7845ms 25.1506ms 39.7606 Ops/s 39.7911 Ops/s $\color{#d91a1a}-0.08\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6954ms 3.1003ms 322.5527 Ops/s 318.6655 Ops/s $\color{#35bf28}+1.22\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1698s 3.8395ms 260.4522 Ops/s 312.1960 Ops/s $\textbf{\color{#d91a1a}-16.57\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 6.7838ms 3.3401ms 299.3945 Ops/s 312.0107 Ops/s $\color{#d91a1a}-4.04\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 0.2566s 3.9371ms 253.9958 Ops/s 315.7088 Ops/s $\textbf{\color{#d91a1a}-19.55\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 6.1901ms 3.4085ms 293.3833 Ops/s 303.1989 Ops/s $\color{#d91a1a}-3.24\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.1951ms 3.4019ms 293.9510 Ops/s 307.6637 Ops/s $\color{#d91a1a}-4.46\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3155ms 3.0429ms 328.6358 Ops/s 325.9688 Ops/s $\color{#35bf28}+0.82\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 5.6333ms 3.2285ms 309.7381 Ops/s 302.8097 Ops/s $\color{#35bf28}+2.29\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.5284ms 3.3035ms 302.7068 Ops/s 301.2465 Ops/s $\color{#35bf28}+0.48\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.1023ms 3.0282ms 330.2297 Ops/s 322.5101 Ops/s $\color{#35bf28}+2.39\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.0080ms 3.2757ms 305.2805 Ops/s 304.1205 Ops/s $\color{#35bf28}+0.38\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.3524ms 3.2855ms 304.3682 Ops/s 305.1311 Ops/s $\color{#d91a1a}-0.25\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8279ms 3.0275ms 330.3064 Ops/s 256.5031 Ops/s $\textbf{\color{#35bf28}+28.77\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.9639ms 3.2612ms 306.6361 Ops/s 304.1535 Ops/s $\color{#35bf28}+0.82\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.9084ms 3.3263ms 300.6378 Ops/s 302.1445 Ops/s $\color{#d91a1a}-0.50\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.1160ms 3.1123ms 321.3077 Ops/s 313.7147 Ops/s $\color{#35bf28}+2.42\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 5.7295ms 3.2111ms 311.4191 Ops/s 300.8293 Ops/s $\color{#35bf28}+3.52\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.0051ms 3.3050ms 302.5716 Ops/s 294.5610 Ops/s $\color{#35bf28}+2.72\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3106s 34.6673ms 28.8456 Ops/s 29.2017 Ops/s $\color{#d91a1a}-1.22\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1603s 33.5925ms 29.7685 Ops/s 29.7347 Ops/s $\color{#35bf28}+0.11\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1605s 30.2171ms 33.0938 Ops/s 33.1094 Ops/s $\color{#d91a1a}-0.05\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1766s 30.6318ms 32.6458 Ops/s 29.2431 Ops/s $\textbf{\color{#35bf28}+11.64\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1584s 29.8592ms 33.4905 Ops/s 29.2612 Ops/s $\textbf{\color{#35bf28}+14.45\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1561s 32.6598ms 30.6187 Ops/s 32.7645 Ops/s $\textbf{\color{#d91a1a}-6.55\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1602s 30.1279ms 33.1918 Ops/s 29.9168 Ops/s $\textbf{\color{#35bf28}+10.95\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1608s 33.1412ms 30.1739 Ops/s 32.8451 Ops/s $\textbf{\color{#d91a1a}-8.13\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1625s 30.6401ms 32.6370 Ops/s 32.5247 Ops/s $\color{#35bf28}+0.35\%$

vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants