Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix CI PettingZoo #1528

Merged
merged 4 commits into from
Sep 14, 2023
Merged

[CI] Fix CI PettingZoo #1528

merged 4 commits into from
Sep 14, 2023

Conversation

matteobettini
Copy link
Contributor

Fixes the CI still referencing to the old circleci folder

@matteobettini
fix ci
d5b2e45 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2023
@matteobettini
add to setup
801bac5 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as draft September 14, 2023 15:37
@matteobettini
fix ci
a684969 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
dependency
72b0d52 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as ready for review September 14, 2023 15:55
@vmoens vmoens added bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) labels Sep 14, 2023
vmoens
vmoens approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 274cdfc into pytorch:main Sep 14, 2023
46 of 58 checks passed
@matteobettini matteobettini deleted the fix_ci_pettingzoo branch September 14, 2023 18:20
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Sep 18, 2023
@matteobettini @albertbou92
[CI] Fix CI PettingZoo (pytorch#1528)
acf3510 
Signed-off-by: Matteo Bettini <matbet@meta.com>
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@matteobettini @vmoens
[CI] Fix CI PettingZoo (pytorch#1528)
e08255f 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot