Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Small patches to SMAC #1533

Merged
merged 2 commits into from
Sep 15, 2023
Merged

[BugFix] Small patches to SMAC #1533

merged 2 commits into from
Sep 15, 2023

Conversation

matteobettini
Copy link
Contributor

Patched a bug in SMAC rendering and removes deprecation warnings

@matteobettini
test
f6482dc 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2023
@matteobettini matteobettini added bug Something isn't working Environments Adds or modifies an environment wrapper and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 15, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2023
vmoens
vmoens approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 98da063 into pytorch:main Sep 15, 2023
52 of 59 checks passed
@matteobettini matteobettini deleted the decrecation_warning_remove branch September 15, 2023 14:13
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Sep 18, 2023
@matteobettini @albertbou92
[BugFix] Small patches to SMAC (pytorch#1533)
37b5a3e 
Signed-off-by: Matteo Bettini <matbet@meta.com>
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@matteobettini @vmoens
[BugFix] Small patches to SMAC (pytorch#1533)
aadf2e3 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot