[BugFix] Improve collector buffer initialisation when policy spec is unavailable #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Signed-off-by: Matteo Bettini <matbet@meta.com>
matteobettini
commented
Sep 19, 2023
matteobettini
changed the title
matteobettini
commented
Sep 20, 2023
| if key in self._tensordict_out.keys(isinstance(key, tuple)): | ||
| continue | ||
| self._tensordict_out.set(key, spec.zero()) | ||
|
|
||
| else: |
There was a problem hiding this comment.
above here i just refactored
matteobettini
commented
Sep 20, 2023
| else: | ||
| # otherwise, we perform a small number of steps with the policy to | ||
| # determine the relevant keys with which to pre-populate _tensordict_out. | ||
| # This is the safest thing to do if the spec has None fields or if there is | ||
| # no spec at all. | ||
| # See #505 for additional context. | ||
| self._tensordict_out.update(self._tensordict) |
There was a problem hiding this comment.
we update the self._tensordict_out with the real data coming from env.reset()
matteobettini
commented
Sep 20, 2023
| .zero_() | ||
| ) | ||
| # in addition to outputs of the policy, we add traj_ids and step_count to | ||
| self._tensordict_out = self.policy(self._tensordict_out.to(self.device)) |
There was a problem hiding this comment.
and feed that to the policy
3 tasks
vmoens
approved these changes
Oct 1, 2023
vmoens
added a commit
to hyerra/rl
that referenced
this pull request
Oct 10, 2023
…unavailable (pytorch#1547) Signed-off-by: Matteo Bettini <matbet@meta.com> Co-authored-by: vmoens <vincentmoens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1539
Fixes #1565
This pr makes the collector use a sample policy forward on the reset data to generate their buffer when the policy spec is not available or partial.
The prior approach initialised the policy keys by passing the policy a
env.fake_tensordict()full of zeros, this made certain policies that use action masks or other masks throw errors as these masks were all False.This solution increases the generality of this initialization and makes sure that the policy is fed data that is suit to it