Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Dreamer test error #1558

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[BugFix] Fix Dreamer test error #1558

merged 2 commits into from
Sep 21, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 21, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2023
@vmoens vmoens added the bug Something isn't working label Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}26$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1235s 0.1181s 8.4660 Ops/s 8.3091 Ops/s $\color{#35bf28}+1.89\%$
test_sync 0.1920s 74.5414ms 13.4154 Ops/s 13.3341 Ops/s $\color{#35bf28}+0.61\%$
test_async 0.1233s 62.8060ms 15.9220 Ops/s 15.7948 Ops/s $\color{#35bf28}+0.81\%$
test_simple 1.0980s 1.0057s 0.9943 Ops/s 0.9818 Ops/s $\color{#35bf28}+1.28\%$
test_transformed 1.3459s 1.2717s 0.7864 Ops/s 0.7734 Ops/s $\color{#35bf28}+1.67\%$
test_serial 2.8987s 2.8425s 0.3518 Ops/s 0.3517 Ops/s $\color{#35bf28}+0.04\%$
test_parallel 2.5534s 2.4376s 0.4102 Ops/s 0.4065 Ops/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[True-True-True-True-True] 9.9475ms 56.0337μs 17.8464 KOps/s 16.0009 KOps/s $\textbf{\color{#35bf28}+11.53\%}$
test_step_mdp_speed[True-True-True-True-False] 3.2328ms 31.0088μs 32.2489 KOps/s 28.9089 KOps/s $\textbf{\color{#35bf28}+11.55\%}$
test_step_mdp_speed[True-True-True-False-True] 3.1898ms 40.2031μs 24.8737 KOps/s 23.5375 KOps/s $\textbf{\color{#35bf28}+5.68\%}$
test_step_mdp_speed[True-True-True-False-False] 2.3670ms 22.5189μs 44.4072 KOps/s 43.1819 KOps/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[True-True-False-True-True] 2.3766ms 57.0262μs 17.5358 KOps/s 17.1131 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[True-True-False-True-False] 2.6763ms 34.7317μs 28.7921 KOps/s 27.3047 KOps/s $\textbf{\color{#35bf28}+5.45\%}$
test_step_mdp_speed[True-True-False-False-True] 3.3714ms 42.9091μs 23.3051 KOps/s 22.0315 KOps/s $\textbf{\color{#35bf28}+5.78\%}$
test_step_mdp_speed[True-True-False-False-False] 4.1967ms 26.1052μs 38.3066 KOps/s 39.5037 KOps/s $\color{#d91a1a}-3.03\%$
test_step_mdp_speed[True-False-True-True-True] 6.0774ms 62.5362μs 15.9907 KOps/s 16.6424 KOps/s $\color{#d91a1a}-3.92\%$
test_step_mdp_speed[True-False-True-True-False] 3.3878ms 36.1239μs 27.6825 KOps/s 28.0527 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[True-False-True-False-True] 3.4240ms 43.1049μs 23.1992 KOps/s 23.1079 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[True-False-True-False-False] 3.2054ms 23.6913μs 42.2095 KOps/s 39.7129 KOps/s $\textbf{\color{#35bf28}+6.29\%}$
test_step_mdp_speed[True-False-False-True-True] 2.0249ms 61.6335μs 16.2249 KOps/s 15.9937 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-False-False-True-False] 1.9237ms 35.8214μs 27.9163 KOps/s 25.2945 KOps/s $\textbf{\color{#35bf28}+10.36\%}$
test_step_mdp_speed[True-False-False-False-True] 4.1256ms 43.9913μs 22.7318 KOps/s 21.0059 KOps/s $\textbf{\color{#35bf28}+8.22\%}$
test_step_mdp_speed[True-False-False-False-False] 1.8827ms 26.9550μs 37.0988 KOps/s 36.3887 KOps/s $\color{#35bf28}+1.95\%$
test_step_mdp_speed[False-True-True-True-True] 5.0275ms 61.0364μs 16.3837 KOps/s 16.0125 KOps/s $\color{#35bf28}+2.32\%$
test_step_mdp_speed[False-True-True-True-False] 2.1035ms 35.4918μs 28.1755 KOps/s 28.3322 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[False-True-True-False-True] 6.7438ms 45.0649μs 22.1902 KOps/s 20.5840 KOps/s $\textbf{\color{#35bf28}+7.80\%}$
test_step_mdp_speed[False-True-True-False-False] 2.9546ms 26.4953μs 37.7425 KOps/s 33.7292 KOps/s $\textbf{\color{#35bf28}+11.90\%}$
test_step_mdp_speed[False-True-False-True-True] 3.4439ms 59.9898μs 16.6695 KOps/s 15.9307 KOps/s $\color{#35bf28}+4.64\%$
test_step_mdp_speed[False-True-False-True-False] 2.5851ms 37.0866μs 26.9639 KOps/s 24.8857 KOps/s $\textbf{\color{#35bf28}+8.35\%}$
test_step_mdp_speed[False-True-False-False-True] 2.7924ms 44.6147μs 22.4141 KOps/s 18.5802 KOps/s $\textbf{\color{#35bf28}+20.63\%}$
test_step_mdp_speed[False-True-False-False-False] 1.6281ms 28.3816μs 35.2341 KOps/s 34.3017 KOps/s $\color{#35bf28}+2.72\%$
test_step_mdp_speed[False-False-True-True-True] 2.9260ms 63.4268μs 15.7662 KOps/s 15.8300 KOps/s $\color{#d91a1a}-0.40\%$
test_step_mdp_speed[False-False-True-True-False] 1.5648ms 39.7364μs 25.1659 KOps/s 23.6253 KOps/s $\textbf{\color{#35bf28}+6.52\%}$
test_step_mdp_speed[False-False-True-False-True] 2.8355ms 47.5812μs 21.0167 KOps/s 20.3527 KOps/s $\color{#35bf28}+3.26\%$
test_step_mdp_speed[False-False-True-False-False] 4.8888ms 27.6142μs 36.2133 KOps/s 33.3932 KOps/s $\textbf{\color{#35bf28}+8.45\%}$
test_step_mdp_speed[False-False-False-True-True] 5.3493ms 62.6171μs 15.9701 KOps/s 15.4505 KOps/s $\color{#35bf28}+3.36\%$
test_step_mdp_speed[False-False-False-True-False] 2.3837ms 41.3850μs 24.1633 KOps/s 23.4546 KOps/s $\color{#35bf28}+3.02\%$
test_step_mdp_speed[False-False-False-False-True] 2.8172ms 46.3253μs 21.5865 KOps/s 19.7081 KOps/s $\textbf{\color{#35bf28}+9.53\%}$
test_step_mdp_speed[False-False-False-False-False] 3.7365ms 30.8109μs 32.4560 KOps/s 30.0936 KOps/s $\textbf{\color{#35bf28}+7.85\%}$
test_values[generalized_advantage_estimate-True-True] 21.8426ms 17.8371ms 56.0630 Ops/s 50.6869 Ops/s $\textbf{\color{#35bf28}+10.61\%}$
test_values[vec_generalized_advantage_estimate-True-True] 0.1010s 80.0613ms 12.4904 Ops/s 12.7546 Ops/s $\color{#d91a1a}-2.07\%$
test_values[td0_return_estimate-False-False] 0.7707ms 0.3347ms 2.9881 KOps/s 1.6869 KOps/s $\textbf{\color{#35bf28}+77.13\%}$
test_values[td1_return_estimate-False-False] 21.4511ms 17.1521ms 58.3018 Ops/s 53.0699 Ops/s $\textbf{\color{#35bf28}+9.86\%}$
test_values[vec_td1_return_estimate-False-False] 89.6311ms 78.3986ms 12.7553 Ops/s 12.7683 Ops/s $\color{#d91a1a}-0.10\%$
test_values[td_lambda_return_estimate-True-False] 62.6065ms 51.3044ms 19.4915 Ops/s 17.8086 Ops/s $\textbf{\color{#35bf28}+9.45\%}$
test_values[vec_td_lambda_return_estimate-True-False] 88.6394ms 78.5573ms 12.7296 Ops/s 12.6729 Ops/s $\color{#35bf28}+0.45\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 22.2175ms 14.3731ms 69.5745 Ops/s 66.6706 Ops/s $\color{#35bf28}+4.36\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 12.7209ms 4.7832ms 209.0652 Ops/s 208.1402 Ops/s $\color{#35bf28}+0.44\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 6.3958ms 0.7748ms 1.2906 KOps/s 1.2546 KOps/s $\color{#35bf28}+2.87\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 89.1585ms 80.1341ms 12.4791 Ops/s 12.0606 Ops/s $\color{#35bf28}+3.47\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 12.7194ms 6.6175ms 151.1139 Ops/s 150.8504 Ops/s $\color{#35bf28}+0.17\%$
test_dqn_speed 12.3822ms 2.9411ms 340.0071 Ops/s 336.4158 Ops/s $\color{#35bf28}+1.07\%$
test_ddpg_speed 14.5115ms 5.0438ms 198.2640 Ops/s 192.7756 Ops/s $\color{#35bf28}+2.85\%$
test_sac_speed 25.5505ms 14.8603ms 67.2936 Ops/s 66.8145 Ops/s $\color{#35bf28}+0.72\%$
test_redq_speed 43.0004ms 30.8762ms 32.3874 Ops/s 34.8645 Ops/s $\textbf{\color{#d91a1a}-7.11\%}$
test_redq_deprec_speed 34.4455ms 25.0987ms 39.8427 Ops/s 41.9997 Ops/s $\textbf{\color{#d91a1a}-5.14\%}$
test_td3_speed 22.3674ms 18.6426ms 53.6405 Ops/s 55.3194 Ops/s $\color{#d91a1a}-3.03\%$
test_cql_speed 77.9150ms 64.3100ms 15.5497 Ops/s 16.7829 Ops/s $\textbf{\color{#d91a1a}-7.35\%}$
test_a2c_speed 23.6724ms 12.6392ms 79.1191 Ops/s 81.0375 Ops/s $\color{#d91a1a}-2.37\%$
test_ppo_speed 28.7084ms 13.4479ms 74.3608 Ops/s 74.1935 Ops/s $\color{#35bf28}+0.23\%$
test_reinforce_speed 19.5250ms 10.5315ms 94.9528 Ops/s 93.5437 Ops/s $\color{#35bf28}+1.51\%$
test_iql_speed 71.2961ms 52.3428ms 19.1048 Ops/s 18.5212 Ops/s $\color{#35bf28}+3.15\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 9.8568ms 3.4087ms 293.3677 Ops/s 275.0038 Ops/s $\textbf{\color{#35bf28}+6.68\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.3791ms 3.6170ms 276.4689 Ops/s 259.9097 Ops/s $\textbf{\color{#35bf28}+6.37\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.7126ms 3.6685ms 272.5907 Ops/s 252.1694 Ops/s $\textbf{\color{#35bf28}+8.10\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 10.4408ms 3.4668ms 288.4512 Ops/s 269.2598 Ops/s $\textbf{\color{#35bf28}+7.13\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 12.4057ms 3.8045ms 262.8488 Ops/s 264.3818 Ops/s $\color{#d91a1a}-0.58\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 11.4139ms 3.7190ms 268.8914 Ops/s 258.4679 Ops/s $\color{#35bf28}+4.03\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 12.4603ms 3.4245ms 292.0121 Ops/s 263.8691 Ops/s $\textbf{\color{#35bf28}+10.67\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 8.4205ms 3.7518ms 266.5399 Ops/s 267.7625 Ops/s $\color{#d91a1a}-0.46\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.9125ms 3.6348ms 275.1172 Ops/s 257.9979 Ops/s $\textbf{\color{#35bf28}+6.64\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.3675ms 3.6857ms 271.3162 Ops/s 278.5384 Ops/s $\color{#d91a1a}-2.59\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.9149ms 3.6539ms 273.6800 Ops/s 263.4870 Ops/s $\color{#35bf28}+3.87\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.2136s 4.9348ms 202.6442 Ops/s 265.4798 Ops/s $\textbf{\color{#d91a1a}-23.67\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.2690ms 3.6430ms 274.4979 Ops/s 293.3719 Ops/s $\textbf{\color{#d91a1a}-6.43\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 6.7619ms 3.8707ms 258.3542 Ops/s 279.5535 Ops/s $\textbf{\color{#d91a1a}-7.58\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 8.1240ms 3.8027ms 262.9744 Ops/s 270.2050 Ops/s $\color{#d91a1a}-2.68\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.3288ms 3.5864ms 278.8340 Ops/s 289.4234 Ops/s $\color{#d91a1a}-3.66\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 8.8307ms 3.9107ms 255.7088 Ops/s 285.6368 Ops/s $\textbf{\color{#d91a1a}-10.48\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 9.3664ms 3.7691ms 265.3181 Ops/s 280.3560 Ops/s $\textbf{\color{#d91a1a}-5.36\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3067s 42.9689ms 23.2727 Ops/s 23.5795 Ops/s $\color{#d91a1a}-1.30\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1987s 41.3954ms 24.1573 Ops/s 24.2777 Ops/s $\color{#d91a1a}-0.50\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.2017s 37.9568ms 26.3457 Ops/s 26.8815 Ops/s $\color{#d91a1a}-1.99\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2038s 40.1725ms 24.8927 Ops/s 23.7101 Ops/s $\color{#35bf28}+4.99\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.2065s 36.4948ms 27.4011 Ops/s 26.6490 Ops/s $\color{#35bf28}+2.82\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.2047s 40.8278ms 24.4931 Ops/s 24.7315 Ops/s $\color{#d91a1a}-0.96\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2050s 38.1595ms 26.2058 Ops/s 25.8747 Ops/s $\color{#35bf28}+1.28\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1932s 40.9508ms 24.4195 Ops/s 24.1470 Ops/s $\color{#35bf28}+1.13\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1901s 38.1193ms 26.2334 Ops/s 25.8786 Ops/s $\color{#35bf28}+1.37\%$

Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting paradise

@vmoens vmoens merged commit 99dcae8 into main Sep 21, 2023
47 of 55 checks passed
@vmoens vmoens deleted the fix_dreamer_tests branch September 21, 2023 10:16
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants