Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Remove ya gymnasium deprecation warning in vectorized envs #1573

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 25, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2023
@vmoens vmoens added the quality code quality label Sep 25, 2023
@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}11$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 76.4173ms 75.5689ms 13.2330 Ops/s 13.1868 Ops/s $\color{#35bf28}+0.35\%$
test_sync 0.1331s 46.2244ms 21.6336 Ops/s 22.2097 Ops/s $\color{#d91a1a}-2.59\%$
test_async 99.7348ms 39.7653ms 25.1475 Ops/s 25.8451 Ops/s $\color{#d91a1a}-2.70\%$
test_simple 0.7217s 0.6467s 1.5464 Ops/s 1.5509 Ops/s $\color{#d91a1a}-0.29\%$
test_transformed 0.9160s 0.8624s 1.1595 Ops/s 1.1866 Ops/s $\color{#d91a1a}-2.28\%$
test_serial 1.8862s 1.8198s 0.5495 Ops/s 0.5444 Ops/s $\color{#35bf28}+0.94\%$
test_parallel 1.6615s 1.5994s 0.6253 Ops/s 0.6371 Ops/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[True-True-True-True-True] 0.1978ms 44.2564μs 22.5956 KOps/s 22.7251 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-True-True-True-False] 46.6020μs 25.0810μs 39.8709 KOps/s 39.6483 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[True-True-True-False-True] 97.6030μs 30.9773μs 32.2817 KOps/s 32.0149 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-True-True-False-False] 40.6010μs 17.4574μs 57.2823 KOps/s 56.8201 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[True-True-False-True-True] 0.1161ms 45.8930μs 21.7898 KOps/s 21.6977 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-True-False-True-False] 0.1119ms 26.8996μs 37.1753 KOps/s 37.2615 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-True-False-False-True] 85.9020μs 33.1143μs 30.1985 KOps/s 29.7943 KOps/s $\color{#35bf28}+1.36\%$
test_step_mdp_speed[True-True-False-False-False] 96.8030μs 19.3483μs 51.6842 KOps/s 51.3341 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-False-True-True-True] 96.1020μs 47.5835μs 21.0157 KOps/s 20.7277 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[True-False-True-True-False] 0.1247ms 28.7991μs 34.7233 KOps/s 34.8557 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[True-False-True-False-True] 99.9020μs 32.7976μs 30.4900 KOps/s 29.7550 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[True-False-True-False-False] 95.6020μs 19.2064μs 52.0659 KOps/s 51.6212 KOps/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[True-False-False-True-True] 79.7020μs 49.3252μs 20.2736 KOps/s 20.1898 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-False-False-True-False] 56.9010μs 30.4579μs 32.8322 KOps/s 33.1129 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[True-False-False-False-True] 0.1201ms 34.3729μs 29.0927 KOps/s 28.8646 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[True-False-False-False-False] 57.9020μs 21.1329μs 47.3196 KOps/s 47.8345 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-True-True-True] 0.1179ms 47.4316μs 21.0830 KOps/s 20.7160 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[False-True-True-True-False] 64.1020μs 28.6775μs 34.8706 KOps/s 34.7770 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[False-True-True-False-True] 0.1131ms 36.8192μs 27.1598 KOps/s 27.0661 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[False-True-True-False-False] 58.0010μs 21.4475μs 46.6256 KOps/s 45.6605 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[False-True-False-True-True] 0.1031ms 49.0876μs 20.3718 KOps/s 20.3094 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-True-False-True-False] 0.1131ms 30.2657μs 33.0407 KOps/s 32.5536 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[False-True-False-False-True] 86.6020μs 38.2149μs 26.1678 KOps/s 25.9553 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[False-True-False-False-False] 0.1114ms 22.8347μs 43.7929 KOps/s 42.5424 KOps/s $\color{#35bf28}+2.94\%$
test_step_mdp_speed[False-False-True-True-True] 87.3020μs 50.7514μs 19.7039 KOps/s 19.1992 KOps/s $\color{#35bf28}+2.63\%$
test_step_mdp_speed[False-False-True-True-False] 85.5030μs 32.4858μs 30.7827 KOps/s 30.5001 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-True-False-True] 0.1127ms 38.3018μs 26.1084 KOps/s 25.9029 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[False-False-True-False-False] 46.1010μs 22.8711μs 43.7234 KOps/s 43.1065 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-False-False-True-True] 0.1253ms 52.5179μs 19.0411 KOps/s 19.1616 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[False-False-False-True-False] 54.6020μs 34.0466μs 29.3715 KOps/s 29.5139 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[False-False-False-False-True] 0.1009ms 39.7594μs 25.1513 KOps/s 25.1550 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[False-False-False-False-False] 1.1143ms 24.4882μs 40.8360 KOps/s 40.6262 KOps/s $\color{#35bf28}+0.52\%$
test_values[generalized_advantage_estimate-True-True] 15.1770ms 13.9174ms 71.8527 Ops/s 69.2692 Ops/s $\color{#35bf28}+3.73\%$
test_values[vec_generalized_advantage_estimate-True-True] 55.7583ms 44.0864ms 22.6827 Ops/s 21.9243 Ops/s $\color{#35bf28}+3.46\%$
test_values[td0_return_estimate-False-False] 0.6218ms 0.4053ms 2.4672 KOps/s 2.0599 KOps/s $\textbf{\color{#35bf28}+19.77\%}$
test_values[td1_return_estimate-False-False] 13.9330ms 13.3694ms 74.7978 Ops/s 72.9838 Ops/s $\color{#35bf28}+2.49\%$
test_values[vec_td1_return_estimate-False-False] 71.7564ms 46.2890ms 21.6034 Ops/s 22.6788 Ops/s $\color{#d91a1a}-4.74\%$
test_values[td_lambda_return_estimate-True-False] 32.9251ms 31.8714ms 31.3761 Ops/s 30.4621 Ops/s $\color{#35bf28}+3.00\%$
test_values[vec_td_lambda_return_estimate-True-False] 52.2847ms 43.9259ms 22.7656 Ops/s 21.8401 Ops/s $\color{#35bf28}+4.24\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 12.3072ms 11.8589ms 84.3251 Ops/s 82.0499 Ops/s $\color{#35bf28}+2.77\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 9.0380ms 4.7707ms 209.6125 Ops/s 256.5902 Ops/s $\textbf{\color{#d91a1a}-18.31\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 2.9971ms 0.5566ms 1.7965 KOps/s 1.7794 KOps/s $\color{#35bf28}+0.96\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 63.0116ms 51.6728ms 19.3525 Ops/s 16.8611 Ops/s $\textbf{\color{#35bf28}+14.78\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 11.1342ms 3.2849ms 304.4246 Ops/s 270.9528 Ops/s $\textbf{\color{#35bf28}+12.35\%}$
test_dqn_speed 8.9149ms 2.4784ms 403.4832 Ops/s 420.4928 Ops/s $\color{#d91a1a}-4.05\%$
test_ddpg_speed 10.0084ms 4.3190ms 231.5339 Ops/s 227.5548 Ops/s $\color{#35bf28}+1.75\%$
test_sac_speed 18.9053ms 11.8249ms 84.5671 Ops/s 84.3976 Ops/s $\color{#35bf28}+0.20\%$
test_redq_speed 27.8434ms 21.2532ms 47.0517 Ops/s 48.9887 Ops/s $\color{#d91a1a}-3.95\%$
test_redq_deprec_speed 24.2904ms 17.5779ms 56.8896 Ops/s 55.8876 Ops/s $\color{#35bf28}+1.79\%$
test_td3_speed 14.6476ms 12.7672ms 78.3258 Ops/s 79.1833 Ops/s $\color{#d91a1a}-1.08\%$
test_cql_speed 39.9795ms 34.9857ms 28.5831 Ops/s 26.0680 Ops/s $\textbf{\color{#35bf28}+9.65\%}$
test_a2c_speed 14.7307ms 7.5241ms 132.9061 Ops/s 125.3843 Ops/s $\textbf{\color{#35bf28}+6.00\%}$
test_ppo_speed 15.1490ms 8.1910ms 122.0857 Ops/s 123.4141 Ops/s $\color{#d91a1a}-1.08\%$
test_reinforce_speed 24.4797ms 6.3091ms 158.5008 Ops/s 164.0375 Ops/s $\color{#d91a1a}-3.38\%$
test_iql_speed 37.3768ms 31.7223ms 31.5236 Ops/s 29.1117 Ops/s $\textbf{\color{#35bf28}+8.28\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.5817ms 2.5991ms 384.7536 Ops/s 384.6233 Ops/s $\color{#35bf28}+0.03\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.3864ms 2.7806ms 359.6388 Ops/s 358.5813 Ops/s $\color{#35bf28}+0.29\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.2921ms 2.8027ms 356.7935 Ops/s 355.6560 Ops/s $\color{#35bf28}+0.32\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.6742ms 2.6040ms 384.0175 Ops/s 374.7708 Ops/s $\color{#35bf28}+2.47\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.8272ms 2.8011ms 356.9979 Ops/s 349.1245 Ops/s $\color{#35bf28}+2.26\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.9576ms 2.8161ms 355.1026 Ops/s 353.6644 Ops/s $\color{#35bf28}+0.41\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.9049ms 2.6011ms 384.4569 Ops/s 378.7246 Ops/s $\color{#35bf28}+1.51\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.6576ms 2.8599ms 349.6663 Ops/s 353.1014 Ops/s $\color{#d91a1a}-0.97\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.1725ms 2.7626ms 361.9822 Ops/s 348.4871 Ops/s $\color{#35bf28}+3.87\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6611ms 2.6250ms 380.9551 Ops/s 383.3945 Ops/s $\color{#d91a1a}-0.64\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.0289ms 2.8643ms 349.1232 Ops/s 356.5809 Ops/s $\color{#d91a1a}-2.09\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1730s 3.2588ms 306.8605 Ops/s 357.7451 Ops/s $\textbf{\color{#d91a1a}-14.22\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.4914ms 2.5853ms 386.8009 Ops/s 385.8127 Ops/s $\color{#35bf28}+0.26\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.8047ms 2.8557ms 350.1807 Ops/s 348.9789 Ops/s $\color{#35bf28}+0.34\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 5.1997ms 2.8902ms 345.9928 Ops/s 353.6414 Ops/s $\color{#d91a1a}-2.16\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.6008ms 2.5853ms 386.7994 Ops/s 372.7460 Ops/s $\color{#35bf28}+3.77\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.7405ms 2.8038ms 356.6600 Ops/s 352.8527 Ops/s $\color{#35bf28}+1.08\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 5.4415ms 2.8243ms 354.0709 Ops/s 331.3869 Ops/s $\textbf{\color{#35bf28}+6.85\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2673s 33.6226ms 29.7419 Ops/s 30.9406 Ops/s $\color{#d91a1a}-3.87\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1696s 28.5172ms 35.0666 Ops/s 31.4932 Ops/s $\textbf{\color{#35bf28}+11.35\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1710s 31.5727ms 31.6730 Ops/s 34.5103 Ops/s $\textbf{\color{#d91a1a}-8.22\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1667s 31.4594ms 31.7870 Ops/s 31.0760 Ops/s $\color{#35bf28}+2.29\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1671s 28.5086ms 35.0772 Ops/s 30.7059 Ops/s $\textbf{\color{#35bf28}+14.24\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1623s 31.2271ms 32.0235 Ops/s 38.4170 Ops/s $\textbf{\color{#d91a1a}-16.64\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1685s 28.4197ms 35.1868 Ops/s 31.7058 Ops/s $\textbf{\color{#35bf28}+10.98\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1660s 31.4889ms 31.7572 Ops/s 34.9854 Ops/s $\textbf{\color{#d91a1a}-9.23\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1639s 28.5657ms 35.0070 Ops/s 31.6462 Ops/s $\textbf{\color{#35bf28}+10.62\%}$

@vmoens vmoens merged commit 7f42576 into main Sep 27, 2023
53 of 59 checks passed
@vmoens vmoens deleted the fix_unwrapped_warn branch September 27, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants