-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Pointers to BenchMARL #1710
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1710
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (10 Unrelated Failures)As of commit 560df73 with merge base b38d4b7 (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should avoid We, because we don't want to suggest that we're building an ecosystem (like other foundations...)
We should also avoid giving sense of temporality like "we have just done this" because we'll forget about that and 2y from now it will still look like we have "just" done something.
For the Ecosystem part, I would wait until github comes back to us and shows how we can display the dependency graph.
Gymnasium used to have a list of useful resources and such, and they took it off. IMO it was because everyone wanted to be in it, and eventually there wasn't a clear-cut rule on who should or should not have the right to be in it.
We already have a bunch of users, and they could all legitimately ask to be in the list.
What rule of thumb would you suggest?
Got it. I have adapted it with this feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.