Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Pointers to BenchMARL #1710

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

matteobettini
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Nov 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1710

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (10 Unrelated Failures)

As of commit 560df73 with merge base b38d4b7 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2023
@matteobettini matteobettini marked this pull request as ready for review November 23, 2023 09:23
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid We, because we don't want to suggest that we're building an ecosystem (like other foundations...)
We should also avoid giving sense of temporality like "we have just done this" because we'll forget about that and 2y from now it will still look like we have "just" done something.

For the Ecosystem part, I would wait until github comes back to us and shows how we can display the dependency graph.
Gymnasium used to have a list of useful resources and such, and they took it off. IMO it was because everyone wanted to be in it, and eventually there wasn't a clear-cut rule on who should or should not have the right to be in it.
We already have a bunch of users, and they could all legitimately ask to be in the list.
What rule of thumb would you suggest?

@matteobettini
Copy link
Contributor Author

Got it.

I have adapted it with this feedback

@vmoens vmoens added the documentation Improvements or additions to documentation label Nov 27, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 58571f0 into pytorch:main Jan 9, 2024
51 of 61 checks passed
@matteobettini matteobettini deleted the benchmarl_pointers branch January 17, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants