Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix, CI] Fix OpenML datasets runs #1779

Merged
merged 2 commits into from
Jan 8, 2024
Merged

[BugFix, CI] Fix OpenML datasets runs #1779

merged 2 commits into from
Jan 8, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 8, 2024

No description provided.

Copy link

pytorch-bot bot commented Jan 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1779

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit c77526a with merge base 55faae1 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}25$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 66.1423ms 64.1336ms 15.5925 Ops/s 15.3125 Ops/s $\color{#35bf28}+1.83\%$
test_sync 52.4139ms 40.2648ms 24.8356 Ops/s 29.0165 Ops/s $\textbf{\color{#d91a1a}-14.41\%}$
test_async 67.3812ms 34.0252ms 29.3900 Ops/s 29.2077 Ops/s $\color{#35bf28}+0.62\%$
test_simple 0.5022s 0.4439s 2.2525 Ops/s 2.2022 Ops/s $\color{#35bf28}+2.29\%$
test_transformed 0.6661s 0.6116s 1.6350 Ops/s 1.6174 Ops/s $\color{#35bf28}+1.09\%$
test_serial 1.4246s 1.3662s 0.7320 Ops/s 0.7124 Ops/s $\color{#35bf28}+2.75\%$
test_parallel 1.4209s 1.3588s 0.7359 Ops/s 0.7343 Ops/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-True-True-True-True] 0.1081ms 21.4330μs 46.6571 KOps/s 43.6518 KOps/s $\textbf{\color{#35bf28}+6.88\%}$
test_step_mdp_speed[True-True-True-True-False] 86.4060μs 13.2856μs 75.2697 KOps/s 73.6861 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-True-True-False-True] 32.3700μs 12.8887μs 77.5876 KOps/s 73.9641 KOps/s $\color{#35bf28}+4.90\%$
test_step_mdp_speed[True-True-True-False-False] 31.4780μs 7.7081μs 129.7331 KOps/s 121.7937 KOps/s $\textbf{\color{#35bf28}+6.52\%}$
test_step_mdp_speed[True-True-False-True-True] 56.7350μs 22.7823μs 43.8938 KOps/s 41.7344 KOps/s $\textbf{\color{#35bf28}+5.17\%}$
test_step_mdp_speed[True-True-False-True-False] 36.4670μs 14.3400μs 69.7351 KOps/s 67.1990 KOps/s $\color{#35bf28}+3.77\%$
test_step_mdp_speed[True-True-False-False-True] 40.6050μs 13.9276μs 71.8000 KOps/s 67.5963 KOps/s $\textbf{\color{#35bf28}+6.22\%}$
test_step_mdp_speed[True-True-False-False-False] 37.7290μs 8.8769μs 112.6514 KOps/s 105.6940 KOps/s $\textbf{\color{#35bf28}+6.58\%}$
test_step_mdp_speed[True-False-True-True-True] 0.1007ms 24.4997μs 40.8169 KOps/s 38.7751 KOps/s $\textbf{\color{#35bf28}+5.27\%}$
test_step_mdp_speed[True-False-True-True-False] 50.9840μs 15.6438μs 63.9231 KOps/s 61.5957 KOps/s $\color{#35bf28}+3.78\%$
test_step_mdp_speed[True-False-True-False-True] 37.5600μs 13.8758μs 72.0680 KOps/s 66.7126 KOps/s $\textbf{\color{#35bf28}+8.03\%}$
test_step_mdp_speed[True-False-True-False-False] 37.2290μs 8.9153μs 112.1673 KOps/s 106.0356 KOps/s $\textbf{\color{#35bf28}+5.78\%}$
test_step_mdp_speed[True-False-False-True-True] 51.4660μs 25.1400μs 39.7773 KOps/s 37.6567 KOps/s $\textbf{\color{#35bf28}+5.63\%}$
test_step_mdp_speed[True-False-False-True-False] 57.7870μs 16.8248μs 59.4361 KOps/s 56.9838 KOps/s $\color{#35bf28}+4.30\%$
test_step_mdp_speed[True-False-False-False-True] 46.4860μs 15.1147μs 66.1608 KOps/s 62.7156 KOps/s $\textbf{\color{#35bf28}+5.49\%}$
test_step_mdp_speed[True-False-False-False-False] 27.6010μs 10.0444μs 99.5580 KOps/s 94.6640 KOps/s $\textbf{\color{#35bf28}+5.17\%}$
test_step_mdp_speed[False-True-True-True-True] 64.5000μs 24.2488μs 41.2391 KOps/s 39.7555 KOps/s $\color{#35bf28}+3.73\%$
test_step_mdp_speed[False-True-True-True-False] 39.7740μs 15.6837μs 63.7603 KOps/s 61.8197 KOps/s $\color{#35bf28}+3.14\%$
test_step_mdp_speed[False-True-True-False-True] 52.7080μs 16.1754μs 61.8223 KOps/s 57.8474 KOps/s $\textbf{\color{#35bf28}+6.87\%}$
test_step_mdp_speed[False-True-True-False-False] 80.1880μs 10.2184μs 97.8628 KOps/s 94.0407 KOps/s $\color{#35bf28}+4.06\%$
test_step_mdp_speed[False-True-False-True-True] 65.8530μs 25.2142μs 39.6602 KOps/s 37.6812 KOps/s $\textbf{\color{#35bf28}+5.25\%}$
test_step_mdp_speed[False-True-False-True-False] 59.2290μs 16.8067μs 59.5002 KOps/s 57.0896 KOps/s $\color{#35bf28}+4.22\%$
test_step_mdp_speed[False-True-False-False-True] 53.2080μs 17.1757μs 58.2216 KOps/s 54.1991 KOps/s $\textbf{\color{#35bf28}+7.42\%}$
test_step_mdp_speed[False-True-False-False-False] 28.4020μs 11.2744μs 88.6966 KOps/s 85.8495 KOps/s $\color{#35bf28}+3.32\%$
test_step_mdp_speed[False-False-True-True-True] 67.3350μs 26.3917μs 37.8907 KOps/s 35.9521 KOps/s $\textbf{\color{#35bf28}+5.39\%}$
test_step_mdp_speed[False-False-True-True-False] 55.0420μs 18.0776μs 55.3170 KOps/s 53.5300 KOps/s $\color{#35bf28}+3.34\%$
test_step_mdp_speed[False-False-True-False-True] 55.9530μs 17.5409μs 57.0096 KOps/s 54.2661 KOps/s $\textbf{\color{#35bf28}+5.06\%}$
test_step_mdp_speed[False-False-True-False-False] 42.2480μs 11.3126μs 88.3971 KOps/s 85.4993 KOps/s $\color{#35bf28}+3.39\%$
test_step_mdp_speed[False-False-False-True-True] 54.3900μs 27.3740μs 36.5310 KOps/s 34.5762 KOps/s $\textbf{\color{#35bf28}+5.65\%}$
test_step_mdp_speed[False-False-False-True-False] 64.5870μs 18.9290μs 52.8289 KOps/s 50.6038 KOps/s $\color{#35bf28}+4.40\%$
test_step_mdp_speed[False-False-False-False-True] 62.2650μs 18.0618μs 55.3653 KOps/s 51.7696 KOps/s $\textbf{\color{#35bf28}+6.95\%}$
test_step_mdp_speed[False-False-False-False-False] 33.5720μs 12.2298μs 81.7675 KOps/s 77.2904 KOps/s $\textbf{\color{#35bf28}+5.79\%}$
test_values[generalized_advantage_estimate-True-True] 13.6348ms 12.2606ms 81.5622 Ops/s 81.7162 Ops/s $\color{#d91a1a}-0.19\%$
test_values[vec_generalized_advantage_estimate-True-True] 34.1110ms 26.7336ms 37.4061 Ops/s 35.3529 Ops/s $\textbf{\color{#35bf28}+5.81\%}$
test_values[td0_return_estimate-False-False] 0.2300ms 0.1754ms 5.7011 KOps/s 5.6001 KOps/s $\color{#35bf28}+1.80\%$
test_values[td1_return_estimate-False-False] 26.4622ms 25.8777ms 38.6433 Ops/s 38.7136 Ops/s $\color{#d91a1a}-0.18\%$
test_values[vec_td1_return_estimate-False-False] 35.1203ms 27.2242ms 36.7320 Ops/s 35.2982 Ops/s $\color{#35bf28}+4.06\%$
test_values[td_lambda_return_estimate-True-False] 36.7879ms 36.2408ms 27.5932 Ops/s 27.2862 Ops/s $\color{#35bf28}+1.13\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.6260ms 26.7281ms 37.4138 Ops/s 35.3091 Ops/s $\textbf{\color{#35bf28}+5.96\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2728ms 8.1613ms 122.5291 Ops/s 123.3400 Ops/s $\color{#d91a1a}-0.66\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 10.6023ms 1.9245ms 519.6182 Ops/s 536.0661 Ops/s $\color{#d91a1a}-3.07\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 1.5875ms 0.4407ms 2.2693 KOps/s 2.2688 KOps/s $\color{#35bf28}+0.02\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 42.8648ms 35.2224ms 28.3911 Ops/s 25.5356 Ops/s $\textbf{\color{#35bf28}+11.18\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 11.3326ms 2.6640ms 375.3751 Ops/s 379.7095 Ops/s $\color{#d91a1a}-1.14\%$
test_dqn_speed 82.3901ms 8.2827ms 120.7336 Ops/s 117.7651 Ops/s $\color{#35bf28}+2.52\%$
test_ddpg_speed 21.2413ms 14.7438ms 67.8250 Ops/s 66.7154 Ops/s $\color{#35bf28}+1.66\%$
test_sac_speed 33.1648ms 29.5809ms 33.8056 Ops/s 32.8539 Ops/s $\color{#35bf28}+2.90\%$
test_redq_speed 40.2115ms 35.8063ms 27.9281 Ops/s 27.3042 Ops/s $\color{#35bf28}+2.28\%$
test_redq_deprec_speed 27.3199ms 25.6555ms 38.9780 Ops/s 37.9766 Ops/s $\color{#35bf28}+2.64\%$
test_td3_speed 28.8352ms 20.5848ms 48.5796 Ops/s 47.4821 Ops/s $\color{#35bf28}+2.31\%$
test_cql_speed 98.6154ms 88.6375ms 11.2819 Ops/s 11.0600 Ops/s $\color{#35bf28}+2.01\%$
test_a2c_speed 31.6851ms 26.8201ms 37.2854 Ops/s 35.8733 Ops/s $\color{#35bf28}+3.94\%$
test_ppo_speed 29.6710ms 26.9661ms 37.0836 Ops/s 35.3882 Ops/s $\color{#35bf28}+4.79\%$
test_reinforce_speed 30.4389ms 25.9671ms 38.5102 Ops/s 37.3552 Ops/s $\color{#35bf28}+3.09\%$
test_iql_speed 69.1629ms 64.2885ms 15.5549 Ops/s 15.2389 Ops/s $\color{#35bf28}+2.07\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2559ms 1.4568ms 686.4212 Ops/s 689.1867 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 8.7977ms 0.5217ms 1.9167 KOps/s 1.9176 KOps/s $\color{#d91a1a}-0.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.8699ms 0.5106ms 1.9585 KOps/s 1.9790 KOps/s $\color{#d91a1a}-1.04\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 1.9252ms 1.4122ms 708.1318 Ops/s 704.1449 Ops/s $\color{#35bf28}+0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.2996ms 0.5088ms 1.9655 KOps/s 1.9171 KOps/s $\color{#35bf28}+2.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 8.8899ms 0.5033ms 1.9869 KOps/s 1.9718 KOps/s $\color{#35bf28}+0.77\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.5003ms 1.6468ms 607.2322 Ops/s 605.0442 Ops/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 9.0155ms 0.6563ms 1.5237 KOps/s 1.5078 KOps/s $\color{#35bf28}+1.05\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.9108ms 0.6398ms 1.5629 KOps/s 1.5695 KOps/s $\color{#d91a1a}-0.42\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2385ms 1.4723ms 679.1984 Ops/s 600.8832 Ops/s $\textbf{\color{#35bf28}+13.03\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3026ms 0.5180ms 1.9303 KOps/s 1.9280 KOps/s $\color{#35bf28}+0.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 7.2195ms 0.5077ms 1.9695 KOps/s 1.9347 KOps/s $\color{#35bf28}+1.80\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 1.7299ms 1.4506ms 689.3738 Ops/s 708.1905 Ops/s $\color{#d91a1a}-2.66\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 9.0074ms 0.5254ms 1.9034 KOps/s 1.8906 KOps/s $\color{#35bf28}+0.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 1.7409ms 0.4985ms 2.0062 KOps/s 1.9917 KOps/s $\color{#35bf28}+0.73\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.0295ms 1.6243ms 615.6448 Ops/s 616.5847 Ops/s $\color{#d91a1a}-0.15\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 8.9786ms 0.6606ms 1.5139 KOps/s 1.4898 KOps/s $\color{#35bf28}+1.62\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8066ms 0.6366ms 1.5708 KOps/s 1.5587 KOps/s $\color{#35bf28}+0.78\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1212s 16.8809ms 59.2386 Ops/s 56.9310 Ops/s $\color{#35bf28}+4.05\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1080s 14.1818ms 70.5129 Ops/s 81.5439 Ops/s $\textbf{\color{#d91a1a}-13.53\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.3115ms 1.5951ms 626.9009 Ops/s 609.5390 Ops/s $\color{#35bf28}+2.85\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1205s 14.7643ms 67.7309 Ops/s 58.2241 Ops/s $\textbf{\color{#35bf28}+16.33\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1165s 14.2649ms 70.1021 Ops/s 81.9582 Ops/s $\textbf{\color{#d91a1a}-14.47\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 10.2734ms 1.7597ms 568.2719 Ops/s 624.5245 Ops/s $\textbf{\color{#d91a1a}-9.01\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1133s 14.6937ms 68.0563 Ops/s 58.4863 Ops/s $\textbf{\color{#35bf28}+16.36\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1129s 14.3658ms 69.6096 Ops/s 80.1603 Ops/s $\textbf{\color{#d91a1a}-13.16\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.2999ms 1.7499ms 571.4503 Ops/s 548.2851 Ops/s $\color{#35bf28}+4.23\%$

@vmoens vmoens added the bug Something isn't working label Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1236s 0.1235s 8.0964 Ops/s 7.8340 Ops/s $\color{#35bf28}+3.35\%$
test_sync 0.1811s 0.1105s 9.0486 Ops/s 9.0152 Ops/s $\color{#35bf28}+0.37\%$
test_async 0.1992s 99.6413ms 10.0360 Ops/s 10.0600 Ops/s $\color{#d91a1a}-0.24\%$
test_single_pixels 0.1474s 0.1471s 6.7972 Ops/s 6.7365 Ops/s $\color{#35bf28}+0.90\%$
test_sync_pixels 97.9720ms 96.3874ms 10.3748 Ops/s 10.3555 Ops/s $\color{#35bf28}+0.19\%$
test_async_pixels 0.2459s 91.9260ms 10.8783 Ops/s 10.8129 Ops/s $\color{#35bf28}+0.61\%$
test_simple 0.9726s 0.9030s 1.1074 Ops/s 1.0924 Ops/s $\color{#35bf28}+1.37\%$
test_transformed 1.2164s 1.1491s 0.8702 Ops/s 0.8679 Ops/s $\color{#35bf28}+0.27\%$
test_serial 2.6063s 2.5416s 0.3934 Ops/s 0.3847 Ops/s $\color{#35bf28}+2.28\%$
test_parallel 2.5706s 2.5167s 0.3973 Ops/s 0.4000 Ops/s $\color{#d91a1a}-0.66\%$
test_step_mdp_speed[True-True-True-True-True] 70.0310μs 33.5807μs 29.7790 KOps/s 29.2841 KOps/s $\color{#35bf28}+1.69\%$
test_step_mdp_speed[True-True-True-True-False] 39.5000μs 20.0144μs 49.9639 KOps/s 50.8055 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-True-True-False-True] 36.9210μs 19.4797μs 51.3355 KOps/s 52.2460 KOps/s $\color{#d91a1a}-1.74\%$
test_step_mdp_speed[True-True-True-False-False] 37.4310μs 11.4697μs 87.1866 KOps/s 87.5262 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[True-True-False-True-True] 55.4110μs 35.6959μs 28.0144 KOps/s 27.9191 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-True-False-True-False] 38.1000μs 21.9157μs 45.6293 KOps/s 45.9784 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[True-True-False-False-True] 50.7110μs 21.2231μs 47.1184 KOps/s 47.0460 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[True-True-False-False-False] 28.3410μs 13.4588μs 74.3006 KOps/s 74.1217 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[True-False-True-True-True] 53.9400μs 37.7165μs 26.5136 KOps/s 26.2055 KOps/s $\color{#35bf28}+1.18\%$
test_step_mdp_speed[True-False-True-True-False] 47.7210μs 23.9499μs 41.7538 KOps/s 41.8622 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-False-True-False-True] 39.0600μs 21.5573μs 46.3881 KOps/s 47.7953 KOps/s $\color{#d91a1a}-2.94\%$
test_step_mdp_speed[True-False-True-False-False] 32.2910μs 13.4981μs 74.0845 KOps/s 73.8551 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[True-False-False-True-True] 70.6310μs 38.5477μs 25.9419 KOps/s 25.0460 KOps/s $\color{#35bf28}+3.58\%$
test_step_mdp_speed[True-False-False-True-False] 52.4810μs 25.7161μs 38.8862 KOps/s 38.9768 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-False-False-False-True] 38.2300μs 22.7289μs 43.9969 KOps/s 44.0661 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-False-False-False-False] 31.6590μs 15.2825μs 65.4343 KOps/s 66.1854 KOps/s $\color{#d91a1a}-1.13\%$
test_step_mdp_speed[False-True-True-True-True] 56.0410μs 37.5409μs 26.6376 KOps/s 26.1098 KOps/s $\color{#35bf28}+2.02\%$
test_step_mdp_speed[False-True-True-True-False] 44.0410μs 23.8878μs 41.8624 KOps/s 42.2134 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[False-True-True-False-True] 41.2310μs 25.4888μs 39.2330 KOps/s 38.9723 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[False-True-True-False-False] 34.1810μs 15.3484μs 65.1534 KOps/s 65.9384 KOps/s $\color{#d91a1a}-1.19\%$
test_step_mdp_speed[False-True-False-True-True] 69.0710μs 39.5655μs 25.2745 KOps/s 24.9907 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[False-True-False-True-False] 44.7100μs 25.8275μs 38.7184 KOps/s 38.6689 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[False-True-False-False-True] 56.4100μs 26.8153μs 37.2921 KOps/s 37.2023 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[False-True-False-False-False] 32.8810μs 17.0706μs 58.5802 KOps/s 58.7945 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[False-False-True-True-True] 58.4700μs 40.9744μs 24.4055 KOps/s 24.5444 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[False-False-True-True-False] 52.8900μs 27.8910μs 35.8538 KOps/s 36.0363 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[False-False-True-False-True] 0.1028ms 27.0122μs 37.0204 KOps/s 37.1249 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-False-True-False-False] 37.2000μs 17.1362μs 58.3559 KOps/s 59.2443 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[False-False-False-True-True] 69.5010μs 42.3432μs 23.6166 KOps/s 22.9872 KOps/s $\color{#35bf28}+2.74\%$
test_step_mdp_speed[False-False-False-True-False] 44.2510μs 29.4850μs 33.9155 KOps/s 33.9183 KOps/s $-0.01\%$
test_step_mdp_speed[False-False-False-False-True] 61.5020μs 28.3678μs 35.2512 KOps/s 34.8780 KOps/s $\color{#35bf28}+1.07\%$
test_step_mdp_speed[False-False-False-False-False] 35.2410μs 18.8717μs 52.9893 KOps/s 53.4881 KOps/s $\color{#d91a1a}-0.93\%$
test_values[generalized_advantage_estimate-True-True] 26.8107ms 25.4081ms 39.3576 Ops/s 39.9371 Ops/s $\color{#d91a1a}-1.45\%$
test_values[vec_generalized_advantage_estimate-True-True] 92.3042ms 3.4177ms 292.5967 Ops/s 304.5850 Ops/s $\color{#d91a1a}-3.94\%$
test_values[td0_return_estimate-False-False] 95.7920μs 64.4538μs 15.5150 KOps/s 15.8869 KOps/s $\color{#d91a1a}-2.34\%$
test_values[td1_return_estimate-False-False] 54.6732ms 54.1074ms 18.4818 Ops/s 18.6131 Ops/s $\color{#d91a1a}-0.71\%$
test_values[vec_td1_return_estimate-False-False] 2.0051ms 1.7695ms 565.1213 Ops/s 564.1692 Ops/s $\color{#35bf28}+0.17\%$
test_values[td_lambda_return_estimate-True-False] 88.4766ms 86.1552ms 11.6070 Ops/s 11.7122 Ops/s $\color{#d91a1a}-0.90\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0254ms 1.7686ms 565.4163 Ops/s 565.6875 Ops/s $\color{#d91a1a}-0.05\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.7770ms 23.5651ms 42.4356 Ops/s 42.1594 Ops/s $\color{#35bf28}+0.66\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8558ms 0.7116ms 1.4052 KOps/s 1.4023 KOps/s $\color{#35bf28}+0.20\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7278ms 0.6628ms 1.5087 KOps/s 1.5175 KOps/s $\color{#d91a1a}-0.58\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4985ms 1.4657ms 682.2737 Ops/s 682.2766 Ops/s $-0.00\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9475ms 0.6829ms 1.4643 KOps/s 1.4702 KOps/s $\color{#d91a1a}-0.40\%$
test_dqn_speed 14.2574ms 7.5034ms 133.2724 Ops/s 130.5408 Ops/s $\color{#35bf28}+2.09\%$
test_ddpg_speed 15.5124ms 14.7428ms 67.8297 Ops/s 61.4642 Ops/s $\textbf{\color{#35bf28}+10.36\%}$
test_sac_speed 30.4657ms 29.7496ms 33.6139 Ops/s 33.0510 Ops/s $\color{#35bf28}+1.70\%$
test_redq_speed 36.0945ms 35.4477ms 28.2106 Ops/s 27.9779 Ops/s $\color{#35bf28}+0.83\%$
test_redq_deprec_speed 25.4659ms 24.6133ms 40.6285 Ops/s 40.1457 Ops/s $\color{#35bf28}+1.20\%$
test_td3_speed 29.4336ms 20.2619ms 49.3537 Ops/s 48.8800 Ops/s $\color{#35bf28}+0.97\%$
test_cql_speed 86.3598ms 85.3857ms 11.7116 Ops/s 11.7092 Ops/s $\color{#35bf28}+0.02\%$
test_a2c_speed 28.1950ms 27.3586ms 36.5516 Ops/s 36.3618 Ops/s $\color{#35bf28}+0.52\%$
test_ppo_speed 28.4660ms 27.5806ms 36.2574 Ops/s 35.9151 Ops/s $\color{#35bf28}+0.95\%$
test_reinforce_speed 27.3810ms 26.3995ms 37.8795 Ops/s 37.6126 Ops/s $\color{#35bf28}+0.71\%$
test_iql_speed 59.3171ms 58.4114ms 17.1199 Ops/s 16.9430 Ops/s $\color{#35bf28}+1.04\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3439ms 1.9305ms 517.9907 Ops/s 516.3365 Ops/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.2336ms 0.8451ms 1.1833 KOps/s 1.1851 KOps/s $\color{#d91a1a}-0.16\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.0081ms 0.8321ms 1.2018 KOps/s 1.2019 KOps/s $-0.01\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4599ms 1.9074ms 524.2691 Ops/s 525.7959 Ops/s $\color{#d91a1a}-0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.0982ms 0.8345ms 1.1983 KOps/s 1.1996 KOps/s $\color{#d91a1a}-0.10\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9747ms 0.8218ms 1.2169 KOps/s 1.2178 KOps/s $\color{#d91a1a}-0.08\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.4273ms 2.2100ms 452.4890 Ops/s 451.4570 Ops/s $\color{#35bf28}+0.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.5486ms 0.9679ms 1.0331 KOps/s 1.0356 KOps/s $\color{#d91a1a}-0.24\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0800ms 0.9545ms 1.0477 KOps/s 1.0474 KOps/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6491ms 1.9419ms 514.9521 Ops/s 511.7647 Ops/s $\color{#35bf28}+0.62\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.1990ms 0.8475ms 1.1800 KOps/s 1.1865 KOps/s $\color{#d91a1a}-0.55\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9773ms 0.8358ms 1.1964 KOps/s 1.2020 KOps/s $\color{#d91a1a}-0.46\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.0440ms 1.9127ms 522.8250 Ops/s 521.4038 Ops/s $\color{#35bf28}+0.27\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1456s 1.0324ms 968.6336 Ops/s 1.2021 KOps/s $\textbf{\color{#d91a1a}-19.42\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 1.0351ms 0.8240ms 1.2135 KOps/s 1.2080 KOps/s $\color{#35bf28}+0.46\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0605ms 2.1856ms 457.5307 Ops/s 450.7084 Ops/s $\color{#35bf28}+1.51\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0887ms 0.9653ms 1.0360 KOps/s 1.0353 KOps/s $\color{#35bf28}+0.07\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.1249ms 0.9562ms 1.0458 KOps/s 1.0382 KOps/s $\color{#35bf28}+0.73\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1313s 18.0252ms 55.4777 Ops/s 62.1368 Ops/s $\textbf{\color{#d91a1a}-10.72\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.7322ms 12.8019ms 78.1131 Ops/s 66.9961 Ops/s $\textbf{\color{#35bf28}+16.59\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.6408ms 1.9124ms 522.9004 Ops/s 511.7577 Ops/s $\color{#35bf28}+2.18\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1335s 18.0886ms 55.2834 Ops/s 64.6239 Ops/s $\textbf{\color{#d91a1a}-14.45\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.0714ms 12.8093ms 78.0683 Ops/s 79.1134 Ops/s $\color{#d91a1a}-1.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.5896ms 1.8584ms 538.0928 Ops/s 525.3358 Ops/s $\color{#35bf28}+2.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1241s 17.9931ms 55.5769 Ops/s 55.8528 Ops/s $\color{#d91a1a}-0.49\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.8715ms 13.0594ms 76.5732 Ops/s 78.5007 Ops/s $\color{#d91a1a}-2.46\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7456ms 2.0020ms 499.4979 Ops/s 491.9723 Ops/s $\color{#35bf28}+1.53\%$

@vmoens vmoens merged commit 06d5ffc into main Jan 8, 2024
60 of 64 checks passed
@vmoens vmoens deleted the fix-openmp-error branch January 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants