Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] state typo in RNG control module #1878

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[BugFix] state typo in RNG control module #1878

merged 1 commit into from
Feb 6, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 6, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1878

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (19 Unrelated Failures)

As of commit d8d1cac with merge base eec9f9e (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2024
@vmoens vmoens merged commit ff3a350 into main Feb 6, 2024
34 of 53 checks passed
@vmoens vmoens deleted the vmoens-patch-2 branch February 6, 2024 09:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}17$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1271s 65.1417ms 15.3512 Ops/s 15.8606 Ops/s $\color{#d91a1a}-3.21\%$
test_sync 34.7805ms 32.9509ms 30.3482 Ops/s 28.8927 Ops/s $\textbf{\color{#35bf28}+5.04\%}$
test_async 64.6300ms 32.8860ms 30.4081 Ops/s 29.9492 Ops/s $\color{#35bf28}+1.53\%$
test_simple 0.4915s 0.4299s 2.3261 Ops/s 2.2720 Ops/s $\color{#35bf28}+2.38\%$
test_transformed 0.6430s 0.5877s 1.7014 Ops/s 1.6254 Ops/s $\color{#35bf28}+4.67\%$
test_serial 1.4199s 1.3970s 0.7158 Ops/s 0.6819 Ops/s $\color{#35bf28}+4.98\%$
test_parallel 1.4005s 1.3534s 0.7389 Ops/s 0.6905 Ops/s $\textbf{\color{#35bf28}+7.01\%}$
test_step_mdp_speed[True-True-True-True-True] 0.1497ms 21.2669μs 47.0214 KOps/s 46.0432 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[True-True-True-True-False] 36.7490μs 12.9030μs 77.5013 KOps/s 77.2447 KOps/s $\color{#35bf28}+0.33\%$
test_step_mdp_speed[True-True-True-False-True] 50.4350μs 12.3273μs 81.1206 KOps/s 79.5717 KOps/s $\color{#35bf28}+1.95\%$
test_step_mdp_speed[True-True-True-False-False] 24.2960μs 7.4550μs 134.1390 KOps/s 132.5305 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[True-True-False-True-True] 0.1618ms 22.4008μs 44.6413 KOps/s 43.3491 KOps/s $\color{#35bf28}+2.98\%$
test_step_mdp_speed[True-True-False-True-False] 0.3086ms 14.7038μs 68.0095 KOps/s 69.5389 KOps/s $\color{#d91a1a}-2.20\%$
test_step_mdp_speed[True-True-False-False-True] 32.7910μs 13.5637μs 73.7261 KOps/s 72.0586 KOps/s $\color{#35bf28}+2.31\%$
test_step_mdp_speed[True-True-False-False-False] 34.9860μs 8.7310μs 114.5343 KOps/s 113.2440 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[True-False-True-True-True] 61.3250μs 23.7714μs 42.0673 KOps/s 40.8394 KOps/s $\color{#35bf28}+3.01\%$
test_step_mdp_speed[True-False-True-True-False] 56.4460μs 15.4318μs 64.8013 KOps/s 63.3204 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-False-True-False-True] 35.0960μs 13.6588μs 73.2128 KOps/s 71.7630 KOps/s $\color{#35bf28}+2.02\%$
test_step_mdp_speed[True-False-True-False-False] 33.3620μs 8.7883μs 113.7879 KOps/s 113.1321 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[True-False-False-True-True] 63.4190μs 24.7495μs 40.4048 KOps/s 38.9382 KOps/s $\color{#35bf28}+3.77\%$
test_step_mdp_speed[True-False-False-True-False] 40.8860μs 16.6105μs 60.2028 KOps/s 59.4017 KOps/s $\color{#35bf28}+1.35\%$
test_step_mdp_speed[True-False-False-False-True] 57.2770μs 14.8059μs 67.5406 KOps/s 66.1375 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[True-False-False-False-False] 48.0800μs 9.8307μs 101.7226 KOps/s 99.3754 KOps/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[False-True-True-True-True] 57.9880μs 23.9102μs 41.8232 KOps/s 41.1904 KOps/s $\color{#35bf28}+1.54\%$
test_step_mdp_speed[False-True-True-True-False] 55.4240μs 15.4762μs 64.6152 KOps/s 62.8392 KOps/s $\color{#35bf28}+2.83\%$
test_step_mdp_speed[False-True-True-False-True] 46.2670μs 15.7551μs 63.4716 KOps/s 61.9960 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-True-True-False-False] 44.2620μs 9.9307μs 100.6974 KOps/s 98.7955 KOps/s $\color{#35bf28}+1.93\%$
test_step_mdp_speed[False-True-False-True-True] 76.2430μs 24.9610μs 40.0625 KOps/s 39.8585 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[False-True-False-True-False] 64.2000μs 16.6599μs 60.0243 KOps/s 59.5733 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[False-True-False-False-True] 61.5240μs 17.1008μs 58.4767 KOps/s 58.5998 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[False-True-False-False-False] 31.8990μs 11.2127μs 89.1850 KOps/s 89.1835 KOps/s $+0.00\%$
test_step_mdp_speed[False-False-True-True-True] 65.4330μs 26.2572μs 38.0848 KOps/s 37.3151 KOps/s $\color{#35bf28}+2.06\%$
test_step_mdp_speed[False-False-True-True-False] 55.9040μs 17.8783μs 55.9339 KOps/s 54.3700 KOps/s $\color{#35bf28}+2.88\%$
test_step_mdp_speed[False-False-True-False-True] 70.2210μs 16.9269μs 59.0775 KOps/s 58.2271 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[False-False-True-False-False] 54.2720μs 11.1996μs 89.2887 KOps/s 87.2115 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-False-False-True-True] 0.1038ms 27.1991μs 36.7659 KOps/s 35.9624 KOps/s $\color{#35bf28}+2.23\%$
test_step_mdp_speed[False-False-False-True-False] 61.5350μs 18.8408μs 53.0764 KOps/s 52.2418 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[False-False-False-False-True] 59.7120μs 17.8101μs 56.1480 KOps/s 55.0540 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[False-False-False-False-False] 37.8410μs 12.1440μs 82.3454 KOps/s 80.5913 KOps/s $\color{#35bf28}+2.18\%$
test_values[generalized_advantage_estimate-True-True] 9.4447ms 9.1933ms 108.7748 Ops/s 101.1917 Ops/s $\textbf{\color{#35bf28}+7.49\%}$
test_values[vec_generalized_advantage_estimate-True-True] 36.5517ms 34.0667ms 29.3542 Ops/s 27.7318 Ops/s $\textbf{\color{#35bf28}+5.85\%}$
test_values[td0_return_estimate-False-False] 0.2251ms 0.1632ms 6.1266 KOps/s 5.0110 KOps/s $\textbf{\color{#35bf28}+22.26\%}$
test_values[td1_return_estimate-False-False] 25.3202ms 22.7313ms 43.9921 Ops/s 41.8400 Ops/s $\textbf{\color{#35bf28}+5.14\%}$
test_values[vec_td1_return_estimate-False-False] 35.6787ms 33.8839ms 29.5126 Ops/s 27.7458 Ops/s $\textbf{\color{#35bf28}+6.37\%}$
test_values[td_lambda_return_estimate-True-False] 35.9423ms 32.9776ms 30.3236 Ops/s 28.9520 Ops/s $\color{#35bf28}+4.74\%$
test_values[vec_td_lambda_return_estimate-True-False] 39.7227ms 33.9074ms 29.4921 Ops/s 27.8439 Ops/s $\textbf{\color{#35bf28}+5.92\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.3640ms 7.9991ms 125.0135 Ops/s 122.8721 Ops/s $\color{#35bf28}+1.74\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3474ms 1.8672ms 535.5471 Ops/s 511.3288 Ops/s $\color{#35bf28}+4.74\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4062ms 0.3375ms 2.9628 KOps/s 2.8391 KOps/s $\color{#35bf28}+4.36\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 45.2248ms 43.6233ms 22.9235 Ops/s 21.7533 Ops/s $\textbf{\color{#35bf28}+5.38\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.6139ms 2.9981ms 333.5463 Ops/s 325.3311 Ops/s $\color{#35bf28}+2.53\%$
test_dqn_speed 79.3273ms 6.3523ms 157.4225 Ops/s 159.0927 Ops/s $\color{#d91a1a}-1.05\%$
test_ddpg_speed 12.6497ms 11.6195ms 86.0620 Ops/s 79.0365 Ops/s $\textbf{\color{#35bf28}+8.89\%}$
test_sac_speed 25.0459ms 24.0565ms 41.5688 Ops/s 34.2060 Ops/s $\textbf{\color{#35bf28}+21.52\%}$
test_redq_speed 15.6200ms 14.3030ms 69.9152 Ops/s 67.2850 Ops/s $\color{#35bf28}+3.91\%$
test_redq_deprec_speed 24.2602ms 21.7863ms 45.9004 Ops/s 41.2037 Ops/s $\textbf{\color{#35bf28}+11.40\%}$
test_td3_speed 27.3914ms 16.5680ms 60.3573 Ops/s 57.5128 Ops/s $\color{#35bf28}+4.95\%$
test_cql_speed 78.0315ms 74.6589ms 13.3943 Ops/s 13.5523 Ops/s $\color{#d91a1a}-1.17\%$
test_a2c_speed 23.5552ms 22.2606ms 44.9224 Ops/s 41.6061 Ops/s $\textbf{\color{#35bf28}+7.97\%}$
test_ppo_speed 23.5954ms 22.1280ms 45.1915 Ops/s 43.3244 Ops/s $\color{#35bf28}+4.31\%$
test_reinforce_speed 23.4818ms 21.3216ms 46.9008 Ops/s 47.1615 Ops/s $\color{#d91a1a}-0.55\%$
test_iql_speed 56.9119ms 55.6978ms 17.9540 Ops/s 18.0560 Ops/s $\color{#d91a1a}-0.56\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9765ms 2.6606ms 375.8601 Ops/s 390.5722 Ops/s $\color{#d91a1a}-3.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7432ms 0.4978ms 2.0090 KOps/s 2.0190 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8173ms 0.4696ms 2.1297 KOps/s 2.1325 KOps/s $\color{#d91a1a}-0.13\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9918ms 2.6961ms 370.9034 Ops/s 387.3805 Ops/s $\color{#d91a1a}-4.25\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.7629ms 0.5147ms 1.9428 KOps/s 2.0476 KOps/s $\textbf{\color{#d91a1a}-5.12\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7674ms 0.4676ms 2.1388 KOps/s 2.1281 KOps/s $\color{#35bf28}+0.50\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7374ms 2.4580ms 406.8342 Ops/s 426.7509 Ops/s $\color{#d91a1a}-4.67\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7210ms 0.6025ms 1.6597 KOps/s 1.6408 KOps/s $\color{#35bf28}+1.15\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8686ms 0.5856ms 1.7076 KOps/s 1.6823 KOps/s $\color{#35bf28}+1.50\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.1665ms 2.7006ms 370.2864 Ops/s 361.4443 Ops/s $\color{#35bf28}+2.45\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1843s 0.6973ms 1.4341 KOps/s 2.0054 KOps/s $\textbf{\color{#d91a1a}-28.49\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.1686ms 0.4765ms 2.0985 KOps/s 2.1343 KOps/s $\color{#d91a1a}-1.68\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.1855ms 2.6774ms 373.5014 Ops/s 379.8615 Ops/s $\color{#d91a1a}-1.67\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7800ms 0.4945ms 2.0221 KOps/s 2.0349 KOps/s $\color{#d91a1a}-0.63\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5829ms 0.4676ms 2.1387 KOps/s 2.1493 KOps/s $\color{#d91a1a}-0.49\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.7683ms 2.4941ms 400.9470 Ops/s 409.7515 Ops/s $\color{#d91a1a}-2.15\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9630ms 0.6153ms 1.6253 KOps/s 1.6308 KOps/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6951ms 0.5786ms 1.7283 KOps/s 1.6253 KOps/s $\textbf{\color{#35bf28}+6.34\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2196s 12.3384ms 81.0480 Ops/s 113.3190 Ops/s $\textbf{\color{#d91a1a}-28.48\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.6471ms 13.2792ms 75.3060 Ops/s 75.1722 Ops/s $\color{#35bf28}+0.18\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.4403ms 2.5195ms 396.9039 Ops/s 372.0374 Ops/s $\textbf{\color{#35bf28}+6.68\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2202s 8.4415ms 118.4621 Ops/s 106.6123 Ops/s $\textbf{\color{#35bf28}+11.11\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.0533ms 13.3720ms 74.7830 Ops/s 74.7704 Ops/s $\color{#35bf28}+0.02\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.1500ms 2.5387ms 393.9060 Ops/s 394.4621 Ops/s $\color{#d91a1a}-0.14\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2196s 8.6382ms 115.7646 Ops/s 118.0691 Ops/s $\color{#d91a1a}-1.95\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.4489ms 13.3575ms 74.8643 Ops/s 57.2189 Ops/s $\textbf{\color{#35bf28}+30.84\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 3.6295ms 2.6568ms 376.3953 Ops/s 363.6553 Ops/s $\color{#35bf28}+3.50\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

$\color{#35bf28}\textsf{\Large✔\kern{0.2cm}\normalsize OK}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}0$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1217s 0.1203s 8.3119 Ops/s 8.3053 Ops/s $\color{#35bf28}+0.08\%$
test_sync 98.0617ms 96.9008ms 10.3198 Ops/s 10.3643 Ops/s $\color{#d91a1a}-0.43\%$
test_async 0.2541s 91.4671ms 10.9329 Ops/s 10.8558 Ops/s $\color{#35bf28}+0.71\%$
test_single_pixels 0.1421s 0.1406s 7.1102 Ops/s 7.0969 Ops/s $\color{#35bf28}+0.19\%$
test_sync_pixels 84.1155ms 83.1366ms 12.0284 Ops/s 12.0438 Ops/s $\color{#d91a1a}-0.13\%$
test_async_pixels 0.2072s 77.3497ms 12.9283 Ops/s 13.2719 Ops/s $\color{#d91a1a}-2.59\%$
test_simple 0.9526s 0.8793s 1.1372 Ops/s 1.1550 Ops/s $\color{#d91a1a}-1.54\%$
test_transformed 1.1833s 1.1191s 0.8936 Ops/s 0.8854 Ops/s $\color{#35bf28}+0.93\%$
test_serial 2.5744s 2.5091s 0.3986 Ops/s 0.3954 Ops/s $\color{#35bf28}+0.79\%$
test_parallel 2.1985s 2.1295s 0.4696 Ops/s 0.4627 Ops/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[True-True-True-True-True] 60.4110μs 33.4989μs 29.8517 KOps/s 29.6816 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[True-True-True-True-False] 44.9300μs 19.5368μs 51.1854 KOps/s 50.7647 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-True-True-False-True] 37.6200μs 18.2557μs 54.7774 KOps/s 53.4343 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[True-True-True-False-False] 28.8210μs 11.0956μs 90.1262 KOps/s 88.5363 KOps/s $\color{#35bf28}+1.80\%$
test_step_mdp_speed[True-True-False-True-True] 61.2720μs 35.1241μs 28.4705 KOps/s 28.5102 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-True-False-True-False] 50.4600μs 21.3329μs 46.8759 KOps/s 45.9613 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[True-True-False-False-True] 56.0010μs 20.1911μs 49.5269 KOps/s 48.4614 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[True-True-False-False-False] 33.5710μs 13.0327μs 76.7301 KOps/s 76.0389 KOps/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[True-False-True-True-True] 92.3810μs 37.0436μs 26.9952 KOps/s 27.2001 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-False-True-True-False] 39.8700μs 23.5468μs 42.4685 KOps/s 42.5316 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-False-True-False-True] 45.4400μs 20.1275μs 49.6834 KOps/s 49.0902 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[True-False-True-False-False] 30.4200μs 12.9087μs 77.4671 KOps/s 75.1530 KOps/s $\color{#35bf28}+3.08\%$
test_step_mdp_speed[True-False-False-True-True] 62.4500μs 38.0261μs 26.2978 KOps/s 25.9531 KOps/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[True-False-False-True-False] 76.0210μs 25.0837μs 39.8665 KOps/s 39.3265 KOps/s $\color{#35bf28}+1.37\%$
test_step_mdp_speed[True-False-False-False-True] 53.4110μs 22.0437μs 45.3645 KOps/s 44.3449 KOps/s $\color{#35bf28}+2.30\%$
test_step_mdp_speed[True-False-False-False-False] 44.2410μs 14.8743μs 67.2301 KOps/s 66.5139 KOps/s $\color{#35bf28}+1.08\%$
test_step_mdp_speed[False-True-True-True-True] 62.9710μs 37.0556μs 26.9865 KOps/s 27.3140 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[False-True-True-True-False] 63.4900μs 23.2307μs 43.0465 KOps/s 42.3781 KOps/s $\color{#35bf28}+1.58\%$
test_step_mdp_speed[False-True-True-False-True] 52.0700μs 24.3208μs 41.1171 KOps/s 40.0533 KOps/s $\color{#35bf28}+2.66\%$
test_step_mdp_speed[False-True-True-False-False] 50.7610μs 14.7427μs 67.8302 KOps/s 67.0534 KOps/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[False-True-False-True-True] 73.8710μs 38.9062μs 25.7028 KOps/s 25.9286 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-True-False-True-False] 0.2077ms 25.2265μs 39.6409 KOps/s 39.2562 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[False-True-False-False-True] 47.4810μs 26.5985μs 37.5961 KOps/s 37.5268 KOps/s $\color{#35bf28}+0.18\%$
test_step_mdp_speed[False-True-False-False-False] 33.3400μs 16.9395μs 59.0336 KOps/s 59.6843 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[False-False-True-True-True] 57.7010μs 40.0908μs 24.9434 KOps/s 24.9871 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[False-False-True-True-False] 88.7110μs 27.2215μs 36.7356 KOps/s 36.4828 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[False-False-True-False-True] 53.5910μs 26.1353μs 38.2624 KOps/s 37.7775 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[False-False-True-False-False] 32.8310μs 16.7582μs 59.6722 KOps/s 59.6990 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-False-False-True-True] 62.5710μs 42.3405μs 23.6180 KOps/s 23.9523 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[False-False-False-True-False] 45.2900μs 29.0725μs 34.3968 KOps/s 34.5389 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-False-False-False-True] 49.3510μs 27.9341μs 35.7985 KOps/s 35.6479 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-False-False-False-False] 37.4300μs 18.3999μs 54.3480 KOps/s 54.5447 KOps/s $\color{#d91a1a}-0.36\%$
test_values[generalized_advantage_estimate-True-True] 26.4058ms 25.7456ms 38.8415 Ops/s 38.6616 Ops/s $\color{#35bf28}+0.47\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.3458ms 3.2457ms 308.0969 Ops/s 296.4649 Ops/s $\color{#35bf28}+3.92\%$
test_values[td0_return_estimate-False-False] 0.2053ms 67.2033μs 14.8802 KOps/s 15.1459 KOps/s $\color{#d91a1a}-1.75\%$
test_values[td1_return_estimate-False-False] 59.1660ms 57.8825ms 17.2764 Ops/s 17.4976 Ops/s $\color{#d91a1a}-1.26\%$
test_values[vec_td1_return_estimate-False-False] 2.0542ms 1.7903ms 558.5521 Ops/s 560.0580 Ops/s $\color{#d91a1a}-0.27\%$
test_values[td_lambda_return_estimate-True-False] 93.9536ms 89.4910ms 11.1743 Ops/s 11.3183 Ops/s $\color{#d91a1a}-1.27\%$
test_values[vec_td_lambda_return_estimate-True-False] 4.1912ms 1.8515ms 540.0907 Ops/s 548.4790 Ops/s $\color{#d91a1a}-1.53\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 26.3703ms 25.9088ms 38.5970 Ops/s 39.5288 Ops/s $\color{#d91a1a}-2.36\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9021ms 0.7287ms 1.3723 KOps/s 1.3902 KOps/s $\color{#d91a1a}-1.29\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8543ms 0.7046ms 1.4192 KOps/s 1.4867 KOps/s $\color{#d91a1a}-4.54\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6518ms 1.4907ms 670.8333 Ops/s 680.6342 Ops/s $\color{#d91a1a}-1.44\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9920ms 0.7214ms 1.3863 KOps/s 1.4467 KOps/s $\color{#d91a1a}-4.18\%$
test_dqn_speed 16.5726ms 7.6382ms 130.9202 Ops/s 129.3726 Ops/s $\color{#35bf28}+1.20\%$
test_ddpg_speed 15.5726ms 14.5369ms 68.7906 Ops/s 68.0036 Ops/s $\color{#35bf28}+1.16\%$
test_sac_speed 29.7476ms 29.1671ms 34.2852 Ops/s 30.9741 Ops/s $\textbf{\color{#35bf28}+10.69\%}$
test_redq_speed 15.0287ms 11.7664ms 84.9879 Ops/s 85.2733 Ops/s $\color{#d91a1a}-0.33\%$
test_redq_deprec_speed 24.1703ms 23.2395ms 43.0302 Ops/s 43.2230 Ops/s $\color{#d91a1a}-0.45\%$
test_td3_speed 31.4810ms 19.4684ms 51.3654 Ops/s 50.1439 Ops/s $\color{#35bf28}+2.44\%$
test_cql_speed 77.7232ms 76.1757ms 13.1275 Ops/s 12.9196 Ops/s $\color{#35bf28}+1.61\%$
test_a2c_speed 26.8985ms 25.3286ms 39.4811 Ops/s 38.8157 Ops/s $\color{#35bf28}+1.71\%$
test_ppo_speed 26.2786ms 25.5576ms 39.1273 Ops/s 38.6905 Ops/s $\color{#35bf28}+1.13\%$
test_reinforce_speed 25.4120ms 24.3053ms 41.1434 Ops/s 40.3431 Ops/s $\color{#35bf28}+1.98\%$
test_iql_speed 51.9088ms 50.8122ms 19.6803 Ops/s 19.4027 Ops/s $\color{#35bf28}+1.43\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8398ms 3.6630ms 273.0024 Ops/s 276.1997 Ops/s $\color{#d91a1a}-1.16\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7420ms 0.5634ms 1.7750 KOps/s 1.7893 KOps/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7416ms 0.5314ms 1.8817 KOps/s 1.8891 KOps/s $\color{#d91a1a}-0.40\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9127ms 3.6484ms 274.0895 Ops/s 276.7693 Ops/s $\color{#d91a1a}-0.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7620ms 0.5589ms 1.7893 KOps/s 1.7934 KOps/s $\color{#d91a1a}-0.23\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7119ms 0.5284ms 1.8924 KOps/s 1.8951 KOps/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4975ms 3.3203ms 301.1739 Ops/s 300.6080 Ops/s $\color{#35bf28}+0.19\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8792ms 0.6890ms 1.4513 KOps/s 1.4464 KOps/s $\color{#35bf28}+0.34\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8318ms 0.6585ms 1.5187 KOps/s 1.5120 KOps/s $\color{#35bf28}+0.44\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8154ms 3.6017ms 277.6479 Ops/s 274.0332 Ops/s $\color{#35bf28}+1.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7232ms 0.5595ms 1.7873 KOps/s 1.7868 KOps/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7179ms 0.5318ms 1.8803 KOps/s 1.8847 KOps/s $\color{#d91a1a}-0.24\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9901ms 3.6923ms 270.8322 Ops/s 273.9414 Ops/s $\color{#d91a1a}-1.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7402ms 0.5585ms 1.7905 KOps/s 1.7930 KOps/s $\color{#d91a1a}-0.14\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6881ms 0.5308ms 1.8840 KOps/s 1.8916 KOps/s $\color{#d91a1a}-0.40\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5229ms 3.3261ms 300.6539 Ops/s 299.0621 Ops/s $\color{#35bf28}+0.53\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8751ms 0.6907ms 1.4477 KOps/s 1.4479 KOps/s $-0.01\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8227ms 0.6605ms 1.5140 KOps/s 1.5080 KOps/s $\color{#35bf28}+0.40\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2114s 13.6216ms 73.4128 Ops/s 72.9005 Ops/s $\color{#35bf28}+0.70\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 19.0401ms 16.7787ms 59.5992 Ops/s 60.0522 Ops/s $\color{#d91a1a}-0.75\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.3012ms 3.1396ms 318.5139 Ops/s 325.9685 Ops/s $\color{#d91a1a}-2.29\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2068s 9.6231ms 103.9162 Ops/s 104.3014 Ops/s $\color{#d91a1a}-0.37\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.9309ms 16.6936ms 59.9032 Ops/s 59.7647 Ops/s $\color{#35bf28}+0.23\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.7848ms 3.0586ms 326.9446 Ops/s 325.5392 Ops/s $\color{#35bf28}+0.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2051s 9.7741ms 102.3113 Ops/s 102.8934 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.9780ms 16.8625ms 59.3032 Ops/s 59.8580 Ops/s $\color{#d91a1a}-0.93\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.9237ms 3.2977ms 303.2431 Ops/s 302.0077 Ops/s $\color{#35bf28}+0.41\%$

vmoens added a commit that referenced this pull request Feb 6, 2024
@vmoens
[BugFix] state typo in RNG control module (#1878)
898f6ec
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot