Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fixes sympy error by fixing mpmath version #1988

Merged
merged 4 commits into from
Mar 4, 2024
Merged

[CI] Fixes sympy error by fixing mpmath version #1988

merged 4 commits into from
Mar 4, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 4, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1988

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 21 Unrelated Failures

As of commit 7acb322 with merge base 3a41f40 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2024
@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Mar 4, 2024
@vmoens vmoens marked this pull request as ready for review March 4, 2024 08:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 60.7089ms 60.2561ms 16.5958 Ops/s 16.8141 Ops/s $\color{#d91a1a}-1.30\%$
test_sync 39.0266ms 33.4130ms 29.9285 Ops/s 30.1245 Ops/s $\color{#d91a1a}-0.65\%$
test_async 61.9063ms 29.5391ms 33.8535 Ops/s 30.8262 Ops/s $\textbf{\color{#35bf28}+9.82\%}$
test_simple 0.4660s 0.4174s 2.3958 Ops/s 2.4273 Ops/s $\color{#d91a1a}-1.30\%$
test_transformed 0.6249s 0.5713s 1.7503 Ops/s 1.7777 Ops/s $\color{#d91a1a}-1.54\%$
test_serial 1.4266s 1.3817s 0.7237 Ops/s 0.7397 Ops/s $\color{#d91a1a}-2.16\%$
test_parallel 1.4048s 1.3334s 0.7500 Ops/s 0.7441 Ops/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-True-True-True-True] 0.2255ms 21.1326μs 47.3203 KOps/s 46.7113 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[True-True-True-True-False] 50.1630μs 13.1736μs 75.9097 KOps/s 75.4635 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[True-True-True-False-True] 58.3690μs 12.5639μs 79.5931 KOps/s 79.3086 KOps/s $\color{#35bf28}+0.36\%$
test_step_mdp_speed[True-True-True-False-False] 27.6210μs 7.6151μs 131.3177 KOps/s 131.6682 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[True-True-False-True-True] 46.4770μs 23.0003μs 43.4777 KOps/s 44.3449 KOps/s $\color{#d91a1a}-1.96\%$
test_step_mdp_speed[True-True-False-True-False] 55.6230μs 14.4377μs 69.2633 KOps/s 69.2310 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[True-True-False-False-True] 44.9230μs 13.8022μs 72.4524 KOps/s 72.2448 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-True-False-False-False] 31.4890μs 8.9101μs 112.2322 KOps/s 112.0363 KOps/s $\color{#35bf28}+0.17\%$
test_step_mdp_speed[True-False-True-True-True] 53.3890μs 24.3928μs 40.9958 KOps/s 41.5160 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-False-True-True-False] 57.7780μs 16.1167μs 62.0475 KOps/s 63.6749 KOps/s $\color{#d91a1a}-2.56\%$
test_step_mdp_speed[True-False-True-False-True] 38.8930μs 13.6266μs 73.3861 KOps/s 73.2230 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-False-True-False-False] 45.9360μs 8.9145μs 112.1768 KOps/s 112.8256 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[True-False-False-True-True] 51.2050μs 25.2727μs 39.5684 KOps/s 39.4348 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-False-False-True-False] 41.5870μs 16.7706μs 59.6283 KOps/s 58.2753 KOps/s $\color{#35bf28}+2.32\%$
test_step_mdp_speed[True-False-False-False-True] 81.5150μs 14.8940μs 67.1409 KOps/s 67.7208 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-False-False-False-False] 43.8520μs 10.1220μs 98.7948 KOps/s 99.5005 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-True-True-True-True] 53.2490μs 24.1585μs 41.3932 KOps/s 41.3321 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[False-True-True-True-False] 51.4660μs 15.8806μs 62.9697 KOps/s 63.5552 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-True-True-False-True] 39.4130μs 16.1454μs 61.9371 KOps/s 61.9536 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[False-True-True-False-False] 45.2940μs 10.1123μs 98.8894 KOps/s 98.6355 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-True-False-True-True] 49.1420μs 25.8833μs 38.6350 KOps/s 38.9835 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-True-False-True-False] 42.6390μs 16.9947μs 58.8419 KOps/s 58.3003 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-True-False-False-True] 56.0750μs 17.3953μs 57.4866 KOps/s 57.0349 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[False-True-False-False-False] 60.9340μs 11.3643μs 87.9948 KOps/s 88.9616 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[False-False-True-True-True] 64.2400μs 26.7099μs 37.4393 KOps/s 37.6767 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[False-False-True-True-False] 51.3160μs 18.2224μs 54.8776 KOps/s 54.2416 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[False-False-True-False-True] 44.0820μs 17.1813μs 58.2027 KOps/s 57.3664 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[False-False-True-False-False] 45.2040μs 11.4187μs 87.5756 KOps/s 88.2551 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-False-False-True-True] 59.5710μs 27.7747μs 36.0040 KOps/s 35.9984 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[False-False-False-True-False] 50.4140μs 19.4605μs 51.3861 KOps/s 51.2751 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[False-False-False-False-True] 43.9920μs 18.2686μs 54.7386 KOps/s 53.9626 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[False-False-False-False-False] 47.0980μs 12.4568μs 80.2773 KOps/s 80.5879 KOps/s $\color{#d91a1a}-0.39\%$
test_values[generalized_advantage_estimate-True-True] 10.2984ms 9.2672ms 107.9079 Ops/s 106.6998 Ops/s $\color{#35bf28}+1.13\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.9421ms 33.1355ms 30.1791 Ops/s 29.9951 Ops/s $\color{#35bf28}+0.61\%$
test_values[td0_return_estimate-False-False] 0.2330ms 0.1801ms 5.5520 KOps/s 6.1326 KOps/s $\textbf{\color{#d91a1a}-9.47\%}$
test_values[td1_return_estimate-False-False] 23.9590ms 23.6117ms 42.3518 Ops/s 43.0560 Ops/s $\color{#d91a1a}-1.64\%$
test_values[vec_td1_return_estimate-False-False] 34.6894ms 33.3011ms 30.0291 Ops/s 30.0470 Ops/s $\color{#d91a1a}-0.06\%$
test_values[td_lambda_return_estimate-True-False] 36.9227ms 34.2722ms 29.1781 Ops/s 29.8015 Ops/s $\color{#d91a1a}-2.09\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.7892ms 33.1001ms 30.2114 Ops/s 30.0922 Ops/s $\color{#35bf28}+0.40\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.6790ms 8.2221ms 121.6235 Ops/s 121.4087 Ops/s $\color{#35bf28}+0.18\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2126ms 1.9514ms 512.4553 Ops/s 493.6201 Ops/s $\color{#35bf28}+3.82\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4259ms 0.3500ms 2.8569 KOps/s 2.8368 KOps/s $\color{#35bf28}+0.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 44.1658ms 41.3016ms 24.2121 Ops/s 23.8817 Ops/s $\color{#35bf28}+1.38\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.9202ms 3.1512ms 317.3422 Ops/s 326.6361 Ops/s $\color{#d91a1a}-2.85\%$
test_dqn_speed 6.7175ms 1.3535ms 738.8111 Ops/s 745.9491 Ops/s $\color{#d91a1a}-0.96\%$
test_ddpg_speed 2.8394ms 2.6754ms 373.7719 Ops/s 376.8097 Ops/s $\color{#d91a1a}-0.81\%$
test_sac_speed 9.7889ms 8.1962ms 122.0074 Ops/s 123.3212 Ops/s $\color{#d91a1a}-1.07\%$
test_redq_speed 13.8892ms 13.0338ms 76.7238 Ops/s 77.7140 Ops/s $\color{#d91a1a}-1.27\%$
test_redq_deprec_speed 14.8721ms 13.1292ms 76.1660 Ops/s 77.5197 Ops/s $\color{#d91a1a}-1.75\%$
test_td3_speed 15.5365ms 8.1891ms 122.1131 Ops/s 124.5587 Ops/s $\color{#d91a1a}-1.96\%$
test_cql_speed 38.1040ms 35.9373ms 27.8262 Ops/s 27.8866 Ops/s $\color{#d91a1a}-0.22\%$
test_a2c_speed 8.6244ms 7.3820ms 135.4645 Ops/s 136.8120 Ops/s $\color{#d91a1a}-0.98\%$
test_ppo_speed 8.3342ms 7.6189ms 131.2518 Ops/s 131.6424 Ops/s $\color{#d91a1a}-0.30\%$
test_reinforce_speed 7.4303ms 6.5450ms 152.7892 Ops/s 153.9887 Ops/s $\color{#d91a1a}-0.78\%$
test_iql_speed 34.1221ms 32.4582ms 30.8089 Ops/s 28.6014 Ops/s $\textbf{\color{#35bf28}+7.72\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3023ms 2.2733ms 439.8881 Ops/s 440.6037 Ops/s $\color{#d91a1a}-0.16\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0029ms 0.4920ms 2.0325 KOps/s 2.0317 KOps/s $\color{#35bf28}+0.04\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7055ms 0.4689ms 2.1325 KOps/s 2.1433 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5662ms 2.3476ms 425.9702 Ops/s 436.5188 Ops/s $\color{#d91a1a}-2.42\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0128ms 0.4881ms 2.0488 KOps/s 1.9544 KOps/s $\color{#35bf28}+4.83\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6310ms 0.4568ms 2.1890 KOps/s 2.1844 KOps/s $\color{#35bf28}+0.21\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3628ms 2.3797ms 420.2278 Ops/s 428.8246 Ops/s $\color{#d91a1a}-2.00\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1531ms 0.6103ms 1.6385 KOps/s 1.6672 KOps/s $\color{#d91a1a}-1.72\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8999ms 0.5844ms 1.7112 KOps/s 1.7314 KOps/s $\color{#d91a1a}-1.16\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3279ms 2.2767ms 439.2266 Ops/s 452.9659 Ops/s $\color{#d91a1a}-3.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0810ms 0.4933ms 2.0271 KOps/s 2.0598 KOps/s $\color{#d91a1a}-1.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7063ms 0.4723ms 2.1174 KOps/s 2.1197 KOps/s $\color{#d91a1a}-0.11\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6496ms 2.2437ms 445.6968 Ops/s 446.2516 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.5899ms 0.4892ms 2.0442 KOps/s 2.0825 KOps/s $\color{#d91a1a}-1.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6124ms 0.4674ms 2.1396 KOps/s 2.1866 KOps/s $\color{#d91a1a}-2.15\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5022ms 2.4649ms 405.6989 Ops/s 424.8333 Ops/s $\color{#d91a1a}-4.50\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8914ms 0.6107ms 1.6374 KOps/s 1.6486 KOps/s $\color{#d91a1a}-0.68\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7163ms 0.5825ms 1.7166 KOps/s 1.7238 KOps/s $\color{#d91a1a}-0.41\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 90.9686ms 7.0747ms 141.3478 Ops/s 145.7682 Ops/s $\color{#d91a1a}-3.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.1977ms 12.0268ms 83.1479 Ops/s 84.1318 Ops/s $\color{#d91a1a}-1.17\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.0852ms 1.0096ms 990.5098 Ops/s 993.1763 Ops/s $\color{#d91a1a}-0.27\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 83.8340ms 6.7383ms 148.4062 Ops/s 191.4177 Ops/s $\textbf{\color{#d91a1a}-22.47\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.5656ms 12.0102ms 83.2622 Ops/s 84.1617 Ops/s $\color{#d91a1a}-1.07\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.8569ms 1.0963ms 912.1195 Ops/s 982.0534 Ops/s $\textbf{\color{#d91a1a}-7.12\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 92.0452ms 5.7845ms 172.8758 Ops/s 135.3906 Ops/s $\textbf{\color{#35bf28}+27.69\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.7889ms 12.3890ms 80.7166 Ops/s 81.3058 Ops/s $\color{#d91a1a}-0.72\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1659ms 1.3820ms 723.5988 Ops/s 759.4105 Ops/s $\color{#d91a1a}-4.72\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1113s 0.1112s 8.9963 Ops/s 8.9200 Ops/s $\color{#35bf28}+0.85\%$
test_sync 95.4572ms 95.1031ms 10.5149 Ops/s 10.5034 Ops/s $\color{#35bf28}+0.11\%$
test_async 0.1854s 92.7928ms 10.7767 Ops/s 10.7557 Ops/s $\color{#35bf28}+0.19\%$
test_single_pixels 0.1919s 0.1294s 7.7296 Ops/s 8.1783 Ops/s $\textbf{\color{#d91a1a}-5.49\%}$
test_sync_pixels 82.0454ms 80.8709ms 12.3654 Ops/s 12.5729 Ops/s $\color{#d91a1a}-1.65\%$
test_async_pixels 0.1477s 64.8990ms 15.4086 Ops/s 15.6968 Ops/s $\color{#d91a1a}-1.84\%$
test_simple 0.8681s 0.8099s 1.2347 Ops/s 1.2366 Ops/s $\color{#d91a1a}-0.15\%$
test_transformed 1.0852s 1.0271s 0.9736 Ops/s 0.9708 Ops/s $\color{#35bf28}+0.29\%$
test_serial 2.3906s 2.3294s 0.4293 Ops/s 0.4249 Ops/s $\color{#35bf28}+1.04\%$
test_parallel 2.1382s 2.0566s 0.4862 Ops/s 0.4822 Ops/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[True-True-True-True-True] 69.5120μs 32.1875μs 31.0679 KOps/s 30.2961 KOps/s $\color{#35bf28}+2.55\%$
test_step_mdp_speed[True-True-True-True-False] 44.0410μs 19.5145μs 51.2440 KOps/s 50.8431 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[True-True-True-False-True] 33.7210μs 18.3190μs 54.5881 KOps/s 53.3204 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[True-True-True-False-False] 32.6620μs 10.8923μs 91.8081 KOps/s 91.1957 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[True-True-False-True-True] 52.7010μs 33.9934μs 29.4175 KOps/s 29.0725 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[True-True-False-True-False] 36.6410μs 21.0536μs 47.4978 KOps/s 46.8420 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[True-True-False-False-True] 43.7800μs 20.2328μs 49.4246 KOps/s 48.8239 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-True-False-False-False] 37.5810μs 12.8576μs 77.7750 KOps/s 77.2928 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[True-False-True-True-True] 64.5620μs 35.7443μs 27.9765 KOps/s 27.1735 KOps/s $\color{#35bf28}+2.96\%$
test_step_mdp_speed[True-False-True-True-False] 37.9310μs 22.9318μs 43.6075 KOps/s 42.8197 KOps/s $\color{#35bf28}+1.84\%$
test_step_mdp_speed[True-False-True-False-True] 41.6210μs 19.9025μs 50.2449 KOps/s 48.6680 KOps/s $\color{#35bf28}+3.24\%$
test_step_mdp_speed[True-False-True-False-False] 29.8790μs 12.7144μs 78.6512 KOps/s 77.2185 KOps/s $\color{#35bf28}+1.86\%$
test_step_mdp_speed[True-False-False-True-True] 60.0220μs 37.1399μs 26.9253 KOps/s 26.2061 KOps/s $\color{#35bf28}+2.74\%$
test_step_mdp_speed[True-False-False-True-False] 47.5510μs 24.6417μs 40.5816 KOps/s 39.4888 KOps/s $\color{#35bf28}+2.77\%$
test_step_mdp_speed[True-False-False-False-True] 39.7220μs 21.5357μs 46.4345 KOps/s 44.2880 KOps/s $\color{#35bf28}+4.85\%$
test_step_mdp_speed[True-False-False-False-False] 38.2110μs 14.6460μs 68.2782 KOps/s 68.2412 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[False-True-True-True-True] 55.4000μs 35.7482μs 27.9734 KOps/s 27.4317 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[False-True-True-True-False] 48.1610μs 23.4042μs 42.7274 KOps/s 42.7452 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-True-True-False-True] 42.9100μs 24.0961μs 41.5005 KOps/s 41.0749 KOps/s $\color{#35bf28}+1.04\%$
test_step_mdp_speed[False-True-True-False-False] 39.8700μs 14.6334μs 68.3370 KOps/s 66.3775 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[False-True-False-True-True] 62.9810μs 38.3175μs 26.0977 KOps/s 25.7386 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[False-True-False-True-False] 47.0510μs 25.1754μs 39.7213 KOps/s 39.5567 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-True-False-False-True] 41.5810μs 25.7230μs 38.8757 KOps/s 38.2973 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[False-True-False-False-False] 37.6710μs 16.4524μs 60.7814 KOps/s 59.7935 KOps/s $\color{#35bf28}+1.65\%$
test_step_mdp_speed[False-False-True-True-True] 66.4810μs 39.9044μs 25.0599 KOps/s 24.8723 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[False-False-True-True-False] 46.7910μs 26.9391μs 37.1208 KOps/s 36.8281 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[False-False-True-False-True] 93.2220μs 25.7230μs 38.8757 KOps/s 37.7850 KOps/s $\color{#35bf28}+2.89\%$
test_step_mdp_speed[False-False-True-False-False] 33.1900μs 16.4862μs 60.6569 KOps/s 59.1251 KOps/s $\color{#35bf28}+2.59\%$
test_step_mdp_speed[False-False-False-True-True] 68.2110μs 40.9108μs 24.4434 KOps/s 23.7573 KOps/s $\color{#35bf28}+2.89\%$
test_step_mdp_speed[False-False-False-True-False] 52.8710μs 28.8548μs 34.6563 KOps/s 34.4568 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-False-False-False-True] 46.0210μs 27.1402μs 36.8457 KOps/s 36.2218 KOps/s $\color{#35bf28}+1.72\%$
test_step_mdp_speed[False-False-False-False-False] 31.9120μs 17.7990μs 56.1830 KOps/s 54.1143 KOps/s $\color{#35bf28}+3.82\%$
test_values[generalized_advantage_estimate-True-True] 26.1303ms 24.9707ms 40.0470 Ops/s 41.0767 Ops/s $\color{#d91a1a}-2.51\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.4279ms 3.2400ms 308.6430 Ops/s 305.5302 Ops/s $\color{#35bf28}+1.02\%$
test_values[td0_return_estimate-False-False] 0.1031ms 64.9829μs 15.3887 KOps/s 15.6723 KOps/s $\color{#d91a1a}-1.81\%$
test_values[td1_return_estimate-False-False] 53.9822ms 53.3927ms 18.7292 Ops/s 19.2967 Ops/s $\color{#d91a1a}-2.94\%$
test_values[vec_td1_return_estimate-False-False] 2.0892ms 1.7709ms 564.6750 Ops/s 568.4385 Ops/s $\color{#d91a1a}-0.66\%$
test_values[td_lambda_return_estimate-True-False] 88.0418ms 85.8037ms 11.6545 Ops/s 12.1095 Ops/s $\color{#d91a1a}-3.76\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1236ms 1.7696ms 565.0875 Ops/s 569.9817 Ops/s $\color{#d91a1a}-0.86\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.4901ms 23.5634ms 42.4386 Ops/s 43.5695 Ops/s $\color{#d91a1a}-2.60\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8666ms 0.7023ms 1.4239 KOps/s 1.4408 KOps/s $\color{#d91a1a}-1.17\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7387ms 0.6586ms 1.5184 KOps/s 1.5521 KOps/s $\color{#d91a1a}-2.17\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5099ms 1.4551ms 687.2599 Ops/s 692.8569 Ops/s $\color{#d91a1a}-0.81\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9409ms 0.6775ms 1.4760 KOps/s 1.5050 KOps/s $\color{#d91a1a}-1.93\%$
test_dqn_speed 8.1180ms 1.4133ms 707.5664 Ops/s 707.8254 Ops/s $\color{#d91a1a}-0.04\%$
test_ddpg_speed 2.9325ms 2.6339ms 379.6649 Ops/s 374.8701 Ops/s $\color{#35bf28}+1.28\%$
test_sac_speed 81.6980ms 8.4410ms 118.4689 Ops/s 126.0724 Ops/s $\textbf{\color{#d91a1a}-6.03\%}$
test_redq_speed 11.1459ms 9.9790ms 100.2108 Ops/s 92.0898 Ops/s $\textbf{\color{#35bf28}+8.82\%}$
test_redq_deprec_speed 13.4261ms 10.9567ms 91.2687 Ops/s 90.3875 Ops/s $\color{#35bf28}+0.97\%$
test_td3_speed 7.9160ms 7.8489ms 127.4064 Ops/s 126.9545 Ops/s $\color{#35bf28}+0.36\%$
test_cql_speed 25.3022ms 24.4984ms 40.8190 Ops/s 40.1545 Ops/s $\color{#35bf28}+1.65\%$
test_a2c_speed 5.9870ms 5.3972ms 185.2820 Ops/s 181.6605 Ops/s $\color{#35bf28}+1.99\%$
test_ppo_speed 5.9088ms 5.6936ms 175.6352 Ops/s 170.0269 Ops/s $\color{#35bf28}+3.30\%$
test_reinforce_speed 5.0773ms 4.8396ms 206.6266 Ops/s 221.6794 Ops/s $\textbf{\color{#d91a1a}-6.79\%}$
test_iql_speed 20.4313ms 19.4457ms 51.4253 Ops/s 51.6616 Ops/s $\color{#d91a1a}-0.46\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9921ms 2.8403ms 352.0729 Ops/s 351.0585 Ops/s $\color{#35bf28}+0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0881ms 0.5343ms 1.8715 KOps/s 1.8524 KOps/s $\color{#35bf28}+1.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7090ms 0.5112ms 1.9560 KOps/s 1.9387 KOps/s $\color{#35bf28}+0.90\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0299ms 2.8640ms 349.1646 Ops/s 348.0161 Ops/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2117ms 0.5266ms 1.8991 KOps/s 1.8822 KOps/s $\color{#35bf28}+0.90\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7422ms 0.5049ms 1.9808 KOps/s 1.9711 KOps/s $\color{#35bf28}+0.49\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1135ms 2.9617ms 337.6437 Ops/s 336.4757 Ops/s $\color{#35bf28}+0.35\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2078ms 0.6555ms 1.5256 KOps/s 1.5046 KOps/s $\color{#35bf28}+1.40\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8444ms 0.6336ms 1.5782 KOps/s 1.5560 KOps/s $\color{#35bf28}+1.43\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9199ms 2.8348ms 352.7592 Ops/s 352.9101 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6420ms 0.5353ms 1.8680 KOps/s 1.8538 KOps/s $\color{#35bf28}+0.76\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.4765ms 0.5166ms 1.9358 KOps/s 1.9182 KOps/s $\color{#35bf28}+0.92\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0931ms 2.8634ms 349.2407 Ops/s 349.3939 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6517ms 0.5273ms 1.8963 KOps/s 1.8783 KOps/s $\color{#35bf28}+0.96\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6120ms 0.5071ms 1.9718 KOps/s 1.9625 KOps/s $\color{#35bf28}+0.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1751ms 2.9721ms 336.4634 Ops/s 337.0471 Ops/s $\color{#d91a1a}-0.17\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2764ms 0.6607ms 1.5135 KOps/s 1.5195 KOps/s $\color{#d91a1a}-0.39\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8472ms 0.6399ms 1.5628 KOps/s 1.5624 KOps/s $\color{#35bf28}+0.02\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1121s 8.7862ms 113.8142 Ops/s 112.1965 Ops/s $\color{#35bf28}+1.44\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 20.4614ms 14.5248ms 68.8477 Ops/s 69.6875 Ops/s $\color{#d91a1a}-1.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2384ms 1.0981ms 910.6891 Ops/s 946.2160 Ops/s $\color{#d91a1a}-3.75\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1013s 8.5503ms 116.9550 Ops/s 150.5082 Ops/s $\textbf{\color{#d91a1a}-22.29\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.4012ms 14.4260ms 69.3192 Ops/s 61.4436 Ops/s $\textbf{\color{#35bf28}+12.82\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.1368ms 1.0746ms 930.6117 Ops/s 945.8976 Ops/s $\color{#d91a1a}-1.62\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 99.6248ms 7.0213ms 142.4237 Ops/s 141.0951 Ops/s $\color{#35bf28}+0.94\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.0956ms 14.8163ms 67.4932 Ops/s 68.1828 Ops/s $\color{#d91a1a}-1.01\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.4368ms 1.3907ms 719.0565 Ops/s 705.3307 Ops/s $\color{#35bf28}+1.95\%$

@vmoens vmoens merged commit 52827c2 into main Mar 4, 2024
20 of 23 checks passed
@vmoens vmoens deleted the mpmath-1.3 branch March 4, 2024 08:46
@NicolasHug NicolasHug mentioned this pull request Mar 4, 2024
Closed
vmoens added a commit that referenced this pull request Mar 25, 2024
@vmoens
[CI] Fixes sympy error by fixing mpmath version (#1988)
54ae2e5 
(cherry picked from commit 52827c2)
vmoens added a commit that referenced this pull request Apr 7, 2024
@vmoens
[CI] Fixes sympy error by fixing mpmath version (#1988)
d746f66 
(cherry picked from commit 52827c2)
@johnlawerance johnlawerance mentioned this pull request May 8, 2024
Closed
6 tasks
@jeffhataws jeffhataws mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot