-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Adding tensordict __repr__
tests
#435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 12, 2022
sladebot
changed the title
Adding tensordict repr tests
WIP: Adding tensordict repr tests
Sep 12, 2022
sladebot
changed the title
WIP: Adding tensordict repr tests
Adding tensordict repr tests
Sep 12, 2022
vmoens
changed the title
Adding tensordict repr tests
[Tests] Adding tensordict repr tests
Sep 13, 2022
vmoens
changed the title
[Tests] Adding tensordict repr tests
[Tests] Adding tensordict Sep 13, 2022
__repr__
tests
sladebot
force-pushed
the
tensordict_repr_tests
branch
from
September 13, 2022 20:21
9420224
to
8342872
Compare
vmoens
reviewed
Sep 15, 2022
sladebot
force-pushed
the
tensordict_repr_tests
branch
13 times, most recently
from
September 19, 2022 15:47
0fe166c
to
ab6a21e
Compare
sladebot
force-pushed
the
tensordict_repr_tests
branch
from
September 19, 2022 16:14
ab6a21e
to
9fab2de
Compare
vmoens
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Tests
Incomplete or broken unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!