Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Adding tensordict __repr__ tests #435

Merged
merged 18 commits into from
Sep 21, 2022

Conversation

sladebot
Copy link
Contributor

@sladebot sladebot commented Sep 12, 2022

Description

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2022
@sladebot sladebot marked this pull request as ready for review September 12, 2022 21:53
@sladebot sladebot changed the title Adding tensordict repr tests WIP: Adding tensordict repr tests Sep 12, 2022
@sladebot sladebot changed the title WIP: Adding tensordict repr tests Adding tensordict repr tests Sep 12, 2022
@vmoens vmoens changed the title Adding tensordict repr tests [Tests] Adding tensordict repr tests Sep 13, 2022
@vmoens vmoens added the Tests Incomplete or broken unit tests label Sep 13, 2022
@vmoens vmoens changed the title [Tests] Adding tensordict repr tests [Tests] Adding tensordict __repr__ tests Sep 13, 2022
test/test_tensordict.py Outdated Show resolved Hide resolved
@sladebot sladebot force-pushed the tensordict_repr_tests branch 13 times, most recently from 0fe166c to ab6a21e Compare September 19, 2022 15:47
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@vmoens vmoens merged commit 443e5d9 into pytorch:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants