[Refactoring] Minor tweaks to recorder and logger #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vmoens
changed the title
vmoens
reviewed
Sep 26, 2022
torchrl/trainers/trainers.py
Outdated
| @@ -933,12 +932,11 @@ def __init__( | |||
| def __call__(self, batch: TensorDictBase) -> Dict: | |||
| out = None | |||
| if self._count % self.record_interval == 0: | |||
| torch.cuda.empty_cache() | |||
There was a problem hiding this comment.
I think we added this because of weird cuda mem issues which I believe are solved now. Can we remove this and try to train something like dreamer while looking at the mem on devices?
Asking this because this operation takes a considerable amount of time :)
There was a problem hiding this comment.
yes i agree let's remove this
vmoens
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes to recorder and logger.
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!