Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add coverage with codecov #523

Merged
merged 4 commits into from
Oct 6, 2022
Merged

[CI] Add coverage with codecov #523

merged 4 commits into from
Oct 6, 2022

Conversation

silvestrebahi
Copy link
Contributor

Description

Added code coverage to the CI pipeline

Motivation and Context

Internal task

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2022
vmoens
vmoens approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this

@vmoens vmoens changed the title Add coverage with codecov [CI] Add coverage with codecov Oct 6, 2022
@vmoens vmoens added Tests Incomplete or broken unit tests CI Has to do with CI setup (e.g. wheels & builds, tests...) labels Oct 6, 2022
@vmoens vmoens merged commit 3cfba85 into pytorch:main Oct 6, 2022
vmoens added a commit that referenced this pull request Oct 6, 2022
@vmoens
Revert "[CI] Add coverage with codecov (#523)"
28be9e1 
This reverts commit 3cfba85.
vmoens added a commit that referenced this pull request Oct 6, 2022
@vmoens
Revert "[CI] Add coverage with codecov (#523)" (#525)
bb3713f 
This reverts commit 3cfba85.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvestrebahi @vmoens @facebook-github-bot