Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] TensorDict comparison #567

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[BugFix] TensorDict comparison #567

merged 1 commit into from
Oct 13, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Oct 13, 2022

Description

Makes TensorDict comparison fault-tolerant

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2022
@vmoens vmoens added bug Something isn't working enhancement New feature or request labels Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #567 (19fec0e) into main (341b3ab) will increase coverage by 0.01%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   86.88%   86.90%   +0.01%     
==========================================
  Files         121      121              
  Lines       21786    21802      +16     
==========================================
+ Hits        18929    18946      +17     
+ Misses       2857     2856       -1     
Flag Coverage Δ
linux-cpu 85.23% <90.90%> (+0.01%) ⬆️
linux-gpu 86.68% <90.90%> (+0.01%) ⬆️
linux-outdeps-gpu 75.44% <90.90%> (+0.05%) ⬆️
linux-stable-cpu 85.21% <90.90%> (+0.01%) ⬆️
linux-stable-gpu 86.68% <90.90%> (+0.01%) ⬆️
macos-cpu 84.99% <90.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/data/tensordict/tensordict.py 82.50% <75.00%> (+0.03%) ⬆️
test/test_tensordict.py 97.44% <100.00%> (+0.02%) ⬆️
torchrl/data/tensordict/memmap.py 85.76% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vmoens vmoens merged commit 872dd2d into main Oct 13, 2022
@vmoens vmoens deleted the tensordict_comparison branch October 18, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants