Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] set_default -> setdefault #935

Merged
merged 2 commits into from
Feb 24, 2023
Merged

[Refactor] set_default -> setdefault #935

merged 2 commits into from
Feb 24, 2023

Conversation

tcbegley
Copy link
Contributor

Description

This PR updates the sole usage of TensorDict.set_default to TensorDict.setdefault.

cf. pytorch/tensordict#235

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2023
@tcbegley tcbegley mentioned this pull request Feb 24, 2023
Merged
@vmoens vmoens added the enhancement New feature or request label Feb 24, 2023
vmoens
vmoens approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit f47d2cb into pytorch:main Feb 24, 2023
@tcbegley tcbegley mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcbegley @vmoens @facebook-github-bot