Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickFix Versioning #958

Merged
merged 2 commits into from
Mar 9, 2023
Merged

QuickFix Versioning #958

merged 2 commits into from
Mar 9, 2023

Conversation

fedebotu
Copy link
Contributor

@fedebotu fedebotu commented Mar 9, 2023

Description

Installing the new 0.0.5 version resulted in the following error:

File "/home/botu/Dev/rl/torchrl/data/replay_buffers/storages.py", line 15, in <module>
from tensordict.tensordict import is_tensor_collection, TensorDict, TensorDictBase
ImportError: cannot import name 'is_tensor_collection' from 'tensordict.tensordict' (/home/botu/Dev/rl/env/lib/python3.9/site-packages/tensordict/tensordict.py)

This can be solved by installing tensordict>=0.0.3.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2023
@vmoens vmoens merged commit 39625e9 into pytorch:main Mar 9, 2023
@vmoens
Copy link
Contributor

vmoens commented Mar 9, 2023

Thanks for reporting this.
We'll be releasing the 0.1.0 soon, and we'll make sure that the dependency on tensordict is properly stated then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants