Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: huggingface diffusers example #1904

Merged
merged 13 commits into from
Nov 3, 2022

Conversation

jagadeeshi2i
Copy link
Collaborator

Description

Adds Huggingface stable vision diffusion model to examples

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #1904 (d1be0e3) into master (e18d8b8) will not change coverage.
The diff coverage is n/a.

❗ Current head d1be0e3 differs from pull request most recent head 82b35e4. Consider uploading reports for the commit 82b35e4 to get more accurate results

@@           Coverage Diff           @@
##           master    #1904   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          63       63           
  Lines        2609     2609           
  Branches       56       56           
=======================================
  Hits         1173     1173           
  Misses       1436     1436           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jagadeeshi2i jagadeeshi2i changed the title [WIP] feat: huggingface diffusers example feat: huggingface diffusers example Oct 18, 2022
Copy link
Collaborator

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jagadeeshi2i , just left some minor comments.

examples/diffusers/Readme.md Outdated Show resolved Hide resolved
examples/diffusers/Readme.md Show resolved Hide resolved
 - update readme doc

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
 - write output image to file with timestamp

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
…g_diffusers

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the two thoughts in the comments

examples/diffusers/stable_diffusion_handler.py Outdated Show resolved Hide resolved
examples/diffusers/requirements.txt Outdated Show resolved Hide resolved
jagadeeshi2i and others added 3 commits November 2, 2022 01:41
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@msaroufim msaroufim merged commit df5d003 into pytorch:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants