Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README for serving models using TorchServe Docker Container #2118

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Feb 9, 2023

Description

This is a README showing an example for serving models using Docker container

Fixes #(2113)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

The outputs posted in the README are from executing the steps mentioned

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #2118 (cdd152b) into master (485ebf8) will not change coverage.
The diff coverage is n/a.

❗ Current head cdd152b differs from pull request most recent head 94b787a. Consider uploading reports for the commit 94b787a to get more accurate results

@@           Coverage Diff           @@
##           master    #2118   +/-   ##
=======================================
  Coverage   53.36%   53.36%           
=======================================
  Files          71       71           
  Lines        3225     3225           
  Branches       56       56           
=======================================
  Hits         1721     1721           
  Misses       1504     1504           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we also delete code from https://github.com/pytorch/serve/blob/master/docker/README.md#create-torch-model-archiver-from-container and just have a single point of truth that's linked from the main README and not just the examples page

@agunapal
Copy link
Collaborator Author

I'd prefer if we also delete code from https://github.com/pytorch/serve/blob/master/docker/README.md#create-torch-model-archiver-from-container and just have a single point of truth that's linked from the main README and not just the examples page

@msaroufim I'll add a link to the example there. There is probably more than one way to serve the model using docker?

@agunapal agunapal merged commit c417b4a into master Feb 16, 2023
@agunapal agunapal deleted the issues/update_docker_example branch February 16, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants