Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inference output for ResNet-152 example #2745

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

sachanub
Copy link
Collaborator

Description

We updated the weights in the ResNet-152 batch model MAR file (please refer to this issue for more details: #2467).

With the updated MAR file, there are minor changes in the scores for each of the categories in the inference output. Creating this PR to update to the latest scores.

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2745 (0d0e330) into master (424eca0) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d0e330 differs from pull request most recent head 760598b. Consider uploading reports for the commit 760598b to get more accurate results

@@           Coverage Diff           @@
##           master    #2745   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          85       85           
  Lines        3963     3963           
  Branches       58       58           
=======================================
  Hits         2871     2871           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal
Copy link
Collaborator

Hi @sachanub is the updated link mentioned anywhere in TorchServe?

@sachanub
Copy link
Collaborator Author

Hi @sachanub is the updated link mentioned anywhere in TorchServe?

@agunapal are you referencing the link to the ResNet-152 MAR file? If yes, then I should point out that the updated model artifact is available at the same link as it used to be i.e. https://torchserve.pytorch.org/mar_files/resnet-152-batch_v2.mar

This link is referenced in these pages:

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Oct 27, 2023
Merged via the queue into pytorch:master with commit c1da310 Oct 27, 2023
13 checks passed
@sachanub sachanub deleted the update_resnet152_example branch November 10, 2023 17:19
@chauhang chauhang added this to the v0.10.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants