-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TorchServe dev container #2782
Conversation
Hi @sachanub Thanks for refactoring this! |
Hi @agunapal. I just attached the regression test logs in the PR description. I have also included the testing steps. Thanks! |
Great! |
Sounds good. I will run the IPEX test and attach the logs. |
Attached logs of IPEX test run in PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sachanub ! LGTM
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
The following changes have been made in this PR:
--recursive
option to also pull the third party googleapis repository. If this is not done, running the regression tests inside the container will fail with this error:build_image.sh
script to build the dev container usingDockerfile
instead ofDockerfile.dev
.codebuild
andDockerfile.benchmark
related code from thebuild_image.sh
script.intel_extension_for_pytorch
to2.1.0
.codebuild
images from theREADME.md
file.Dockerfile.dev
in theREADME.md
file.Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Tested the dev container by running the regression tests in it. Followed these steps to build and test the dev container:
The logs of the test run can be found here regression_tests_logs.txt
Tested the dev IPEX container by running https://github.com/pytorch/serve/blob/master/test/pytest/test_example_intel_extension_for_pytorch.py in it. Followed these steps to build and test the dev IPEX container:
The logs of the IPEX tests can be found here regression_test_ipex_logs.txt