-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make torchserve-kfs docker image multiplatform #3162
base: master
Are you sure you want to change the base?
Make torchserve-kfs docker image multiplatform #3162
Conversation
…d amd platforms, this command also pushes the image, it can not be loaded into the local registry due to limitations in buildx Also update build_upload_release.py and docker_nightly.py so docker images do not need to be pushed separately
@@ -57,4 +57,5 @@ fi | |||
cp ../../frontend/server/src/main/resources/proto/*.proto . | |||
cp -r ../../third_party . | |||
|
|||
DOCKER_BUILDKIT=1 docker build --file "$DOCKER_FILE" --build-arg BASE_IMAGE=$BASE_IMAGE -t "$DOCKER_TAG" . | |||
docker buildx create --name mybuilder --use --bootstrap | |||
docker buildx build --file "$DOCKER_FILE" --build-arg BASE_IMAGE=$BASE_IMAGE --platform linux/amd64,linux/arm64 --push -t "$DOCKER_TAG" . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command builds and pushes the docker image, so the steps in both python files which push the image have been removed.
Hi @agunapal! Would you be able to approve the workflows for this please? |
Hi @DanielTemesgen This would need a discussion. If we publish a new artifact, then we also need to sign up for testing/maintaining it. The kserve nightly test would also need to change to test the new platform |
Description
This PR does the following:
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3161
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Built image locally, pushed here.
Checklist: