Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate update-s3-html job to test-infra #4879

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jan 15, 2024

Migrate to test-infra.
These scripts originally located in https://github.com/pytorch/builder/tree/main/s3_management

Copy link

vercel bot commented Jan 15, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Jan 15, 2024 6:21pm

@atalman atalman merged commit ca6be2a into pytorch:main Jan 15, 2024
6 checks passed
@atalman atalman deleted the migrate_s3_management_to_test_infra branch January 15, 2024 18:40
@malfet
Copy link
Contributor

malfet commented Jan 16, 2024

@atalman the link that you've posted in PR description (and commit) redirects to 404, isn't it?

huydhn added a commit that referenced this pull request Jan 22, 2024
pytorch/executorch#1663. The indexing script
was migrated recently from builder to test-infra in
#4879. But there was a mistake
in which my [recent
change](pytorch/builder@6f3cb2b)
to keep nightly 20231010 for ExecuTorch wasn't copied over.

So, this PR copies the missing logic
pytorch/builder#1642. It also fixes some linter
issues flagged by test-infra lintrunner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants