Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sentencepiece from setup.py file #1055

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Remove sentencepiece from setup.py file #1055

merged 3 commits into from
Oct 26, 2020

Conversation

zhangguanheng66
Copy link
Contributor

Since we added the sentencepiece dependency from the source code, we don't need it in the setup.py file anymore.

cpuhrsch
cpuhrsch approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to merge this right now, since sentencepiece is indeed not required for the library as an explicit dependency, but please in a follow-up PR bring it back for testing purposes.

@zhangguanheng66 zhangguanheng66 merged commit 4ceb4f4 into pytorch:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangguanheng66 @cpuhrsch