Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.8.x] Add Python 3.9 support #1088

Merged
merged 9 commits into from
Dec 3, 2020
Merged

[v0.8.x] Add Python 3.9 support #1088

merged 9 commits into from
Dec 3, 2020

Conversation

seemethere
Copy link
Member

Signed-off-by: Eli Uriegas eliuriegas@fb.com

@seemethere
.circleci: Add Python 3.9 support
71a314c 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere force-pushed the py39_080 branch 2 times, most recently from b845e64 to 699f3cb Compare December 1, 2020 20:17
@seemethere
bump versions
477b61c 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
pkg_helpers needs updating too
06a2a8e 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
use PYTHON_VERSION instead
b901419 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
unpin flake8
da5aee9 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@zhangguanheng66
Copy link
Contributor

Should we also add python 3.9 CI tests to the master branch?

@seemethere
update to use cuda 10.2 images
436658f 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
Copy link
Member Author

Should we also add python 3.9 CI tests to the master branch?

yes, I plan on cherry picking this squashed commit from the release branch to the master.

Just focusing on the release branch for now to make sure we get it in on time for the release next week.

@seemethere seemethere marked this pull request as draft December 1, 2020 20:32
zhangguanheng66
zhangguanheng66 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a stamp now here. Feel free to merge it after all the CI tests are good.

@seemethere
add -x so that we can see what commands are executed
d0dd4d0 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
fix flake8 errors
100a855 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
add comment to flush cache
fadf08e 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
Copy link
Member Author

Looks like there might be an issue with sentencepiece for Python 3.9 on windows so we may need to pull windows from this particular release see google/sentencepiece#591

@zhangguanheng66
Copy link
Contributor

zhangguanheng66 commented Dec 3, 2020 •
edited
Loading

Looks like there might be an issue with sentencepiece for Python 3.9 on windows so we may need to pull windows from this particular release see google/sentencepiece#591

Thanks for reaching out to them. Let's see their reply.

@seemethere seemethere marked this pull request as ready for review December 3, 2020 22:32
@seemethere
Copy link
Member Author

Going to go ahead and merge this since sentencepiece is an optional dependency

@seemethere seemethere merged commit 0f911ec into pytorch:release/0.8 Dec 3, 2020
@seemethere seemethere deleted the py39_080 branch December 3, 2020 22:32
@zhangguanheng66
Copy link
Contributor

Could you explain why sentencepiece is optional? For now, only windows py3.9 fails, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangguanheng66 zhangguanheng66 zhangguanheng66 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seemethere @zhangguanheng66 @facebook-github-bot