Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector dimension of OOV token (#275) #308

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Conversation

domaala
Copy link
Contributor

@domaala domaala commented May 4, 2018

This fixes #275 .

@domaala
Copy link
Contributor Author

domaala commented May 4, 2018

The single test that was failing depended on Xavier initialization, which does not allow for 1-D tensors. Considering that we went for a 1-D vector of an OOV vector, I had to change it.

However, this is kind of problematic for unk_init in general, so we should at least update the documentation to explain this 1-D constraint.

@mttk mttk merged commit d683ad0 into pytorch:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wordvec of unk token
2 participants