Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding installation step to Travis #585

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Adding installation step to Travis #585

merged 1 commit into from
Aug 9, 2019

Conversation

ShahriarRezghi
Copy link
Contributor

No description provided.

@zhangguanheng66
Copy link
Contributor

I think you could add "if [[ "$SKIP_TESTS" != "true" ]]; then" before "python setup.py install".

Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after all the CI tests pass.

@ShahriarRezghi
Copy link
Contributor Author

@zhangguanheng66 All the tests are passing now.

@zhangguanheng66 zhangguanheng66 merged commit 6034350 into pytorch:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants