Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation direction #763

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented May 12, 2020

Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

git clone https://github.com/pytorch/text torchtext
cd torchtext
git submodule update --init --recursive
python setup.py clean install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that the package is installed at global site-packages directory properly. You could try to import torchtext outside the text folder and see if it works properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you are right. The installation does not work.
I think #764 should solve this.

@mthrok mthrok force-pushed the update-readme branch 2 times, most recently from 094b90a to d3052ae Compare May 13, 2020 02:59
@mthrok mthrok merged commit 32bc374 into pytorch:master May 13, 2020
@mthrok mthrok deleted the update-readme branch May 13, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants