Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve linter warning #771

Merged
merged 1 commit into from
May 14, 2020
Merged

Resolve linter warning #771

merged 1 commit into from
May 14, 2020

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented May 14, 2020

See D21483116

Passing a not noexcept-copyable type by value can lead to accidental copy failure.
Pass the type by const reference.

std::move called with const argument
Variable content
The result is const&&. This is probably not what you intended.

@mthrok mthrok merged commit 30c89e9 into pytorch:master May 14, 2020
@mthrok mthrok deleted the cpp-linter branch May 14, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangguanheng66 zhangguanheng66 zhangguanheng66 approved these changes

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthrok @zhangguanheng66