Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows unit tests #772

Merged
merged 13 commits into from
May 14, 2020
Merged

Conversation

peterjc123
Copy link
Contributor

No description provided.

@peterjc123 peterjc123 force-pushed the add_windows_unit_tests branch 5 times, most recently from 99da02c to 60e0bea Compare May 14, 2020 06:34
@peterjc123 peterjc123 changed the title Add Windows unit tests [WIP] Add Windows unit tests May 14, 2020
@peterjc123 peterjc123 marked this pull request as draft May 14, 2020 08:50
@peterjc123 peterjc123 changed the title [WIP] Add Windows unit tests Add Windows unit tests May 14, 2020
@peterjc123 peterjc123 marked this pull request as ready for review May 14, 2020 12:32
@peterjc123
Copy link
Contributor Author

peterjc123 commented May 14, 2020

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the wonderful work for such a short amount of time! :)

torchtext/csrc/sentencepiece.cpp Outdated Show resolved Hide resolved
@mthrok mthrok merged commit 75a6e90 into pytorch:master May 14, 2020
@mthrok
Copy link
Contributor

mthrok commented May 14, 2020

Thank you very much!

@peterjc123 peterjc123 deleted the add_windows_unit_tests branch May 14, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants