Question answer datasets: SQuAD1 and SQuAD2 #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
reviewed
May 14, 2020
| """Defines an abstraction for raw question answer iterable datasets. | ||
| """ | ||
|
|
||
| def __init__(self, iterator, start=0, num_lines=None): |
There was a problem hiding this comment.
The other dataset still has the setup_iter method, so I'd mirror that behavior or change the behavior of the other.
There was a problem hiding this comment.
OK, let's keep this consistent for now since there are several ongoing PRs to re-write datasets. Once done, we can send out a separate PR to fix it.
4 tasks
cpuhrsch
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.