Add utility func to get path to assets #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
reviewed
May 15, 2020
| atexit.register(_TEMP_DIR.cleanup) | ||
|
|
||
|
|
||
| def get_asset_path(*path_components, use_temp_dir=False): |
There was a problem hiding this comment.
You could make this a context with get_assest that'll then also cleans up the temp file if it goes out of scope (if that is intended).
There was a problem hiding this comment.
Yes, that's the typical approach, but that way user of this function has to be aware of temporary files and directories. This way, they are abstracted out and users need not care.
cpuhrsch
approved these changes
May 15, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpuhrsch @zhangguanheng66
It turned out that buck runs test in a directory of which full path contains a comma.
When Sentence Piece Trainer is given such a path, it considers there are multiple of paths, and fails.
To workaround this, I added a helper function that facilitates path generation and optionally copy the file to temporary directory and return the path there.
Then I adopted the function to other places where it uses test assets.