-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental sequence tagging datasets #805
Experimental sequence tagging datasets #805
Conversation
Merging from upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a docs strings here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Add some minor comments in the PR. Let me know when you need a final look before merging. Thanks a lot.
- add validation while getting current data in dataset class
…o new_sequence_tagging
@zhangguanheng66 have already fixed all the comments. though for the codecoverage not really sure what can be added to improve the coverage, please let me know if you have any ideas |
I just merged the testcase PR #822 |
@seemethere Any ideas about the codecov failure? |
No idea, I can't view the codecov either |
@seemethere I add a PR to remove codecov and this is consistent with the other two domain libraries. #832 |
@zhangguanheng66 thanks, the unittest have been updated with the latest patch |
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 76.57% 76.99% +0.41%
==========================================
Files 40 42 +2
Lines 2715 2847 +132
==========================================
+ Hits 2079 2192 +113
- Misses 636 655 +19
Continue to review full report at Codecov.
|
@zhangguanheng66 done merging #832, thanks for the fix! |
@akurniawan Thanks for the contribution. |
Adding new abstraction for sequence tagging datasets with new API