Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental sequence tagging datasets #805

Merged
merged 32 commits into from
Jun 22, 2020

Conversation

akurniawan
Copy link
Contributor

Adding new abstraction for sequence tagging datasets with new API

@akurniawan akurniawan marked this pull request as draft June 4, 2020 01:32
@akurniawan akurniawan marked this pull request as ready for review June 4, 2020 01:54
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a docs strings here.

@zhangguanheng66 zhangguanheng66 changed the title New sequence tagging Experimental sequence tagging datasets Jun 4, 2020
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Add some minor comments in the PR. Let me know when you need a final look before merging. Thanks a lot.

@akurniawan
Copy link
Contributor Author

akurniawan commented Jun 18, 2020

@zhangguanheng66 have already fixed all the comments. though for the codecoverage not really sure what can be added to improve the coverage, please let me know if you have any ideas

@zhangguanheng66
Copy link
Contributor

I just merged the testcase PR #822

@zhangguanheng66
Copy link
Contributor

@seemethere Any ideas about the codecov failure?

@seemethere
Copy link
Member

No idea, I can't view the codecov either

@zhangguanheng66
Copy link
Contributor

No idea, I can't view the codecov either

@seemethere I add a PR to remove codecov and this is consistent with the other two domain libraries. #832

@akurniawan
Copy link
Contributor Author

@zhangguanheng66 thanks, the unittest have been updated with the latest patch

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #805 into master will increase coverage by 0.41%.
The diff coverage is 85.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   76.57%   76.99%   +0.41%     
==========================================
  Files          40       42       +2     
  Lines        2715     2847     +132     
==========================================
+ Hits         2079     2192     +113     
- Misses        636      655      +19     
Impacted Files Coverage Δ
...orchtext/experimental/datasets/sequence_tagging.py 77.41% <77.41%> (ø)
...text/experimental/datasets/raw/sequence_tagging.py 92.64% <92.64%> (ø)
torchtext/experimental/datasets/__init__.py 100.00% <100.00%> (ø)
torchtext/experimental/datasets/raw/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57369c...2d01b15. Read the comment docs.

@akurniawan
Copy link
Contributor Author

@zhangguanheng66 done merging #832, thanks for the fix!

@zhangguanheng66
Copy link
Contributor

@akurniawan Thanks for the contribution.

@zhangguanheng66 zhangguanheng66 merged commit b4d34ed into pytorch:master Jun 22, 2020
@akurniawan akurniawan deleted the new_sequence_tagging branch June 23, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants