switch experimental ngrams_func to data.utils.ngrams_iterator #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
reviewed
Jun 6, 2020
| @@ -50,3 +50,7 @@ def test_text_nomalize_function(self): | |||
| ref_lines.append(line) | |||
|
|
|||
| self.assertEqual(ref_lines, test_lines) | |||
|
|
|||
| def test_ngrams_func(self): | |||
| func = ngrams_func(2) | |||
There was a problem hiding this comment.
We could add more tests here
cpuhrsch
approved these changes
Jun 6, 2020
cpuhrsch
requested changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.