Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download #922

Merged
merged 13 commits into from
Aug 13, 2020
Merged

Conversation

zhangguanheng66
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 commented Aug 12, 2020

Skip requests.get if path exists.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #922 into master will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   76.70%   77.18%   +0.48%     
==========================================
  Files          44       44              
  Lines        2996     3003       +7     
==========================================
+ Hits         2298     2318      +20     
+ Misses        698      685      -13     
Impacted Files Coverage Δ
torchtext/utils.py 82.35% <100.00%> (+0.84%) ⬆️
torchtext/experimental/vectors.py 85.54% <0.00%> (+15.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6af592...3b7608e. Read the comment docs.

Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangguanheng66 zhangguanheng66 merged commit ad85411 into pytorch:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants