Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch should be sorted by decreasing size. #95

Merged
merged 4 commits into from
Aug 17, 2017
Merged

Batch should be sorted by decreasing size. #95

merged 4 commits into from
Aug 17, 2017

Commits on Aug 16, 2017

  1. Batch should be sorted by decreasing size. 

    `rnn.pack_padded_sequence` requires that a minibatch be sorted by decreasing order.

It's important for `self.sort_key(x)` to sort the data in increasing order to for curriculum learning but for the rows in the batch to be sorted in decreasing order.
    @PetrochukM
    PetrochukM authored Aug 16, 2017
    Configuration menu
    Copy the full SHA
    1904ba4 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Update to comments

    @PetrochukM
    PetrochukM authored Aug 17, 2017
    Configuration menu
    Copy the full SHA
    112aaff View commit details
    Browse the repository at this point in the history

  2. Addressing Comments

    @PetrochukM
    PetrochukM authored Aug 17, 2017
    Configuration menu
    Copy the full SHA
    c5cedec View commit details
    Browse the repository at this point in the history

  3. Flake8

    @PetrochukM
    PetrochukM authored Aug 17, 2017
    Configuration menu
    Copy the full SHA
    b0c8ade View commit details
    Browse the repository at this point in the history