.circleci Bump xcode workers to 9.4.1 #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream is on 9.4.1 and we were experiencing issues when conda-build was attempting to check for overlinking and failed out due to some files not existing in xcode 9.0 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
zhangguanheng66
approved these changes
Aug 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
=======================================
Coverage 77.44% 77.44%
=======================================
Files 44 44
Lines 3064 3064
=======================================
Hits 2373 2373
Misses 691 691 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream is on 9.4.1 and we were experiencing issues when conda-build
was attempting to check for overlinking and failed out due to some files
not existing in xcode 9.0
Similar to pytorch/audio#898
Signed-off-by: Eli Uriegas eliuriegas@fb.com