Skip to content

CLI: Make providing an output path required for export #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

CLI: Make providing an output path required for export #970

wants to merge 6 commits into from

Conversation

Jack-Khuu
Copy link
Contributor

When exporting, an export path is required. This PR makes this explicit

python torchchat.py export stories15M

usage: torchchat export [-h] [--checkpoint-path CHECKPOINT_PATH] (--output-pte-path OUTPUT_PTE_PATH | --output-dso-path OUTPUT_DSO_PATH) [--dtype {fp32,fp16,bf16,float,half,float32,float16,bfloat16,fast,fast16}] [--quantize QUANTIZE] [--device {fast,cpu,cuda,mps}]
                        [--hf-token HF_TOKEN] [--model-directory MODEL_DIRECTORY] [-v] [--seed SEED]
                        [model]
torchchat export: error: one of the arguments --output-pte-path --output-dso-path is required

Solving #969

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/970

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 46b4aa3 with merge base b2c3f26 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 30, 2024
Jack-Khuu and others added 5 commits July 30, 2024 09:50
@Jack-Khuu
Docs: Deduplicate quantization.md with the introduction of model_cust…
5085ab6 
…omization.md (#967)

* Update quantization.md

* Push precision into the customization and removed duplicate info from quantization

* Update docs README to call out vetted files
@malfet
Fix CI hang while running test-readme-mps-macos (#968)
4eda481
@Jack-Khuu
Explicitly use cpu when running GH machines; Tests that want mps/cuda…
b2c3f26 
… should explicitly request for it (#975)
@Jack-Khuu
Make output path required for export
cabcc01
@Jack-Khuu
Merge branch 'require-export-out' of github.com:pytorch/torchchat int…
46b4aa3 
…o require-export-out
@Jack-Khuu
Copy link
Contributor Author

Rebase onto main

Jack-Khuu
Jack-Khuu commented Aug 1, 2024
View reviewed changes
cli.py
@@ -165,7 +165,7 @@ def _add_export_output_path_args(parser, verb: str) -> None:
"Export Output Path" if is_export else None,
"Specify the output path for the exported model files" if is_export else None,
)
exclusive_parser = output_path_parser.add_mutually_exclusive_group()
exclusive_parser = output_path_parser.add_mutually_exclusive_group(required=is_export)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only actual change. Everything else is rebase artifact

@Jack-Khuu Jack-Khuu closed this Aug 2, 2024
@mike94043 mike94043 mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet Awaiting requested review from malfet

@byjlw byjlw Awaiting requested review from byjlw

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

@vmpuri vmpuri Awaiting requested review from vmpuri

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jack-Khuu @facebook-github-bot @malfet