deps: Add set -x for installation commands #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds set -x for all installation commands in install_requirements.sh so that users can see what's actually being installed and can help debug when they run into any issues. NOTE: This doesn't turn it on for all of the script (since that'd be overbearing) but rather turns it on specifically when installing things. This also adds "set -eou pipefail" to the top of the script which is a recommended paradigm for all bash scripts since it adds things like error on exit, error on undefined variable, and propagation of errors on pipe failure. https://explainshell.com/explain?cmd=set+-euo+pipefail Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/993
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f6a0049 with merge base 35db038 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Aug 1, 2024
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds set -x for all installation commands in install_requirements.sh so that users can see what's actually being installed and can help debug when they run into any issues.
NOTE: This doesn't turn it on for all of the script (since that'd be overbearing) but rather turns it on specifically when installing things.
This also adds "set -eou pipefail" to the top of the script which is a recommended paradigm for all bash scripts since it adds things like error on exit, error on undefined variable, and propagation of errors on pipe failure.
https://explainshell.com/explain?cmd=set+-euo+pipefail