Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Llama2 70B LoRA finetuning #788

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Adding support for Llama2 70B LoRA finetuning #788

merged 5 commits into from
Apr 18, 2024

Conversation

kartikayk
Copy link
Contributor

@kartikayk kartikayk commented Apr 18, 2024

Context

As per title

Changelog

  • Builder function + config

Test plan

  • Trained for one epoch with the following loss
image

 

  • Training Speed

image

 

  • Memory
image
  • generated output using gpt-fast
image

Copy link

pytorch-bot bot commented Apr 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/788

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bda498d with merge base a7b507b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 27.53%. Comparing base (a878f3b) to head (0f0df12).
Report is 18 commits behind head on main.

Files Patch % Lines
torchtune/models/llama2/_model_builders.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   27.48%   27.53%   +0.05%     
==========================================
  Files         144      143       -1     
  Lines        5966     5937      -29     
==========================================
- Hits         1640     1635       -5     
+ Misses       4326     4302      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh crap, not sure

Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when green

@kartikayk kartikayk merged commit 84a2d28 into main Apr 18, 2024
27 checks passed
@joecummings joecummings deleted the llama2_70b branch April 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants