Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokens_per_sec to tokens_per_sec_per_gpu #956

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

kartikayk
Copy link
Contributor

Context

We log tokens_per_sec_per_gpu but this is called tokens_per_sec which causes some confusion.

Changelog

Update the name of the param being logged

Test plan

Eyes:

Screenshot 2024-05-09 at 10 04 52 AM

Copy link

pytorch-bot bot commented May 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/956

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 53b194a with merge base 0217d44 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2024
@RdoubleA
Copy link
Contributor

RdoubleA commented May 9, 2024

would tokens_per_sec_per_gpu ever differ slightly among ranks?

@kartikayk
Copy link
Contributor Author

would tokens_per_sec_per_gpu ever differ slightly among ranks?

it's a good question - it will, but the current nomenclature doesn't really call this difference out either. We assume rank 0 is representative (reasonable for randomly shuffled data). This just makes what we log more explicit

@kartikayk kartikayk merged commit dc2b991 into main May 11, 2024
29 checks passed
@kartikayk kartikayk deleted the logging_update branch May 11, 2024 16:27
weifengpy pushed a commit to weifengpy/torchtune that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants