local_scheduler: add local_cwd scheduler + improve default handling #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
the
CLA Signed
This was referenced Sep 25, 2021
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…203) Summary: * `local_cwd`: This adds a new scheduler/image provider that overrides the image with the current working directory. This is intended to be a better approach for local launching since it doesn't require interacting with the images. * This removes `local_dir` scheduler in favor of `local_cwd`. * Changes how the default scheduler is specified since it's unclear what `default` even means without looking at the code and instead the CLI specifies the default via argparse default. * Updates the documentation to use local_cwd and local_docker instead. Pull Request resolved: #203 Test Plan: ``` $ pytest $ pyre $ env O="--port 4444" make clean livehtml ``` Go to quickstart page and ensure command run without any changes. CI Reviewed By: aivanou Differential Revision: D31178356 Pulled By: d4l3k fbshipit-source-id: d9522ac351553c3ddc4e613314a42766836d3340
|
This pull request was exported from Phabricator. Differential Revision: D31178356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local_cwd: This adds a new scheduler/image provider that overrides the image with the current working directory. This is intended to be a better approach for local launching since it doesn't require interacting with the images.local_dirscheduler in favor oflocal_cwd.defaulteven means without looking at the code and instead the CLI specifies the default via argparse default.Test plan:
Go to quickstart page and ensure command run without any changes.
CI