Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

simply pytorch install by using pytorch-nightly instead of source #43

Closed
wants to merge 1 commit into from

Conversation

soumith
Copy link
Member

@soumith soumith commented May 4, 2018

simply pytorch install by using pytorch-nightly instead of source

@jmp84
Copy link
Contributor

jmp84 commented May 4, 2018

Patching and trying instructions again (or did you already try?).

@soumith
Copy link
Member Author

soumith commented May 4, 2018

I haven't tried.

@soumith
Copy link
Member Author

soumith commented May 4, 2018

if you are using cuda9, it is: conda install pytorch-nightly cuda90 -c pytorch

git submodule update --init
NCCL_ROOT_DIR="${NCCL_ROOT_DIR}" python3 setup.py install \
2>&1 | tee PYTORCH_OUT
conda install pytorch-nightly -c pytorch
```

- Build [Caffe2](http://caffe2.ai/) from source (under PyTorch):

This comment was marked as off-topic.

@jmp84
Copy link
Contributor

jmp84 commented May 4, 2018

Is this nightly package also including Caffe2? (@pjh5)
@jhcross, getting seg fault when running export example with this new install:

wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -O miniconda.sh
chmod +x miniconda.sh
./miniconda.sh -b -p ~/miniconda
rm miniconda.sh
. ~/miniconda/bin/activate

conda install pytorch-nightly -c pytorch

conda install -y cmake

git clone --recursive https://github.com/onnx/onnx.git
yes | pip install ./onnx 2>&1 | tee ONNX_OUT

pip uninstall -y pytorch-translate
python3 setup.py build develop

@theweiho
Copy link
Contributor

theweiho commented May 4, 2018

You can also try seeing if

conda uninstall -y caffe2 caffe2-cuda8.0-cudnn7
conda install -y -c caffe2 caffe2-cuda8.0-cudnn7

before trying to install ONNX helps

@jmp84
Copy link
Contributor

jmp84 commented May 4, 2018

@theweiho, same issue.

@pjh5
Copy link

pjh5 commented May 4, 2018

@jmp84 where's the segfault?
pytorch-nightly does not include Caffe2
It is safe to clone Pytorch and only build Caffe2 from it and get the Pytorch installation from conda; this will save all the time needed to build Pytorch. You can't do this with the Caffe2 conda packages because they are not built with Aten. The pytorch-caffe2_cuda8.0_cudnn7 builds in the caffe2 conda channel are built with Aten, and also include Pytorch, but the Pytorch included from these builds will be slightly different than the one from pytorch-nightly (though these differences should not affect you). jsyk the names of these Pytorch+Caffe2 packages will probably change within the next day.

@theweiho
Copy link
Contributor

theweiho commented May 4, 2018

@pjh5 - you're suggesting that we should be able to use the new combined pytorch-caffe2_cuda8.0_cudnn7 conda builds now? (Once package names settle) That'd be awesome!

@jhcross (and maybe @jamesr66a ?) may have more info for what the ONNX compatibility/segfault issue we ran into was (so we can confirm whether that'd be resolved with the new combined PyTorch+Caffe2 packages).

@theweiho
Copy link
Contributor

theweiho commented May 5, 2018

@anderspapitto @bddppq - James Cross mentioned y'all helped him debug the ONNX compatibility/segfault issue - and that it may have been due to differences in gcc compiler versions or something?

@anderspapitto
Copy link

we got something to work, but there wasn't full clarity into exactly what the issue had been.

If you're able to make changes and things work, then you're probably fine - the crashes we were running into were very upfront

theweiho added a commit to theweiho/translate that referenced this pull request May 10, 2018
Summary:
Simplify installation instructions by using the combined PyTorch+Caffe2 conda package (can probably replace pytorch#43)

Also fix some examples after internal sync

Differential Revision: D7939466

fbshipit-source-id: f3f1012e652787929b30cdbf74d513e741971f8d
facebook-github-bot pushed a commit that referenced this pull request May 10, 2018
Summary:
Simplify installation instructions by using the combined PyTorch+Caffe2 conda package (can probably replace #43)

Also fix some examples after internal sync

Closes #52

Reviewed By: jhcross

Differential Revision: D7939466

fbshipit-source-id: e60c1e10638c2a5417d93e6d6bee860b3421d671
@jmp84
Copy link
Contributor

jmp84 commented May 10, 2018

Fixed in 7ba9dfc by @theweiho

@jmp84 jmp84 closed this May 10, 2018
@jmp84 jmp84 deleted the soumith-patch-1 branch March 18, 2019 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants