Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Segmentation models #1009

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Refactor Segmentation models #1009

merged 1 commit into from
Jun 11, 2019

Conversation

ekagra-ranjan
Copy link
Contributor

This PR uses a protected method for loading and initializing the segmentation models. Relevant #875

This PR uses a protected method for loading and initializing the segmentation models. Relevant #875
@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

Merging #1009 into master will increase coverage by 0.34%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   62.63%   62.98%   +0.34%     
==========================================
  Files          65       65              
  Lines        5101     5073      -28     
  Branches      765      756       -9     
==========================================
  Hits         3195     3195              
+ Misses       1683     1661      -22     
+ Partials      223      217       -6
Impacted Files Coverage Δ
torchvision/models/segmentation/segmentation.py 67.44% <87.5%> (+25.18%) ⬆️
torchvision/transforms/transforms.py 81.25% <0%> (-0.65%) ⬇️
torchvision/transforms/functional.py 71.12% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a64dbc...b479f34. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks a lot!

@fmassa fmassa merged commit 2f64dd9 into pytorch:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants